Remove temporary fix for mange_vms (#4177)

Author: jonathanmetzman

src/clusterfuzz/_internal/cron/manage_vms.py

@@ -19,7 +19,6 @@
 import itertools
 import json
 import logging
-from typing import List
 
 from google.cloud import ndb
 
@@ -157,21 +156,6 @@ def _template_needs_update(current_template, new_template, resource_name):
   return False
 
 
-def reverse_pairs(l: List) -> List:
-  """Temporary function to speedup resizing of group 8 which hasn't been
-  updating due to timeouts."""
-  l = list(reversed(l))
-  length = len(l)
-  l_output = []
-  for idx in range(0, length, 2):
-    if idx + 1 >= length:
-      l_output.append(l[idx])
-      continue
-    l_output.append(l[idx + 1])
-    l_output.append(l[idx])
-  return l_output
-
-
 class ClustersManager:
   """Manager for clusters in a project."""
 
@@ -202,10 +186,7 @@ def update_clusters(self):
     """Update all clusters in a project."""
     self.start_thread_pool()
 
-    # TODO(metzman): Remove reverse_pairs.
-    # Use this function so we don't introduce weird bugs by changing the order
-    # in which hosts and workers are reassigned.
-    for cluster in reverse_pairs(self.gce_project.clusters):
+    for cluster in self.gce_project.clusters:
       self.pending_updates.append(
           self.thread_pool.submit(self.update_cluster, cluster, cluster.name,
                                   cluster.instance_count))

src/clusterfuzz/_internal/tests/appengine/handlers/cron/manage_vms_test.py

@@ -1084,14 +1084,6 @@ def test_primes(self):
     self.assertEqual(3571, sum(result))
 
 
-class ReversePairsTest(unittest.TestCase):
-  """Tests reverse_pairs."""
-
-  def test_reverse_pairs(self):
-    l = list(range(6))
-    self.assertEqual(manage_vms.reverse_pairs(l), [4, 5, 2, 3, 0, 1])
-
-
 @test_utils.with_cloud_emulators('datastore')
 class AssignHostWorkerTest(unittest.TestCase):
   """Tests host -> worker assignment."""