Skip to content

Commit f202e3d

Browse files
committed
test improv
Signed-off-by: Javan Lacerda <[email protected]>
1 parent 7619dd3 commit f202e3d

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed

src/clusterfuzz/_internal/bot/tasks/utasks/corpus_pruning_task.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -515,8 +515,8 @@ def process_bad_units(self, bad_units_path, quarantine_corpus_path):
515515
crash_stacktrace=state.crash_stacktrace,
516516
unit_path=unit_path,
517517
security_flag=security_flag)
518-
logs.info('Found %d bad units, %d unique crashes.' % (num_bad_units,
519-
len(crashes)))
518+
logs.info(
519+
f'Found {num_bad_units} bad units, {len(crashes)} unique crashes.')
520520
return crashes
521521

522522

@@ -617,8 +617,8 @@ def _record_cross_pollination_stats(output):
617617

618618
def _get_pruner_and_runner(context):
619619
build_directory = environment.get_value('BUILD_DIR')
620-
match context.fuzz_target.engine:
621-
case 'libFuzzer':
620+
match context.fuzz_target.engine.lower():
621+
case 'libfuzzer':
622622
runner = LibFuzzerRunner(build_directory, context)
623623
pruner = LibFuzzerPruner(runner)
624624
case 'centipede':

src/clusterfuzz/_internal/tests/core/bot/tasks/utasks/corpus_pruning_task_test.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -402,8 +402,11 @@ def setUp(self):
402402
'clusterfuzz._internal.datastore.data_handler.update_task_status',
403403
'clusterfuzz._internal.datastore.data_handler.get_task_status',
404404
'clusterfuzz._internal.bot.fuzzers.centipede.engine.Engine.minimize_corpus',
405+
'clusterfuzz._internal.bot.tasks.utasks.corpus_pruning_task.Context._create_temp_corpus_directory',
405406
])
406407

408+
self.default_path = '/tmp/arbitrary/path'
409+
self.mock._create_temp_corpus_directory.return_value = self.default_path
407410
self.engine = centipede_engine.Engine()
408411
self.mock.setup_build.side_effect = self._mock_setup_build
409412
self.mock.get_application_id.return_value = 'project'
@@ -437,7 +440,7 @@ def test_prune(self):
437440
# asserting here
438441
self.mock.minimize_corpus.assert_called_once_with(
439442
self.engine, os.path.join(TEST_DIR, 'build/clusterfuzz_format_target'),
440-
[], [unittest.mock.ANY], unittest.mock.ANY, unittest.mock.ANY, 79200)
443+
[], [self.default_path], self.default_path, self.default_path, 79200)
441444

442445

443446
class GetProtoTimestampTest(unittest.TestCase):

0 commit comments

Comments
 (0)