Fxied compiler warnings.

Author: MarkusBordihn

package-lock.json

@@ -8,15 +8,15 @@
   "dependencies": {},
   "devDependencies": {
     "bestzip": "^1.1.6",
-    "closure-builder": "^2.3.2",
+    "closure-builder": "^2.3.4",
     "command-line-usage": "^5.0.5",
     "escape-string-regexp": "^1.0.5",
     "eslint": "^4.19.1",
     "eslint-config-google": "^0.9.1",
     "http-server": "latest",
     "jasmine-core": "^3.3.0",
     "jsdoc": "^3.5.5",
-    "karma": "^3.1.1",
+    "karma": "^3.1.4",
     "karma-chrome-launcher": "latest",
     "karma-closure": "latest",
     "karma-coverage": "^1.1.2",
@@ -27,9 +27,9 @@
     "markdownlint-cli": "^0.8.1",
     "mv": "^2.1.1",
     "nw": "^0.31.5",
-    "nw-builder": "^3.5.4",
+    "nw-builder": "^3.5.6",
     "replace-in-file": "^3.4.2",
-    "rimraf": "^2.6.2"
+    "rimraf": "^2.6.3"
   },
   "scripts": {
     "build": "npm run build:third_party && npm run build:core",

package.json

@@ -90,7 +90,7 @@ cwc.ui.Preview = function(helper) {
   /** @private {!goog.events.EventTarget} */
   this.eventHandler_ = new goog.events.EventTarget();
 
-  /** @private {!Object.<number>} */
+  /** @private {!Object.<number|null>} */
   this.eventTimer_ = {};
 
   /** @private {boolean} */

src/ui/preview/preview.js

@@ -122,6 +122,7 @@ cwc.ui.Tour.prototype.getTourDescription = function() {
   return this.tourDescription_ || '';
 };
 
+
 /**
  * @return {Shepherd.Tour|boolean}
  */
@@ -166,16 +167,18 @@ cwc.ui.Tour.prototype.clear = function() {
   this.tourLength_ = 0;
 };
 
+
 /**
  * @param {number} stepNumber
  * @param {number} tourLength
- * @param {function} cancel
- * @return {!array}
+ * @param {Function} cancel
+ * @return {!Array}
  * @private
  */
 cwc.ui.Tour.prototype.getStepButtons = function(stepNumber, tourLength,
   cancel) {
   let tourButtons = [];
+
   // Back button
   if (stepNumber > 0) {
     tourButtons.push({
@@ -205,6 +208,7 @@ cwc.ui.Tour.prototype.getStepButtons = function(stepNumber, tourLength,
       'classes': 'shepherd-button-example-primary',
     });
   }
+
   // Next button
   if (stepNumber < tourLength - 1) {
     tourButtons.push({
@@ -219,9 +223,10 @@ cwc.ui.Tour.prototype.getStepButtons = function(stepNumber, tourLength,
   return tourButtons;
 };
 
+
 /**
  * @param {number} stepNumber
- * @return {!array}
+ * @return {!Array}
  * @private
  */
 cwc.ui.Tour.prototype.processButtons_ = function(stepNumber) {

src/ui/tour/tour.js

@@ -75,13 +75,13 @@ cwc.ui.Tutorial = function(helper) {
   /** @private {!string} */
   this.completedStepClass_ = this.prefix + 'step-container--complete';
 
-  /** @private {!Element} */
+  /** @private {Element} */
   this.nodeMediaOverlay_ = null;
 
-  /** @private {!Element} */
+  /** @private {Element} */
   this.nodeMediaOverlayClose_ = null;
 
-  /** @private {!Element} */
+  /** @private {Element} */
   this.nodeMediaOverlayContent_ = null;
 
   /** @private {!cwc.utils.Database} */
@@ -178,7 +178,7 @@ cwc.ui.Tutorial.prototype.hasTutorial = function() {
 
 
 /**
- * @param {!object} steps
+ * @param {!Object} steps
  * @private
  */
 cwc.ui.Tutorial.prototype.parseSteps_ = async function(steps) {
@@ -205,7 +205,7 @@ cwc.ui.Tutorial.prototype.parseSteps_ = async function(steps) {
 
 
 /**
- * @param {!object} stepTemplate
+ * @param {!Object} stepTemplate
  * @param {!int} id
  * @private
  */
@@ -265,7 +265,7 @@ cwc.ui.Tutorial.prototype.addStep_ = async function(stepTemplate, id) {
 
 /**
  * @param {!string} key
- * @param {!object} data
+ * @param {!Object} data
  * @param {boolean} warnOnOverwrite
  * @return {string|boolean}
  */
@@ -311,7 +311,7 @@ cwc.ui.Tutorial.prototype.ensureUrlInDB_ =
 
 /**
  * @param {!Array} source
- * @param {!object} destination
+ * @param {!Object} destination
  * @param {!string} name
  * @return {!Promise}
  * @private
@@ -346,7 +346,7 @@ cwc.ui.Tutorial.prototype.appendBinaries_ =
 
 
 /**
- * @param {!object} spec
+ * @param {!Object} spec
  * @return {!string|boolean}
  * @private
  */
@@ -370,7 +370,7 @@ cwc.ui.Tutorial.prototype.ensureObjectInDb_ = async function(spec) {
 
 
 /**
- * @param {!object} description
+ * @param {!Object} description
  * @private
  * @return {boolean}
  */
@@ -395,7 +395,7 @@ cwc.ui.Tutorial.prototype.validateDescription_ = function(description) {
 
 
 /**
- * @param {!object} description
+ * @param {!Object} description
  * @private
  * @return {string}
  */

src/ui/tutorial/tutorial.js

@@ -37,6 +37,7 @@ cwc.ui.TutorialValidator.Type = {
   MATCH_TEXT_OUTPUT: 'match_text_output',
 };
 
+
 /**
  * @param {!cwc.utils.Helper} helper
  * @constructor
@@ -72,6 +73,7 @@ cwc.ui.TutorialValidator = function(helper) {
   this.running_ = false;
 };
 
+
 /**
  * Creates a validator webview/iframe with the same code as the preview and
  * runs validation code in it.
@@ -112,6 +114,7 @@ cwc.ui.TutorialValidator.prototype.start = function() {
   this.sandbox_['src'] = contentUrl;
 };
 
+
 /**
  * @return {string|null}
  * @private
@@ -139,6 +142,7 @@ cwc.ui.TutorialValidator.prototype.getValidate_ = function() {
   return validate;
 };
 
+
 /**
  * @param {string} textMatch
  * @param {string} message
@@ -164,6 +168,7 @@ cwc.ui.TutorialValidator.prototype.validateByMatchTextOutput_ =
   }
 };
 
+
 /**
  * @param {string} textOutput
  * @param {string} textMatch
@@ -185,9 +190,10 @@ cwc.ui.TutorialValidator.prototype.matchTextOutput_ = function(textOutput,
   this.processValidateResults_(result);
 };
 
+
 /**
  * Callback for validate.
- * @param {object} result
+ * @param {Object} result
  * @private
  */
 cwc.ui.TutorialValidator.prototype.processValidateResults_ = function(result) {
@@ -209,8 +215,8 @@ cwc.ui.TutorialValidator.prototype.processValidateResults_ = function(result) {
 /**
  * Injects code into an iframe/webview and handles the results.
  * @param {string} code
- * @param {any} expect
- * @param {int} timeout
+ * @param {?} expect
+ * @param {number} timeout
  * @private
  * @return {Promise}
  */
@@ -245,7 +251,7 @@ cwc.ui.TutorialValidator.prototype.injectCode_ = function(code, expect,
 
 
 /**
- * Calls the appropriate function to run validatior code in sandbox
+ * Calls the appropriate function to run validator code in sandbox
  * webview/iframe
  * @private
  */
@@ -359,7 +365,7 @@ cwc.ui.TutorialValidator.prototype.callValidator_ = function() {
 
 /**
  * Processes the results of the current step's validation function.
- * @param {Event} event
+ * @param {?} event
  * @private
  */
 cwc.ui.TutorialValidator.prototype.handleValidatorMessage_ = function(event) {
@@ -370,13 +376,12 @@ cwc.ui.TutorialValidator.prototype.handleValidatorMessage_ = function(event) {
   }
 
   if (!this.running()) {
-    this.log_.warn('Ignoring message', event,
-      'because valiation isn\'t running');
+    this.log_.warn('Ignoring message', event, 'validation isn\'t running');
     return;
   }
   if (!('source' in browserEvent) ||
     browserEvent['source'] !== this.sandbox_.contentWindow) {
-    this.log_.warn('Ignoring message', browserEvent, 'because source isn\'t',
+    this.log_.warn('Ignoring message', browserEvent, ' source isn\'t',
       this.sandbox_.contentWindow);
     return;
   }
@@ -386,19 +391,20 @@ cwc.ui.TutorialValidator.prototype.handleValidatorMessage_ = function(event) {
     this.processValidateResults_(browserEvent['data']['cwc-validate-result']);
     this.stop();
   } else {
-    this.log_.info('Igorning unknown event', browserEvent);
+    this.log_.info('Ignoring unknown event', browserEvent);
   }
 };
 
 
 /**
- * Determins if the script is running.
+ * Determines if the script is running.
  * @return {boolean}
  */
 cwc.ui.TutorialValidator.prototype.running = function() {
   return this.running_;
 };
 
+
 /**
  * Stops validation and cleans up events and sandbox.
  */
@@ -411,6 +417,7 @@ cwc.ui.TutorialValidator.prototype.stop = function() {
   this.running_ = false;
 };
 
+
 /**
  * @param {!string} text
  * @return {!string}

src/ui/tutorial/validator.js

@@ -406,7 +406,7 @@ cwc.utils.Dialog.prototype.isOpen = function(dialog) {
 
 
 /**
- * @return {!Element}
+ * @return {Element}
  */
 cwc.utils.Dialog.prototype.getCloseButton = function() {
   return goog.dom.getElement(this.prefix + 'close');