Fixed smaller issues and some tests.

MarkusBordihn · MarkusBordihn · commit c6afb2ddc928 · 2018-09-16T12:15:32.000+02:00
diff --git a/src/blocks/simple/blocks.js b/src/blocks/simple/blocks.js
@@ -41,7 +41,7 @@ Blockly.Blocks['simple_text_write'] = {
 /**
  * Write line.
  */
-Blockly.Blocks['simple_text_writeLine'] = {
+Blockly.Blocks['simple_text_write_line'] = {
   init: function() {
     this.setHelpUrl('');
     this.setColour(290);
@@ -52,10 +52,11 @@ Blockly.Blocks['simple_text_writeLine'] = {
       .appendField(')');
     this.setPreviousStatement(true, ['Number', 'String']);
     this.setNextStatement(true, ['Number', 'String']);
-    this.setTooltip(i18t('Writes the text on its own line the screen.'));
+    this.setTooltip(i18t('Writes the text on its own line on the screen.'));
   },
 };
 
+
 /**
  * Draw circle.
  */
diff --git a/src/blocks/simple/javascript.js b/src/blocks/simple/javascript.js
@@ -30,17 +30,19 @@ Blockly.JavaScript['simple_text_write'] = function(block) {
   return 'command.write(' + text + ');\n';
 };
 
+
 /**
  * Write line.
  * @param {!Blockly.block} block
  * @return {string}
  */
-Blockly.JavaScript['simple_text_writeLine'] = function(block) {
+Blockly.JavaScript['simple_text_write_line'] = function(block) {
   let text = Blockly.JavaScript.valueToCode(block, 'text',
       Blockly.JavaScript.ORDER_ATOMIC);
   return 'command.writeLine(' + text + ');\n';
 };
 
+
 /**
  * Draw circle.
  * @param {!Blockly.block} block
diff --git a/src/blocks/simple/toolbox.soy b/src/blocks/simple/toolbox.soy
@@ -32,7 +32,7 @@
           <block type="text"><field name="TEXT"></field></block>
         </value>
       </block>
-      <block type="simple_text_writeLine">
+      <block type="simple_text_write_line">
         <value name="text">
           <block type="text"><field name="TEXT"></field></block>
         </value>
diff --git a/test/.eslintrc b/test/.eslintrc
@@ -7,6 +7,7 @@
     'describe': true,
     'expect': true,
     'getTestBlockCode': true,
+    'getTestBlockWorkspace': true,
     'getTestBuffer': true,
     'it': true,
     'loadExampleFile': true,
diff --git a/test/block_tests/general_block_test.js b/test/block_tests/general_block_test.js
@@ -20,12 +20,7 @@
 
 
 describe('General Blocks', function() {
-  document.body.insertAdjacentHTML('afterbegin',
-    '<div id="test-workspace"></div>');
-  window['i18t'] = function(msg) {
-return msg;
-};
-
+  getTestBlockWorkspace();
   let blockPrefix = 'general_';
   let blocks = [];
   for (let block in Blockly.Blocks) {
diff --git a/test/block_tests/lego_ev3_block_test.js b/test/block_tests/lego_ev3_block_test.js
@@ -20,12 +20,7 @@
 
 
 describe('EV3 Blocks', function() {
-  document.body.insertAdjacentHTML('afterbegin',
-    '<div id="test-workspace"></div>');
-  window['i18t'] = function(msg) {
-return msg;
-};
-
+  getTestBlockWorkspace();
   let blockPrefix = 'ev3_';
   let blocks = [];
   for (let block in Blockly.Blocks) {
diff --git a/test/block_tests/makeblock_mbot_block_test.js b/test/block_tests/makeblock_mbot_block_test.js
@@ -20,12 +20,7 @@
 
 
 describe('mBot Blocks', function() {
-  document.body.insertAdjacentHTML('afterbegin',
-    '<div id="test-workspace"></div>');
-  window['i18t'] = function(msg) {
-return msg;
-};
-
+  getTestBlockWorkspace();
   let blockPrefix = 'mbot_';
   let blocks = [];
   for (let block in Blockly.Blocks) {
diff --git a/test/block_tests/phaser_block_test.js b/test/block_tests/phaser_block_test.js
@@ -20,12 +20,7 @@
 
 
 describe('Phaser Blocks', function() {
-  document.body.insertAdjacentHTML('afterbegin',
-    '<div id="test-workspace"></div>');
-  window['i18t'] = function(msg) {
-return msg;
-};
-
+  getTestBlockWorkspace();
   let blockPrefix = 'phaser_';
   let blocks = [];
   for (let block in Blockly.Blocks) {
diff --git a/test/block_tests/simple_block_test.js b/test/block_tests/simple_block_test.js
@@ -20,12 +20,7 @@
 
 
 describe('Simple Blocks', function() {
-  document.body.insertAdjacentHTML('afterbegin',
-    '<div id="test-workspace"></div>');
-  window['i18t'] = function(msg) {
-return msg;
-};
-
+  getTestBlockWorkspace();
   let blockPrefix = 'simple_';
   let blocks = [];
   for (let block in Blockly.Blocks) {
diff --git a/test/block_tests/sphero_block_test.js b/test/block_tests/sphero_block_test.js
@@ -20,12 +20,7 @@
 
 
 describe('Sphero Blocks', function() {
-  document.body.insertAdjacentHTML('afterbegin',
-    '<div id="test-workspace"></div>');
-  window['i18t'] = function(msg) {
-return msg;
-};
-
+  getTestBlockWorkspace();
   let blockPrefix = 'sphero_';
   let blocks = [];
   for (let block in Blockly.Blocks) {
diff --git a/test/block_tests/sphero_sprk_plus_test.js b/test/block_tests/sphero_sprk_plus_test.js
@@ -0,0 +1,58 @@
+/**
+ * @fileoverview Sphero SPRK+ block tests.
+ *
+ * @license Copyright 2018 The Coding with Chrome Authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ * @author mbordihn@google.com (Markus Bordihn)
+ */
+
+
+describe('Sphero SPRK+ Blocks', function() {
+  getTestBlockWorkspace();
+  let blockPrefix = 'sphero_sprk_plus_';
+  let blocks = [];
+  for (let block in Blockly.Blocks) {
+    if (block.startsWith(blockPrefix)) {
+      blocks.push(block);
+    }
+  }
+
+  let blockScripts = [];
+  for (let blockScript in Blockly.JavaScript) {
+    if (blockScript.startsWith(blockPrefix)) {
+      blockScripts.push(blockScript);
+    }
+  }
+
+  it('Block definition', function() {
+    expect(typeof Blockly.Blocks).toEqual('object');
+    expect(typeof blocks).toEqual('object');
+    expect(blocks.length > 0).toBe(true);
+  });
+
+  it('JavaScript definition', function() {
+    expect(typeof Blockly.JavaScript).toEqual('object');
+    expect(typeof blockScripts).toEqual('object');
+    expect(blockScripts.length > 0).toBe(true);
+    expect(blockScripts.length).toEqual(blocks.length);
+  });
+
+  blocks.forEach(function(block) {
+    it('Block ' + block + ' to workspace', function() {
+      let code = getTestBlockCode(block);
+      expect(code && code.length > 1).toBe(true);
+    });
+  });
+});
diff --git a/test/core_tests/tutorial_test.js b/test/core_tests/tutorial_test.js
@@ -18,6 +18,7 @@
  * @author carheden@google.com (Adam Carheden)
  */
 
+
 describe('Tutorial', function() {
   let sidebarId = 'cwc-sidebar';
   document.body.insertAdjacentHTML('afterbegin', `
diff --git a/test/global.js b/test/global.js
@@ -31,8 +31,19 @@ let prepareEditor = function() {
   }
 };
 
+let getTestBlockWorkspace = function() {
+  let workspace = document.getElementById('test-block-workspace');
+  if (!workspace) {
+    document.body.insertAdjacentHTML('afterbegin',
+      '<div id="test-block-workspace"></div>');
+    window['i18t'] = function(msg) {
+      return msg;
+    };
+  }
+};
+
 let getTestBlockCode = function(block) {
-  let blocklyDiv = document.getElementById('test-workspace');
+  let blocklyDiv = document.getElementById('test-block-workspace');
   let workspace = Blockly.inject(blocklyDiv);
   let xmlCode = '<xml xmlns="http://www.w3.org/1999/xhtml">\n' +
     '<block type="' + block + '"></block>\n</xml>';
