Skip to content

Commit 5d6e26a

Browse files
authored
Add missing docstring to birthday server implementation (#2464)
Without this, compilation fails. The comment *is* in the included Rust file — but we only include a fraction of the file to keep the example short. This makes it cumbersome to both show something that works in the slides while also making it possible for the instructor to show more complex examples. @randomPoison, we need to make our examples simpler here: the complexity here makes it hard to modify the files and I feel it's hard to show during class. I would suggest splitting this up into a very basic example (what the birthday service was) and then add 1-2 slides with more complex samples (if necessary). Last I taught the class, I had a hard time a) making every example compile and b) finding time to cover everything. I would err on the side of makings things simple and clear.
1 parent 8f1c867 commit 5d6e26a

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

src/android/aidl/example-service/service.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ We can now implement the AIDL service:
55
_birthday_service/src/lib.rs_:
66

77
```rust,ignore
8+
//! Implementation of the `IBirthdayService` AIDL interface.
89
use com_example_birthdayservice::aidl::com::example::birthdayservice::IBirthdayService::IBirthdayService;
910
use com_example_birthdayservice::binder;
1011

0 commit comments

Comments
 (0)