Skip to content

Commit c1773a7

Browse files
authored
Update some speaker notes for bare metal Rust section (#2764)
1 parent 64ef712 commit c1773a7

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

src/bare-metal/aps/better-uart/driver.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ Now let's use the new `Registers` struct in our driver.
1212
register. The caller of `UniqueMmioPointer::new` promises that it is valid and
1313
unique for the given lifetime, so it can provide safe methods to read and
1414
write fields.
15+
- Note that `Uart::new` is now safe; `UniqueMmioPointer::new` is unsafe instead.
1516
- These MMIO accesses are generally a wrapper around `read_volatile` and
1617
`write_volatile`, though on aarch64 they are instead implemented in assembly
1718
to work around a bug where the compiler can emit instructions that prevent

src/bare-metal/useful-crates/aarch64-paging.md

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -25,13 +25,11 @@ idmap.activate();
2525

2626
<details>
2727

28-
- For now it only supports EL1, but support for other exception levels should be
29-
straightforward to add.
3028
- This is used in Android for the [Protected VM Firmware][2].
31-
- There's no easy way to run this example, as it needs to run on real hardware
32-
or under QEMU.
29+
- There's no easy way to run this example by itself, as it needs to run on real
30+
hardware or under QEMU.
3331

3432
</details>
3533

3634
[1]: https://crates.io/crates/aarch64-paging
37-
[2]: https://cs.android.com/android/platform/superproject/+/master:packages/modules/Virtualization/pvmfw/
35+
[2]: https://cs.android.com/android/platform/superproject/main/+/main:packages/modules/Virtualization/guest/pvmfw/

0 commit comments

Comments
 (0)