Add dprint to install-tools task. #2849
Open
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egithinji
force-pushed
the
install-dprint
branch
from
0f261ec to
5b9b02a
Compare
qwandor
approved these changes
Aug 14, 2025
djmitche
approved these changes
Aug 15, 2025
|
I suspect the build failures were some sort of intermittent? I can't merge without them passing, but if necessary someone with admin privileges can. |
Not sure but might be related to rust-lang/rust#143835. So as not to break the CI might be better if it's resolved first. I'll keep an eye on it and dig deeper when I get a chance. |
|
Once dprint/dprint#1021 lands, we can upgrade our dprint version and I believe this should fix the build issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in CONTRIBUTING.md, dprint is used for formatting in the project. This PR adds dprint to the list of packages that are installed when one runs
cargo xtask install-tools.