Skip to content

Commit d8736bb

Browse files
hzellercopybara-github
authored andcommitted
Stop printing ItemKind
ItemKind::descr() was removed in rust-lang/rust#143279 An attempt to use the Debug-trait resulted in a time-out; looks like that match branch is taken often. PiperOrigin-RevId: 778914231 Change-Id: I74185604f693d804edf2a82bced4e91c82f6a985
1 parent 81e4ff8 commit d8736bb

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

bazel/llvm.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ def _llvm_loader_repository(repository_ctx):
5353
executable = False,
5454
)
5555

56-
LLVM_COMMIT_SHA = "7a33569510535f0b917a2e50f644bf57490aee24"
56+
LLVM_COMMIT_SHA = "696c0f92e0fef955e331895cd8d65fb6cc080ad3"
5757

5858
def llvm_loader_repository_dependencies():
5959
# This *declares* the dependency, but it won't actually be *downloaded* unless it's used.

cc_bindings_from_rs/generate_bindings/generate_bindings_test.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2563,7 +2563,7 @@ fn test_format_item_unsupported_static_value() {
25632563
"#;
25642564
test_format_item(test_src, "STATIC_VALUE", |result| {
25652565
let err = result.unwrap_err();
2566-
assert_eq!(err, "Unsupported rustc_hir::hir::ItemKind: static item");
2566+
assert!(err.starts_with("Unsupported rustc_hir::hir::ItemKind"));
25672567
});
25682568
}
25692569

cc_bindings_from_rs/generate_bindings/lib.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1131,7 +1131,7 @@ fn generate_item_impl(
11311131
Item { kind: ItemKind::Impl(_), .. } | // Handled by `generate_adt`
11321132
Item { kind: ItemKind::Mod(_, _), .. } => // Handled by `generate_crate`
11331133
Ok(None),
1134-
Item { kind, .. } => bail!("Unsupported rustc_hir::hir::ItemKind: {}", kind.descr()),
1134+
Item { .. } => bail!("Unsupported rustc_hir::hir::ItemKind"), // Don't Debug print: slow
11351135
};
11361136

11371137
if let Ok(Some(item)) = item {

0 commit comments

Comments
 (0)