Skip to content

Commit f0f4266

Browse files
Googlercopybara-github
authored andcommitted
Add missing dependencies.
PiperOrigin-RevId: 696920018 Change-Id: I1de3717d41dc30f088e56459e6aeb85e117209e5
1 parent 1844b85 commit f0f4266

File tree

3 files changed

+23
-18
lines changed

3 files changed

+23
-18
lines changed

rs_bindings_from_cc/bazel_support/BUILD

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ bzl_library(
2929
name = "toolchain_headers_bzl",
3030
srcs = ["toolchain_headers.bzl"],
3131
deps = [
32+
":additional_rust_srcs_for_crubit_bindings_aspect_hint_bzl",
3233
":providers_bzl",
3334
":rust_bindings_from_cc_utils_bzl",
3435
],
@@ -86,13 +87,19 @@ bzl_library(
8687
bzl_library(
8788
name = "generate_bindings_bzl",
8889
srcs = ["generate_bindings.bzl"],
89-
deps = ["@bazel_tools//tools/build_defs/cc:action_names"],
90+
deps = [
91+
"@bazel_skylib//rules:common_settings",
92+
"@bazel_tools//tools/build_defs/cc:action_names",
93+
],
9094
)
9195

9296
bzl_library(
9397
name = "compile_rust_bzl",
9498
srcs = ["compile_rust.bzl"],
95-
deps = ["@rules_rust//rust/private:bzl_lib"],
99+
deps = [
100+
"@bazel_skylib//lib:structs",
101+
"@rules_rust//rust/private:bzl_lib",
102+
],
96103
)
97104

98105
bzl_library(

rs_bindings_from_cc/bazel_support/rust_bindings_from_cc_aspect.bzl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -232,11 +232,11 @@ rust_bindings_from_cc_aspect = aspect(
232232
"_cc_lib",
233233
],
234234
required_aspect_providers = [CcInfo],
235-
attrs = dict(bindings_attrs.items() + {
235+
attrs = bindings_attrs | {
236236
"_std": attr.label(
237237
default = "//support/cc_std",
238238
),
239-
}.items()),
239+
},
240240
toolchains = [
241241
"@rules_rust//rust:toolchain_type",
242242
"@bazel_tools//tools/cpp:toolchain_type",

rs_bindings_from_cc/bazel_support/toolchain_headers.bzl

Lines changed: 12 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -94,20 +94,18 @@ def _bindings_for_toolchain_headers_impl(ctx):
9494

9595
bindings_for_toolchain_headers = rule(
9696
implementation = _bindings_for_toolchain_headers_impl,
97-
attrs = dict(
98-
bindings_attrs.items() + {
99-
# TODO(b/336981839): Delete this once cl/671582196 makes it to stable.
100-
"hdrs": attr.label(default = "//support/cc_std:empty_filegroup"),
101-
# Additional internal headers that are not part of the standard library. These headers will
102-
# receive bindings which are exposed along with the standard library bindings.
103-
# Everything inside these under should be hidden within namespace `crubit_cc_std_internal`.
104-
"extra_hdrs": attr.label_list(default = []),
105-
"public_libc_hdrs": attr.string_list(),
106-
"public_libcxx_hdrs": attr.string_list(),
107-
"extra_rs_srcs": attr.label_list(allow_files = True),
108-
"_stl": attr.label(default = "//third_party/stl:stl"),
109-
}.items(),
110-
),
97+
attrs = bindings_attrs | {
98+
# TODO(b/336981839): Delete this once cl/671582196 makes it to stable.
99+
"hdrs": attr.label(default = "//support/cc_std:empty_filegroup"),
100+
# Additional internal headers that are not part of the standard library. These headers will
101+
# receive bindings which are exposed along with the standard library bindings.
102+
# Everything inside these under should be hidden within namespace `crubit_cc_std_internal`.
103+
"extra_hdrs": attr.label_list(default = []),
104+
"public_libc_hdrs": attr.string_list(),
105+
"public_libcxx_hdrs": attr.string_list(),
106+
"extra_rs_srcs": attr.label_list(allow_files = True),
107+
"_stl": attr.label(default = "//third_party/stl:stl"),
108+
},
111109
toolchains = [
112110
"@rules_rust//rust:toolchain_type",
113111
"@bazel_tools//tools/cpp:toolchain_type",

0 commit comments

Comments
 (0)