Skip to content

Commit 0232ae0

Browse files
bcorsoDagger Team
authored andcommitted
Update bazel to use java 21.
Required also updating `rules_java` to 7.12.1 to get access to Java 21. RELNOTES=N/A PiperOrigin-RevId: 682556297
1 parent e62fb19 commit 0232ae0

File tree

17 files changed

+41
-30
lines changed

17 files changed

+41
-30
lines changed

.bazelrc

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,10 @@ build --host_javacopt="-Xep:BetaApi:OFF"
1818
build --incompatible_sandbox_hermetic_tmp
1919

2020
# Sets the JDK for compiling sources and executing tests.
21-
build --java_language_version=18
22-
build --tool_java_language_version=18
23-
build --java_runtime_version=remotejdk_18
24-
build --tool_java_runtime_version=remotejdk_18
21+
build --java_language_version=21
22+
build --tool_java_language_version=21
23+
build --java_runtime_version=remotejdk_21
24+
build --tool_java_runtime_version=remotejdk_21
2525

2626
# Default source/target versions.
2727
build --javacopt="-source 8 -target 8"

WORKSPACE

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,11 +51,16 @@ bazel_skylib_workspace()
5151
# Load rules_java repository
5252
#############################
5353

54+
RULES_JAVA_VERSION = "7.12.1"
55+
5456
http_archive(
5557
name = "rules_java",
56-
sha256 = "c73336802d0b4882e40770666ad055212df4ea62cfa6edf9cb0f9d29828a0934",
57-
url = "https://github.com/bazelbuild/rules_java/releases/download/5.3.5/rules_java-5.3.5.tar.gz",
58+
urls = ["https://github.com/bazelbuild/rules_java/releases/download/%s/rules_java-%s.tar.gz" % (RULES_JAVA_VERSION, RULES_JAVA_VERSION)],
59+
sha256 = "dfbadbb37a79eb9e1cc1e156ecb8f817edf3899b28bc02410a6c1eb88b1a6862",
5860
)
61+
load("@rules_java//java:repositories.bzl", "rules_java_dependencies", "rules_java_toolchains")
62+
rules_java_dependencies()
63+
rules_java_toolchains()
5964

6065
#############################
6166
# Load Android Sdk

java/dagger/hilt/android/processor/internal/viewmodel/BUILD

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414

1515
# Description:
1616
# ViewModelInject processor.
17-
load("@io_bazel_rules_kotlin//kotlin:kotlin.bzl", "kt_jvm_library")
17+
load("@io_bazel_rules_kotlin//kotlin:jvm.bzl", "kt_jvm_library")
1818
load("@rules_java//java:defs.bzl", "java_plugin")
1919

2020
package(default_visibility = ["//:src"])

java/dagger/hilt/processor/internal/BUILD

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
# Description:
1616
# Internal code for implementing Hilt processors.
1717

18-
load("@io_bazel_rules_kotlin//kotlin:kotlin.bzl", "kt_jvm_library")
18+
load("@io_bazel_rules_kotlin//kotlin:jvm.bzl", "kt_jvm_library")
1919
load("@rules_java//java:defs.bzl", "java_library")
2020

2121
package(default_visibility = ["//:src"])

java/dagger/hilt/processor/internal/root/ir/BUILD

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
# A library containing intermediate representations of the various Hilt
1717
# aggregating annotations along with logic to process them.
1818

19-
load("@io_bazel_rules_kotlin//kotlin:kotlin.bzl", "kt_jvm_library")
19+
load("@io_bazel_rules_kotlin//kotlin:jvm.bzl", "kt_jvm_library")
2020

2121
package(default_visibility = ["//:src"])
2222

java/dagger/lint/BUILD

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
# Description:
1616
# Dagger Lint Rules
1717

18-
load("@io_bazel_rules_kotlin//kotlin:kotlin.bzl", "kt_jvm_library")
18+
load("@io_bazel_rules_kotlin//kotlin:jvm.bzl", "kt_jvm_library")
1919
load("//:build_defs.bzl", "POM_VERSION")
2020
load("//tools/maven:maven.bzl", "gen_maven_artifact")
2121

java/dagger/spi/model/BUILD

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
# Description:
1616
# Dagger's core APIs exposed for plugins
1717

18-
load("@io_bazel_rules_kotlin//kotlin:kotlin.bzl", "kt_jvm_library")
18+
load("@io_bazel_rules_kotlin//kotlin:jvm.bzl", "kt_jvm_library")
1919

2020
package(default_visibility = [
2121
# The dagger/spi should be the only direct dependent on this target.

java/dagger/testing/compile/macros.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
"""Macros for building compiler tests."""
1515

1616
load("@rules_java//java:defs.bzl", "java_binary", "java_test")
17-
load("@io_bazel_rules_kotlin//kotlin:kotlin.bzl", "kt_jvm_library")
17+
load("@io_bazel_rules_kotlin//kotlin:jvm.bzl", "kt_jvm_library")
1818

1919
def compiler_test(name, size = "large", compiler_deps = None, **kwargs):
2020
"""Generates a java_test that tests java compilation with the given compiler deps.

javatests/dagger/functional/assisted/BUILD

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ GenJavaTests(
2525
srcs = ["AssistedFactoryAsQualifiedBindingTest.java"],
2626
javacopts = DOCLINT_HTML_AND_SYNTAX,
2727
test_only_deps = [
28+
"//third_party/java/guava/collect", # TODO(b/): This shouldn't be needed.
2829
"//:dagger_with_compiler",
2930
"//third_party/java/truth",
3031
"//third_party/java/junit",
@@ -114,6 +115,7 @@ GenJavaTests(
114115
srcs = ["AssistedFactoryWithMultibindingsTest.java"],
115116
javacopts = DOCLINT_HTML_AND_SYNTAX,
116117
test_only_deps = [
118+
"//third_party/java/guava/collect", # TODO(b/): This shouldn't be needed.
117119
"//:dagger_with_compiler",
118120
"//third_party/java/truth",
119121
"//third_party/java/junit",

javatests/dagger/functional/basic/BasicTest.java

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -61,23 +61,23 @@ public class BasicTest {
6161
}
6262

6363
@Theory public void boxedPrimitives(BasicComponent basicComponent) {
64-
assertThat(basicComponent.getBoxedByte()).isEqualTo(new Byte(BOUND_BYTE));
65-
assertThat(basicComponent.getBoxedChar()).isEqualTo(new Character(BOUND_CHAR));
66-
assertThat(basicComponent.getBoxedShort()).isEqualTo(new Short(BOUND_SHORT));
67-
assertThat(basicComponent.getBoxedInt()).isEqualTo(new Integer(BOUND_INT));
68-
assertThat(basicComponent.getBoxedLong()).isEqualTo(new Long(BOUND_LONG));
69-
assertThat(basicComponent.getBoxedBoolean()).isEqualTo(new Boolean(BOUND_BOOLEAN));
64+
assertThat(basicComponent.getBoxedByte()).isEqualTo(Byte.valueOf(BOUND_BYTE));
65+
assertThat(basicComponent.getBoxedChar()).isEqualTo(Character.valueOf(BOUND_CHAR));
66+
assertThat(basicComponent.getBoxedShort()).isEqualTo(Short.valueOf(BOUND_SHORT));
67+
assertThat(basicComponent.getBoxedInt()).isEqualTo(Integer.valueOf(BOUND_INT));
68+
assertThat(basicComponent.getBoxedLong()).isEqualTo(Long.valueOf(BOUND_LONG));
69+
assertThat(basicComponent.getBoxedBoolean()).isEqualTo(Boolean.valueOf(BOUND_BOOLEAN));
7070
assertThat(basicComponent.getBoxedFloat()).isEqualTo(BOUND_FLOAT);
7171
assertThat(basicComponent.getBoxedDouble()).isEqualTo(BOUND_DOUBLE);
7272
}
7373

7474
@Theory public void boxedPrimitiveProviders(BasicComponent basicComponent) {
75-
assertThat(basicComponent.getByteProvider().get()).isEqualTo(new Byte(BOUND_BYTE));
76-
assertThat(basicComponent.getCharProvider().get()).isEqualTo(new Character(BOUND_CHAR));
77-
assertThat(basicComponent.getShortProvider().get()).isEqualTo(new Short(BOUND_SHORT));
78-
assertThat(basicComponent.getIntProvider().get()).isEqualTo(new Integer(BOUND_INT));
79-
assertThat(basicComponent.getLongProvider().get()).isEqualTo(new Long(BOUND_LONG));
80-
assertThat(basicComponent.getBooleanProvider().get()).isEqualTo(new Boolean(BOUND_BOOLEAN));
75+
assertThat(basicComponent.getByteProvider().get()).isEqualTo(Byte.valueOf(BOUND_BYTE));
76+
assertThat(basicComponent.getCharProvider().get()).isEqualTo(Character.valueOf(BOUND_CHAR));
77+
assertThat(basicComponent.getShortProvider().get()).isEqualTo(Short.valueOf(BOUND_SHORT));
78+
assertThat(basicComponent.getIntProvider().get()).isEqualTo(Integer.valueOf(BOUND_INT));
79+
assertThat(basicComponent.getLongProvider().get()).isEqualTo(Long.valueOf(BOUND_LONG));
80+
assertThat(basicComponent.getBooleanProvider().get()).isEqualTo(Boolean.valueOf(BOUND_BOOLEAN));
8181
assertThat(basicComponent.getFloatProvider().get()).isEqualTo(BOUND_FLOAT);
8282
assertThat(basicComponent.getDoubleProvider().get()).isEqualTo(BOUND_DOUBLE);
8383
}

0 commit comments

Comments
 (0)