Skip to content

Commit a8581e0

Browse files
Chang-EricDagger Team
authored andcommitted
Make dagger.internal.Provider extend jakarta.inject.Provider.
Issue #2058. RELNOTES=Add a jakarta.inject.Provider runtime dependency in preparation for supporting Jakarta Providers PiperOrigin-RevId: 634896178
1 parent f41033c commit a8581e0

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

java/dagger/BUILD

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ java_library(
3434
exports = ["//third_party/java/jsr330_inject"],
3535
deps = [
3636
"//third_party/java/jsr330_inject",
37+
"@maven//:jakarta_inject_jakarta_inject_api",
3738
],
3839
)
3940

@@ -43,6 +44,7 @@ gen_maven_artifact(
4344
artifact_name = "Dagger",
4445
artifact_target = ":core",
4546
artifact_target_maven_deps = [
47+
"jakarta.inject:jakarta.inject-api",
4648
"javax.inject:javax.inject",
4749
],
4850
javadoc_root_packages = ["dagger"],

java/dagger/internal/Provider.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,5 @@
2020
* Internal Provider interface to make support for {@code javax.inject.Provider} and
2121
* {@code jakarta.inject.Provider} easier. Do not use outside of Dagger implementation code.
2222
*/
23-
// TODO(erichang): Make this also extend the Jakarta Provider
24-
public interface Provider<T> extends javax.inject.Provider<T> {
23+
public interface Provider<T> extends javax.inject.Provider<T>, jakarta.inject.Provider<T> {
2524
}

0 commit comments

Comments
 (0)