Ignore StateError when closing sockets, and attempt multiple times. (#270)

Author: jonasfj

neat_cache/CHANGELOG.md

@@ -1,3 +1,7 @@
+## v2.0.5
+ * Ignore undocumented errors from `Socket.close`.
+ * Add additional calls to `Socket.close` after all streams have consumed.
+
 ## v2.0.4
  * Reconnect when a redis command fails.
 

neat_cache/lib/src/providers/resp.dart

@@ -145,7 +145,7 @@ class RespClient {
   /// [1]: https://redis.io/topics/protocol
   Future<Object?> command(List<Object> args) async {
     if (_closing) {
-      throw RedisConnectionException._('redis connection is closed');
+      throw RedisConnectionException._('redis connection is closing');
     }
 
     final out = BytesBuilder(copy: false);
@@ -215,13 +215,39 @@ class RespClient {
       }
     }
 
+    // Ensure that we also attempt to close the [Socket] after all pending
+    // commands have been sent.
+    //
+    // This may be necessary, as it appears that [Socket] from 'dart:io' may
+    // throw [StateError], if it's bound to stream when [close] is called.
+    //
+    // See: https://github.com/dart-lang/sdk/issues/41707
+    _pendingStream = _pendingStream.then((_) async {
+      try {
+        await _output.close();
+      } catch (e) {
+        // ignore
+      }
+    });
+
     if (!force) {
       scheduleMicrotask(() async {
-        await _output.close().catchError((_) {/* ignore */});
+        try {
+          await _output.close();
+        } catch (e) {
+          // ignore
+        }
       });
       await _closed.future;
     } else {
-      await _output.close().catchError((_) {/* ignore */});
+      try {
+        // TODO(https://github.com/dart-lang/sdk/issues/61743): Sadly, this can throw, it can even throw synchroniously,
+        //       implying [Socket] from 'dart:io' fails to implement
+        //       [StreamSink] as specified.
+        await _output.close();
+      } catch (e) {
+        // ignore
+      }
 
       // Resolve all outstanding requests
       final pending = _pending.toList(growable: false);

neat_cache/pubspec.yaml

@@ -1,5 +1,5 @@
 name: neat_cache
-version: 2.0.4
+version: 2.0.5
 description: >-
   A neat cache abstraction for wrapping in-memory or redis caches.
 homepage: https://github.com/google/dart-neats/tree/master/neat_cache