[dawn][tests] Allow using ASSERT_DEVICE_ERROR in helper functions

In ValidationTest, ASSERT_DEVICE_ERROR used GTest's FAIL() macro which
immediately returns and prevents usage of it in helper functions that
return a value. Instead use ADD_FAILURE that doesn't cause an early
return.

Bug: 463925499
Change-Id: I0311509e9c3a42ca97b9bfc45f3975880c33b31b
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/280895
Reviewed-by: dan sinclair <dsinclair@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Auto-Submit: Corentin Wallez <cwallez@chromium.org>

Author: Kangz

src/dawn/tests/unittests/validation/ValidationTest.h

@@ -61,26 +61,26 @@
                   UNIMPLEMENTED_MACRO))                                                  \
     (__VA_ARGS__)
 
-#define ASSERT_DEVICE_ERROR_IMPL_1_(statement)                  \
-    StartExpectDeviceError();                                   \
-    statement;                                                  \
-    device.Tick();                                              \
-    FlushWire();                                                \
-    if (!EndExpectDeviceError()) {                              \
-        FAIL() << "Expected device error in:\n " << #statement; \
-    }                                                           \
-    do {                                                        \
+#define ASSERT_DEVICE_ERROR_IMPL_1_(statement)                         \
+    StartExpectDeviceError();                                          \
+    statement;                                                         \
+    device.Tick();                                                     \
+    FlushWire();                                                       \
+    if (!EndExpectDeviceError()) {                                     \
+        ADD_FAILURE() << "Expected device error in:\n " << #statement; \
+    }                                                                  \
+    do {                                                               \
     } while (0)
 
-#define ASSERT_DEVICE_ERROR_IMPL_2_(statement, matcher)         \
-    StartExpectDeviceError(matcher);                            \
-    statement;                                                  \
-    device.Tick();                                              \
-    FlushWire();                                                \
-    if (!EndExpectDeviceError()) {                              \
-        FAIL() << "Expected device error in:\n " << #statement; \
-    }                                                           \
-    do {                                                        \
+#define ASSERT_DEVICE_ERROR_IMPL_2_(statement, matcher)                \
+    StartExpectDeviceError(matcher);                                   \
+    statement;                                                         \
+    device.Tick();                                                     \
+    FlushWire();                                                       \
+    if (!EndExpectDeviceError()) {                                     \
+        ADD_FAILURE() << "Expected device error in:\n " << #statement; \
+    }                                                                  \
+    do {                                                               \
     } while (0)
 
 // Skip a test when the given condition is satisfied.