[bindless] Reassign TODOs to more precise issues.

Bug: 473444513, 473354062, 473444514, 473354063, 473442434, 473444515, 473354064, 473442435, 473354065, 473459218, 435317394, 465122000
Change-Id: If258bcc5ad9e7ad841242910ae3f9316d100faf7
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/283075
Reviewed-by: dan sinclair <dsinclair@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>

Author: Kangz

src/dawn/common/Constants.h

@@ -112,9 +112,9 @@ static constexpr uint32_t kMaxDynamicUniformBuffersPerPipelineLayout = 16u;
 static constexpr uint32_t kMaxDynamicStorageBuffersPerPipelineLayout = 16u;
 
 // Default limit for the ResourceTable size.
-// TODO(https://issues.chromium.org/issues/435317394): Update once the spec decides on a value.
+// TODO(https://issues.chromium.org/465122000): Update once the spec decides on a value.
 static constexpr uint32_t kMaxResourceTableSize = 50'000;
-// TODO(https://issues.chromium.org/issues/435317394): Find if this is a reasonable amount to
+// TODO(https://issues.chromium.org/465122000): Find if this is a reasonable amount to
 // reserve for placeholders.
 static constexpr uint32_t kReservedResourceTableSlots = 1000;
 

src/dawn/native/ResourceTable.cpp

@@ -47,10 +47,10 @@ tint::ResourceType ComputeTypeId(const TextureViewBase* view) {
     }
     const TextureBase* texture = view->GetTexture();
 
-    // TODO(https://crbug.com/435317394): In the future we should allow the same compatibility rules
-    // that exist between TextureView and BGLEntry. This means that a depth texture can be either a
-    // texture_depth_2d, or a texture_2d<f32> (unfilterable). We should also find a way to
-    // differentiate unfilterable and filterable texture_2d<f32>.
+    // TODO(https://issues.chromium.org/473354065): In the future we should allow the same
+    // compatibility rules that exist between TextureView and BGLEntry. This means that a depth
+    // texture can be either a texture_depth_2d, or a texture_2d<f32> (unfilterable). We should
+    // also find a way to differentiate unfilterable and filterable texture_2d<f32>.
 
     if (texture->IsMultisampledTexture()) {
         DAWN_ASSERT(view->GetDimension() == wgpu::TextureViewDimension::e2D);
@@ -158,17 +158,17 @@ MaybeError ValidateBindingResource(const DeviceBase* device, const BindingResour
     DAWN_INVALID_IF(resourceCount != 1,
                     "%i resources are specified (when there must be exactly 1).", resourceCount);
 
-    // TODO(https://issues.chromium.org/435317394): Support buffers in FullResourceTable.
+    // TODO(https://issues.chromium.org/473444515): Support buffers in FullResourceTable.
     if (resource->buffer != nullptr) {
         return DAWN_VALIDATION_ERROR("Buffers are not supported.");
     }
 
-    // TODO(https://issues.chromium.org/435317394): Support samplers in SamplingResourceTable.
+    // TODO(https://issues.chromium.org/473354063): Support samplers in SamplingResourceTable.
     if (resource->sampler != nullptr) {
         return DAWN_VALIDATION_ERROR("Samplers are not supported.");
     }
 
-    // TODO(https://issues.chromium.org/435317394): Support texel buffers in FullResourceTable.
+    // TODO(https://issues.chromium.org/473444515): Support texel buffers in FullResourceTable.
 
     if (resource->textureView != nullptr) {
         TextureViewBase* view = resource->textureView;
@@ -178,7 +178,7 @@ MaybeError ValidateBindingResource(const DeviceBase* device, const BindingResour
         DAWN_INVALID_IF(!HasOneBit(aspect),
                         "Multiple aspects (%s) selected in %s. Expected only 1.", aspect, view);
 
-        // TODO(https://issues.chromium.org/435317394): Support storage textures in
+        // TODO(https://issues.chromium.org/473444515): Support storage textures in
         // FullResourceTable
         DAWN_INVALID_IF(
             (view->GetUsage() & kTextureViewOnlyUsages) != wgpu::TextureUsage::TextureBinding,
@@ -493,7 +493,7 @@ void ResourceTableBase::Remove(ResourceTableSlot slot) {
 }
 
 void ResourceTableBase::SetEntry(ResourceTableSlot slot, const BindingResource* contents) {
-    // TODO(435317394): Support resources that aren't TextureViews
+    // TODO(https://issues.chromium.org/473354063): Support resources that aren't TextureViews
     DAWN_ASSERT(contents->buffer == nullptr && contents->sampler == nullptr);
     TextureViewBase* view = contents->textureView;
 

src/dawn/native/ShaderModule.cpp

@@ -1210,7 +1210,8 @@ ResultOrError<std::unique_ptr<EntryPointMetadata>> ReflectEntryPointUsingTint(
     }
 
     // Resource table reflection.
-    // TODO(crbug.com/435317394): Check that the list of uses of the resource table are
+    // TODO(https://issues.chromium.org/473354064): Check that the list of uses of the resource
+    // table are:
     // 1) compatible with the bindless feature enabled (sampling vs. full)
     // 2) potentially that each type used is enabled by whatever feature enables it (for example
     // texel buffers might require an extension)

src/dawn/native/Texture.cpp

@@ -1673,8 +1673,9 @@ MaybeError TextureBase::ValidatePin(wgpu::TextureUsage usage) const {
     DAWN_INVALID_IF(!IsSubset(usage, kShaderTextureUsages),
                     "Pinned usages %s contain non-shader usages.", usage);
 
-    // TODO(https://crbug.com/435317394): Support pinning for readonly storage and storage as well.
-    // This might require adding readonly storage in the API so it can be specified.
+    // TODO(https://issues.chromium.org/473459218): Support pinning for readonly storage and
+    // storage as well. This might require adding readonly storage in the API so it can be
+    // specified.
     DAWN_INVALID_IF(
         usage != wgpu::TextureUsage::TextureBinding,
         "Pinned usages %s is not %s (which is required in the current bindless prototype).", usage,

src/dawn/native/d3d12/CommandBufferD3D12.cpp

@@ -1480,7 +1480,7 @@ MaybeError CommandBuffer::RecordComputePass(CommandRecordingContext* commandCont
             }
 
             case Command::SetResourceTable: {
-                // TODO(https://issues.chromium.org/435317394): Add support for resource tables.
+                // TODO(https://issues.chromium.org/473354062): Add support for resource tables.
                 return DAWN_UNIMPLEMENTED_ERROR("SetResourceTable unimplemented.");
             }
 

src/dawn/native/d3d12/DeviceD3D12.cpp

@@ -425,7 +425,7 @@ Ref<RenderPipelineBase> Device::CreateUninitializedRenderPipelineImpl(
 }
 ResultOrError<Ref<ResourceTableBase>> Device::CreateResourceTableImpl(
     const ResourceTableDescriptor* descriptor) {
-    // TODO(https://issues.chromium.org/435317394): Implement resource tables in D3D12.
+    // TODO(https://issues.chromium.org/473354062): Implement resource tables in D3D12.
     return DAWN_UNIMPLEMENTED_ERROR("ResourceTable is not implemented on D3D12");
 }
 ResultOrError<Ref<SamplerBase>> Device::CreateSamplerImpl(const SamplerDescriptor* descriptor) {

src/dawn/native/metal/CommandBufferMTL.mm

@@ -1553,7 +1553,7 @@ void RecordCopyBufferToTexture(CommandRecordingContext* commandContext,
             }
 
             case Command::SetResourceTable: {
-                // TODO(https://issues.chromium.org/435317394): Add support for resource tables.
+                // TODO(https://issues.chromium.org/473444514): Add support for resource tables.
                 return DAWN_UNIMPLEMENTED_ERROR("SetResourceTable unimplemented.");
             }
 

src/dawn/native/metal/DeviceMTL.mm

@@ -222,7 +222,7 @@ void UpdateTimestampPeriod(id<MTLDevice> device,
 }
 ResultOrError<Ref<ResourceTableBase>> Device::CreateResourceTableImpl(
     const ResourceTableDescriptor* descriptor) {
-    // TODO(https://issues.chromium.org/435317394): Implement resource tables in Metal.
+    // TODO(https://issues.chromium.org/473444514): Implement resource tables in Metal.
     return DAWN_UNIMPLEMENTED_ERROR("ResourceTable is not implemented on Metal");
 }
 ResultOrError<Ref<SamplerBase>> Device::CreateSamplerImpl(const SamplerDescriptor* descriptor) {

src/dawn/native/vulkan/PhysicalDeviceVk.cpp

@@ -650,7 +650,7 @@ void PhysicalDevice::InitializeSupportedFeaturesImpl() {
             EnableFeature(Feature::ChromiumExperimentalSamplingResourceTable);
         }
 
-        // TODO(https://issues.chromium.org/435317394): add support for heterogeneous bindless by
+        // TODO(https://issues.chromium.org/473444515): add support for heterogeneous bindless by
         // checking both for storage buffers/images limits and some support for heterogeneous
         // bindings via VK_EXT_mutable_descriptor_type, VK_EXT_descriptor_buffer or descriptor
         // heaps.

src/dawn/native/vulkan/ResourceTableVk.cpp

@@ -192,10 +192,10 @@ MaybeError ResourceTable::ApplyPendingUpdates(CommandRecordingContext* recording
 MaybeError ResourceTable::UpdateMetadataBuffer(CommandRecordingContext* recordingContext,
                                                const std::vector<MetadataUpdate>& updates) {
     // Updates the metadata buffer by scheduling a copy for each u32 that needs to be updated.
-    // TODO(https://crbug.com/435317394): If we had a way to use Dawn reentrantly now, we could use
-    // a compute shader to dispatch the updates instead of individual copies for each update, and
-    // move that logic in the frontend to share it between backends. (also a single dispatch could
-    // update multiple metadata buffers potentially).
+    // TODO(https://issues.chromium.org/473442435): If we had a way to use Dawn reentrantly now, we
+    // could use a compute shader to dispatch the updates instead of individual copies for each
+    // update, and move that logic in the frontend to share it between backends. (also a single
+    // dispatch could update multiple metadata buffers potentially).
     Device* device = ToBackend(GetDevice());
 
     // Allocate enough space for all the data to modify and schedule the copies.
@@ -241,8 +241,8 @@ void ResourceTable::UpdateResourceBindings(const std::vector<ResourceUpdate>& up
     std::vector<uint32_t> arrayElements;
 
     for (const ResourceUpdate& update : updates) {
-        // TODO(https://issues.chromium.org/435317394): Support samplers updates.
-        // TODO(https://issues.chromium.org/435317394): Support buffer, texel buffers and storage
+        // TODO(https://issues.chromium.org/473354063): Support samplers updates.
+        // TODO(https://issues.chromium.org/473444515): Support buffer, texel buffers and storage
         // textures.
 
         VkImageView handle = ToBackend(update.textureView)->GetHandle();