Skip to content

Commit d15a5db

Browse files
dj2Dawn LUCI CQ
authored andcommitted
Remove robustness gate for vertex pulling.
We want to always default vertex pulling to true, regardless of the state of robustness. Remove the guard on setting the default to true. Change-Id: I7ec24bec5217253669dfb9a3c8032821f4ba33d9 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/272894 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: dan sinclair <dsinclair@chromium.org>
1 parent 72268bf commit d15a5db

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

src/dawn/native/metal/PhysicalDeviceMTL.mm

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -423,11 +423,9 @@ bool IsGPUCounterSupported(id<MTLDevice> device,
423423
deviceToggles->Default(Toggle::DisableBaseInstance, !haveBaseVertexBaseInstance);
424424
}
425425

426-
// Vertex buffer robustness is implemented by using programmable vertex pulling. Enable
427-
// that code path if it isn't explicitly disabled.
428-
if (!deviceToggles->IsEnabled(Toggle::DisableRobustness)) {
429-
deviceToggles->Default(Toggle::MetalEnableVertexPulling, true);
430-
}
426+
// Vertex buffer robustness is implemented by using programmable vertex pulling. The
427+
// VertexPulling transform also handles non-4-byte aligned vertex buffer accesses.
428+
deviceToggles->Default(Toggle::MetalEnableVertexPulling, true);
431429

432430
// Shader `discard_fragment` changed semantics to be uniform in Metal 2.3+. See section 6.10.1.3
433431
// of the Metal Spec (v3.2).

0 commit comments

Comments
 (0)