Skip to content

Commit d82bce0

Browse files
bsheedy-workDawn LUCI CQ
authored andcommitted
Ignore stderr when retrieving remote revision
Keeps stdout and stderr separate in roll_chromium_deps.py when getting a remote HEAD revision. This is a speculative fix for the autoroller getting clearly incorrect (timestamp-like) revisions that are not seen when running locally. ANGLE's equivalent keeps stdout and stderr separate. Bug: 452840620, b/465468828 Change-Id: Ifddb6979276895db3a70a77666843e4e1a35592f Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/280560 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@google.com> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
1 parent a8dfd9e commit d82bce0

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

scripts/roll_chromium_deps.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -437,11 +437,7 @@ def _get_remote_head_revision(remote_url: str) -> str:
437437
remote_url,
438438
'HEAD',
439439
]
440-
proc = subprocess.run(cmd,
441-
check=True,
442-
text=True,
443-
stdout=subprocess.PIPE,
444-
stderr=subprocess.STDOUT)
440+
proc = subprocess.run(cmd, check=True, capture_output=True, text=True)
445441
head_revision = proc.stdout.strip().split()[0]
446442
return head_revision
447443

0 commit comments

Comments
 (0)