Skip to content

Commit df283ac

Browse files
kainino0xDawn LUCI CQ
authored andcommitted
[emscripten] Use wasm-friendly overload of setBindGroup
This was fixed in Firefox, so now we can use it! Tested in my local sample project that this works in both Chrome and Firefox Nightly. Migrated from emscripten-core/emscripten#21221 No-Try: true Bug: emscripten-core/emscripten#20280 Change-Id: I0900e635a043413e516ec73b7de4978d4e574724 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/236936 Auto-Submit: Kai Ninomiya <[email protected]> Commit-Queue: Kai Ninomiya <[email protected]> Reviewed-by: Loko Kung <[email protected]>
1 parent cde3c14 commit df283ac

File tree

1 file changed

+3
-15
lines changed

1 file changed

+3
-15
lines changed

third_party/emdawnwebgpu/library_webgpu.js

Lines changed: 3 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1302,11 +1302,7 @@ var LibraryWebGPU = {
13021302
if (dynamicOffsetCount == 0) {
13031303
pass.setBindGroup(groupIndex, group);
13041304
} else {
1305-
var offsets = [];
1306-
for (var i = 0; i < dynamicOffsetCount; i++, dynamicOffsetsPtr += 4) {
1307-
offsets.push({{{ gpu.makeGetU32('dynamicOffsetsPtr', 0) }}});
1308-
}
1309-
pass.setBindGroup(groupIndex, group, offsets);
1305+
pass.setBindGroup(groupIndex, group, HEAPU32, {{{ getHeapOffset('dynamicOffsetsPtr', 'u32') }}}, dynamicOffsetCount);
13101306
}
13111307
},
13121308

@@ -2191,11 +2187,7 @@ var LibraryWebGPU = {
21912187
if (dynamicOffsetCount == 0) {
21922188
pass.setBindGroup(groupIndex, group);
21932189
} else {
2194-
var offsets = [];
2195-
for (var i = 0; i < dynamicOffsetCount; i++, dynamicOffsetsPtr += 4) {
2196-
offsets.push({{{ gpu.makeGetU32('dynamicOffsetsPtr', 0) }}});
2197-
}
2198-
pass.setBindGroup(groupIndex, group, offsets);
2190+
pass.setBindGroup(groupIndex, group, HEAPU32, {{{ getHeapOffset('dynamicOffsetsPtr', 'u32') }}}, dynamicOffsetCount);
21992191
}
22002192
},
22012193

@@ -2293,11 +2285,7 @@ var LibraryWebGPU = {
22932285
if (dynamicOffsetCount == 0) {
22942286
pass.setBindGroup(groupIndex, group);
22952287
} else {
2296-
var offsets = [];
2297-
for (var i = 0; i < dynamicOffsetCount; i++, dynamicOffsetsPtr += 4) {
2298-
offsets.push({{{ gpu.makeGetU32('dynamicOffsetsPtr', 0) }}});
2299-
}
2300-
pass.setBindGroup(groupIndex, group, offsets);
2288+
pass.setBindGroup(groupIndex, group, HEAPU32, {{{ getHeapOffset('dynamicOffsetsPtr', 'u32') }}}, dynamicOffsetCount);
23012289
}
23022290
},
23032291

0 commit comments

Comments
 (0)