[inspector] Remove unused entry point data.

Remove some reflected entry point information which is not accessed.

Change-Id: Id4b3a16efb6f2b689f2a6cac143fe799d1d6e7ac
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/236835
Commit-Queue: dan sinclair <[email protected]>
Reviewed-by: James Price <[email protected]>

Author: dj2

src/tint/lang/wgsl/inspector/entry_point.h

@@ -30,14 +30,10 @@
 
 #include <optional>
 #include <string>
-#include <tuple>
 #include <vector>
 
 #include "src/tint/api/common/override_id.h"
 
-#include "src/tint/lang/wgsl/ast/interpolate_attribute.h"
-#include "src/tint/lang/wgsl/ast/pipeline_stage.h"
-
 namespace tint::inspector {
 
 /// Base component type of a stage variable.
@@ -165,13 +161,11 @@ struct EntryPoint {
 
     /// The entry point name
     std::string name;
-    /// Remapped entry point name in the backend
-    std::string remapped_name;
     /// The entry point stage
     PipelineStage stage;
     /// The workgroup size. If PipelineStage is kCompute and this holds no value, then the workgroup
     /// size is derived from an override-expression. In this situation you first need to run the
-    /// tint::ast::transform::SubstituteOverride transform before using the inspector.
+    /// SubstituteOverride transform before using the inspector.
     std::optional<WorkgroupSize> workgroup_size;
     /// The total size in bytes of all Workgroup storage-class storage accessed via the entry point.
     uint32_t workgroup_storage_size = 0;
@@ -192,9 +186,6 @@ struct EntryPoint {
     /// Does the entry point use the sample_mask builtin as an output builtin
     /// variable.
     bool output_sample_mask_used = false;
-    /// Does the entry point use the position builtin as an input builtin
-    /// variable.
-    bool input_position_used = false;
     /// Does the entry point use the front_facing builtin
     bool front_facing_used = false;
     /// Does the entry point use the sample_index builtin

src/tint/lang/wgsl/inspector/inspector.cc

@@ -266,7 +266,6 @@ EntryPoint Inspector::GetEntryPoint(const tint::ast::Function* func) {
     auto* sem = program_.Sem().Get(func);
 
     entry_point.name = func->name->symbol.Name();
-    entry_point.remapped_name = func->name->symbol.Name();
 
     switch (func->PipelineStage()) {
         case ast::PipelineStage::kCompute: {
@@ -306,8 +305,6 @@ EntryPoint Inspector::GetEntryPoint(const tint::ast::Function* func) {
             param->Type(), param->Declaration()->attributes, param->Attributes().location,
             param->Attributes().color, /* @blend_src */ std::nullopt, entry_point.input_variables);
 
-        entry_point.input_position_used |= ContainsBuiltin(
-            core::BuiltinValue::kPosition, param->Type(), param->Declaration()->attributes);
         entry_point.front_facing_used |= ContainsBuiltin(
             core::BuiltinValue::kFrontFacing, param->Type(), param->Declaration()->attributes);
         entry_point.sample_index_used |= ContainsBuiltin(

src/tint/lang/wgsl/inspector/inspector.h

@@ -40,7 +40,6 @@
 #include "src/tint/lang/core/builtin_value.h"
 #include "src/tint/lang/wgsl/inspector/entry_point.h"
 #include "src/tint/lang/wgsl/inspector/resource_binding.h"
-#include "src/tint/lang/wgsl/inspector/scalar.h"
 #include "src/tint/lang/wgsl/program/program.h"
 #include "src/tint/lang/wgsl/sem/sampler_texture_pair.h"
 

src/tint/lang/wgsl/inspector/inspector_test.cc

@@ -124,7 +124,6 @@ TEST_F(InspectorGetEntryPointTest, OneEntryPoint) {
 
     ASSERT_EQ(1u, result.size());
     EXPECT_EQ("foo", result[0].name);
-    EXPECT_EQ("foo", result[0].remapped_name);
     EXPECT_EQ(PipelineStage::kFragment, result[0].stage);
 }
 
@@ -140,10 +139,8 @@ TEST_F(InspectorGetEntryPointTest, MultipleEntryPoints) {
 
     ASSERT_EQ(2u, result.size());
     EXPECT_EQ("foo", result[0].name);
-    EXPECT_EQ("foo", result[0].remapped_name);
     EXPECT_EQ(PipelineStage::kFragment, result[0].stage);
     EXPECT_EQ("bar", result[1].name);
-    EXPECT_EQ("bar", result[1].remapped_name);
     EXPECT_EQ(PipelineStage::kCompute, result[1].stage);
 }
 
@@ -163,10 +160,8 @@ fn foo() { func(); }
 
     ASSERT_EQ(2u, result.size());
     EXPECT_EQ("foo", result[0].name);
-    EXPECT_EQ("foo", result[0].remapped_name);
     EXPECT_EQ(PipelineStage::kCompute, result[0].stage);
     EXPECT_EQ("bar", result[1].name);
-    EXPECT_EQ("bar", result[1].remapped_name);
     EXPECT_EQ(PipelineStage::kFragment, result[1].stage);
 }
 
@@ -1137,7 +1132,6 @@ fn ep_func() {}
     ASSERT_EQ(1u, result.size());
     EXPECT_FALSE(result[0].input_sample_mask_used);
     EXPECT_FALSE(result[0].output_sample_mask_used);
-    EXPECT_FALSE(result[0].input_position_used);
     EXPECT_FALSE(result[0].front_facing_used);
     EXPECT_FALSE(result[0].sample_index_used);
     EXPECT_FALSE(result[0].num_workgroups_used);
@@ -1209,35 +1203,6 @@ fn ep_func() -> out_struct {
     EXPECT_TRUE(result[0].output_sample_mask_used);
 }
 
-TEST_F(InspectorGetEntryPointTest, InputPositionSimpleReferenced) {
-    auto* src = R"(
-@fragment
-fn ep_func(@builtin(position) in_var: vec4f) {}
-)";
-    Inspector& inspector = Initialize(src);
-
-    auto result = inspector.GetEntryPoints();
-
-    ASSERT_EQ(1u, result.size());
-    EXPECT_TRUE(result[0].input_position_used);
-}
-
-TEST_F(InspectorGetEntryPointTest, InputPositionStructReferenced) {
-    auto* src = R"(
-struct in_struct {
-  @builtin(position) inner_position: vec4f,
-}
-@fragment
-fn ep_func(in_var: in_struct) {}
-)";
-    Inspector& inspector = Initialize(src);
-
-    auto result = inspector.GetEntryPoints();
-
-    ASSERT_EQ(1u, result.size());
-    EXPECT_TRUE(result[0].input_position_used);
-}
-
 TEST_F(InspectorGetEntryPointTest, FrontFacingSimpleReferenced) {
     auto* src = R"(
 @fragment