Skip to content

Commit f491888

Browse files
wcandillonDawn LUCI CQ
authored andcommitted
Only strip debug symbols on Android
Since we now compile a static lib file, the strip command is too aggressive. It was originally intended for the .so file. This fixes the issue. This is an imported pull request from #46 # No-Try because this only affects github workflow config No-Try: true GITHUB_PR_HEAD_SHA=dabb46a09cebad35c011a0730678b8bfce3ed1fa ORIGINAL_AUTHOR=William Candillon <[email protected]> GitOrigin-RevId: 143b39b Change-Id: I44f1b0d8c0a53f0431d0917721b5f52485ffd074 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/264714 Reviewed-by: dan sinclair <[email protected]> Reviewed-by: Kai Ninomiya <[email protected]> Commit-Queue: Kai Ninomiya <[email protected]>
1 parent e213957 commit f491888

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

.github/workflows/ci.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -194,9 +194,9 @@ jobs:
194194
-DCMAKE_BUILD_TYPE=Release
195195
ninja -C ${{ matrix.output_dir }}
196196
197-
- name: Strip Android binaries
197+
- name: Strip debug symbols
198198
run: |
199-
${{ matrix.strip_tool }} ${{ matrix.output_dir }}/${{ matrix.library_path }}
199+
${{ matrix.strip_tool }} --strip-debug ${{ matrix.output_dir }}/${{ matrix.library_path }}
200200
201201
- name: Upload build artifacts
202202
uses: actions/upload-artifact@v4

0 commit comments

Comments
 (0)