Skip to content

Commit fba87da

Browse files
lokokungDawn LUCI CQ
authored andcommitted
[dawn][emscripten] Fix missing constructor initializations for events.
- Adds crucial initializers in some of the events that were missed in the initial implementation. Bug: 369445681, 372080121 Change-Id: Id5d8502d59e2441266a7866ed39f29f494e18747 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/211939 Commit-Queue: Corentin Wallez <[email protected]> Auto-Submit: Loko Kung <[email protected]> Reviewed-by: Corentin Wallez <[email protected]>
1 parent e6f35ad commit fba87da

File tree

1 file changed

+10
-2
lines changed

1 file changed

+10
-2
lines changed

third_party/emdawnwebgpu/webgpu.cpp

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -747,7 +747,11 @@ class CompilationInfoEvent final : public TrackedEvent {
747747
CompilationInfoEvent(InstanceID instance,
748748
WGPUShaderModule shader,
749749
const WGPUCompilationInfoCallbackInfo2& callbackInfo)
750-
: TrackedEvent(instance, callbackInfo.mode), mShader(shader) {}
750+
: TrackedEvent(instance, callbackInfo.mode),
751+
mCallback(callbackInfo.callback),
752+
mUserdata1(callbackInfo.userdata1),
753+
mUserdata2(callbackInfo.userdata2),
754+
mShader(shader) {}
751755

752756
EventType GetType() override { return kType; }
753757

@@ -946,7 +950,11 @@ class MapAsyncEvent final : public TrackedEvent {
946950
MapAsyncEvent(InstanceID instance,
947951
WGPUBuffer buffer,
948952
const WGPUBufferMapCallbackInfo2& callbackInfo)
949-
: TrackedEvent(instance, callbackInfo.mode), mBuffer(buffer) {}
953+
: TrackedEvent(instance, callbackInfo.mode),
954+
mCallback(callbackInfo.callback),
955+
mUserdata1(callbackInfo.userdata1),
956+
mUserdata2(callbackInfo.userdata2),
957+
mBuffer(buffer) {}
950958

951959
EventType GetType() override { return kType; }
952960

0 commit comments

Comments
 (0)