fix: some lint in the rust code (#250)

Author: yesudeep

.github/workflows/python.yml

@@ -76,6 +76,10 @@ jobs:
       - name: Static type check
         run: uv run --active --directory python mypy .
 
+      # TODO: Move this to a rust workflow once we have one.
+      - name: Run rust lint
+        run: pushd python/handlebarrz && cargo clippy --all-targets --all-features -- -D warnings && popd
+
       - name: Check licenses
         run: ./scripts/check_license
 

python/handlebarrz/Cargo.lock

@@ -15,7 +15,7 @@ name       = "handlebarrz"
 
 [dependencies]
 handlebars = "6.3.2"
-pyo3 = { version = "0.24.0", features = [
+pyo3 = { version = "0.24.2", features = [
   "extension-module",
   "generate-import-lib",
 ] }

python/handlebarrz/Cargo.toml

@@ -108,7 +108,7 @@ impl HelperDef for PyHelperDef {
                 Ok(json) => json,
                 Err(e) => {
                     let desc = format!("Failed to serialize params: {}", e);
-                    return Err(RenderError::from(RenderErrorReason::Other(desc.into())));
+                    return Err(RenderError::from(RenderErrorReason::Other(desc)));
                 }
             };
 
@@ -122,7 +122,7 @@ impl HelperDef for PyHelperDef {
                 Ok(json) => json,
                 Err(e) => {
                     let desc = format!("Failed to serialize hash: {}", e);
-                    return Err(RenderError::from(RenderErrorReason::Other(desc.into())));
+                    return Err(RenderError::from(RenderErrorReason::Other(desc)));
                 }
             };
 
@@ -131,7 +131,7 @@ impl HelperDef for PyHelperDef {
                 Ok(json) => json,
                 Err(e) => {
                     let desc = format!("Failed to serialize context: {}", e);
-                    return Err(RenderError::from(RenderErrorReason::Other(desc.into())));
+                    return Err(RenderError::from(RenderErrorReason::Other(desc)));
                 }
             };
 
@@ -144,15 +144,15 @@ impl HelperDef for PyHelperDef {
                         Ok(s) => s,
                         Err(e) => {
                             let desc = format!("Failed to extract result: {}", e);
-                            return Err(RenderError::from(RenderErrorReason::Other(desc.into())));
+                            return Err(RenderError::from(RenderErrorReason::Other(desc)));
                         }
                     };
                     out.write(&result_str)?;
                     Ok(())
                 }
                 Err(e) => {
                     let desc = format!("Helper execution failed: {}", e);
-                    Err(RenderError::from(RenderErrorReason::Other(desc.into())))
+                    Err(RenderError::from(RenderErrorReason::Other(desc)))
                 }
             }
         })
@@ -613,8 +613,9 @@ impl HelperDef for UnlessEqualsHelper {
 ///
 /// ## Hash Arguments
 ///
-/// * `indent`: Optional. If provided, the JSON output will be pretty-printed with the specified indent level (integer).
-///             If not provided, the JSON output will be compact (no whitespace).
+/// * `indent`: Optional. If provided, the JSON output will be pretty-printed
+///   with the specified indent level (integer).  If not provided, the JSON
+///   output will be compact (no whitespace).
 ///
 /// This helper is useful for embedding JSON data directly into templates,
 /// for example, to pass configuration or data to client-side JavaScript code.

python/handlebarrz/src/lib.rs

@@ -22,6 +22,7 @@ TOP_DIR=$(git rev-parse --show-toplevel)
 GO_DIR="${TOP_DIR}/go"
 PY_DIR="${TOP_DIR}/python"
 JS_DIR="${TOP_DIR}/js"
+HANDLEBARRZ_DIR="${TOP_DIR}/python/handlebarrz"
 
 pushd "${GO_DIR}" &>/dev/null
 golangci-lint run ./...
@@ -33,3 +34,8 @@ popd &>/dev/null
 
 uv run --directory "${PY_DIR}" ruff check --select I --fix --preview --unsafe-fixes .
 uv run --directory "${PY_DIR}" mypy .
+
+pushd "${HANDLEBARRZ_DIR}" &>/dev/null
+cargo fmt --all
+cargo clippy --all-targets --all-features -- -D warnings
+popd &>/dev/null