[rewrite] Add Java8toJava11

Signed-off-by: Vincent Potucek <[email protected]>

Author: Vincent Potucek

.github/workflows/ci.yml

@@ -90,6 +90,9 @@ jobs:
       - name: 'Test'
         shell: bash
         run: mvn test -B
+      - name: 'SanityCheck'
+        shell: bash
+        run: mvn rewrite:dryRun
       - name: 'Javadoc'
         shell: bash
         run: mvn -P '!examples' javadoc:javadoc

.gitignore

@@ -8,8 +8,9 @@
 
 # intellij
 .idea/ant.xml
-.idea/codestream.xml
+.idea/checkstyle-idea.xml
 .idea/codeStyleSettings.xml
+.idea/codestream.xml
 .idea/compiler.xml
 .idea/copyright
 .idea/dataSources.ids
@@ -21,6 +22,7 @@
 .idea/libraries
 .idea/misc.xml
 .idea/modules.xml
+.idea/palantir-java-format.xml
 .idea/shelf
 .idea/tasks.xml
 .idea/uiDesigner.xml

check_api/pom.xml

@@ -49,6 +49,12 @@
       <artifactId>jspecify</artifactId>
       <version>${jspecify.version}</version>
     </dependency>
+    <dependency>
+      <groupId>jakarta.annotation</groupId>
+      <artifactId>jakarta.annotation-api</artifactId>
+      <version>1.3.5</version>
+      <scope>provided</scope>
+    </dependency>
     <dependency>
       <!-- GPLv2 with Classpath Exception -->
       <groupId>io.github.eisop</groupId>
@@ -103,6 +109,12 @@
       <version>${truth.version}</version>
       <scope>test</scope>
     </dependency>
+    <dependency>
+      <groupId>jakarta.inject</groupId>
+      <artifactId>jakarta.inject-api</artifactId>
+      <version>1.0.3</version>
+      <scope>test</scope>
+    </dependency>
     <dependency>
       <!-- MIT -->
       <groupId>org.mockito</groupId>

check_api/src/main/java/com/google/errorprone/apply/DescriptionBasedDiff.java

@@ -26,7 +26,7 @@
 import com.sun.tools.javac.tree.EndPosTable;
 import com.sun.tools.javac.tree.JCTree.JCCompilationUnit;
 import java.net.URI;
-import java.nio.file.Paths;
+import java.nio.file.Path;
 import java.util.LinkedHashSet;
 import java.util.Objects;
 import java.util.Set;
@@ -68,7 +68,7 @@ private DescriptionBasedDiff(
     URI sourceFileUri = compilationUnit.getSourceFile().toUri();
     this.sourcePath =
         (sourceFileUri.isAbsolute() && Objects.equals(sourceFileUri.getScheme(), "file"))
-            ? Paths.get(sourceFileUri).toAbsolutePath().toString()
+            ? Path.of(sourceFileUri).toAbsolutePath().toString()
             : sourceFileUri.getPath();
     this.ignoreOverlappingFixes = ignoreOverlappingFixes;
     this.importsToAdd = new LinkedHashSet<>();

check_api/src/main/java/com/google/errorprone/dataflow/nullnesspropagation/inference/InferredNullability.java

@@ -87,20 +87,18 @@ private Optional<Nullness> getNullness(InferenceVariable iv) {
       result =
           constraintGraph.predecessors(iv).stream()
               .map(this::getNullness)
-              .filter(Optional::isPresent)
-              .map(Optional::get)
+              .flatMap(Optional::stream)
               .reduce(Nullness::leastUpperBound); // use least upper bound (lub) to combine
       // 2. If not, resolve successors and use them as upper bounds
-      if (!result.isPresent()) {
+      if (result.isEmpty()) {
         result =
             constraintGraph.successors(iv).stream()
                 .map(this::getNullness)
-                .filter(Optional::isPresent)
-                .map(Optional::get)
+                .flatMap(Optional::stream)
                 .reduce(Nullness::greatestLowerBound); // use greatest lower bound (glb) to combine
       }
 
-      checkState(!inferredMemoTable.put(iv, result).isPresent());
+      checkState(inferredMemoTable.put(iv, result).isEmpty());
       return result;
     }
   }

check_api/src/main/java/com/google/errorprone/dataflow/nullnesspropagation/inference/NullnessQualifierInference.java

@@ -153,14 +153,14 @@ private void generateConstraintsFromAnnotations(
 
     Optional<Nullness> fromAnnotations =
         extractExplicitNullness(declaredType, argSelector.isEmpty() ? decl : null);
-    if (!fromAnnotations.isPresent()) {
+    if (fromAnnotations.isEmpty()) {
       // Check declared type before inferred type so that type annotations on the declaration take
       // precedence (just like declaration annotations) over annotations on the inferred type.
       // For instance, we want a @Nullable T m() to take precedence over annotations on T's inferred
       // type (e.g., @NotNull String), whether @Nullable is a declaration or type annotation.
       fromAnnotations = NullnessAnnotations.fromAnnotationsOn(inferredType);
     }
-    if (!fromAnnotations.isPresent()) {
+    if (fromAnnotations.isEmpty()) {
       if (declaredType instanceof TypeVariable typeVariable) {
         // Check bounds second so explicit annotations take precedence. Even for bounds we still use
         // equality constraint below since we have to assume the bound as the "worst" case.
@@ -482,7 +482,7 @@ private void generateConstraintsForWrite(
     boolean isBound = false;
     Optional<Nullness> fromAnnotations =
         extractExplicitNullness(lType, argSelector.isEmpty() ? decl : null);
-    if (!fromAnnotations.isPresent()) {
+    if (fromAnnotations.isEmpty()) {
       if (lType instanceof TypeVariable typeVariable) {
         fromAnnotations = NullnessAnnotations.getUpperBound(typeVariable);
         isBound = true;

check_api/src/main/java/com/google/errorprone/fixes/SuggestedFixes.java

@@ -1132,7 +1132,7 @@ public static SuggestedFix.Builder addValuesToAnnotationArgument(
                   .replaceFirst("\\(\\)", "(" + parameterPrefix + newArgument(newValues) + ")"));
     }
     Optional<ExpressionTree> maybeExistingArgument = findArgument(annotation, parameterName);
-    if (!maybeExistingArgument.isPresent()) {
+    if (maybeExistingArgument.isEmpty()) {
       return SuggestedFix.builder()
           .prefixWith(
               annotation.getArguments().getFirst(),
@@ -1192,7 +1192,7 @@ public static SuggestedFix.Builder updateAnnotationArgumentValues(
                   + ')');
     }
     Optional<ExpressionTree> maybeExistingArgument = findArgument(annotation, parameterName);
-    if (!maybeExistingArgument.isPresent()) {
+    if (maybeExistingArgument.isEmpty()) {
       return SuggestedFix.builder()
           .prefixWith(
               annotation.getArguments().getFirst(),

check_api/src/main/java/com/google/errorprone/matchers/method/MethodInvocationMatcher.java

@@ -483,7 +483,7 @@ public static Matcher<ExpressionTree> compile(Iterable<Rule> rules) {
       // First collect all the nodes that accept any token at all
       for (Node node : curr) {
         for (Map.Entry<Optional<Token>, Node> entry : nfa.row(node).entrySet()) {
-          if (!entry.getKey().isPresent()) {
+          if (entry.getKey().isEmpty()) {
             acceptsAny.add(entry.getValue());
           }
         }

check_api/src/main/java/com/google/errorprone/util/Comments.java

@@ -111,7 +111,7 @@ private static ImmutableList<Commented<ExpressionTree>> findCommentsForArguments
 
     CharSequence sourceCode = state.getSourceCode();
     Optional<Integer> endPosition = computeEndPosition(tree, sourceCode, state);
-    if (!endPosition.isPresent()) {
+    if (endPosition.isEmpty()) {
       return noComments(arguments);
     }
 

check_api/src/test/java/com/google/errorprone/util/CommentsTest.java

@@ -54,7 +54,7 @@ public static class ComputeEndPosition extends BugChecker implements MethodInvoc
     public Description matchMethodInvocation(MethodInvocationTree tree, VisitorState state) {
       CharSequence sourceCode = state.getSourceCode();
       Optional<Integer> endPosition = Comments.computeEndPosition(tree, sourceCode, state);
-      if (!endPosition.isPresent()) {
+      if (endPosition.isEmpty()) {
         return Description.NO_MATCH;
       }
       int startPosition = endPosition.get();