Avoid one way in which ExplicitArrayForVarargs could cause recursion.

Fixes external #5335.

PiperOrigin-RevId: 830889725

Author: graememorgan

core/src/main/java/com/google/errorprone/bugpatterns/ExplicitArrayForVarargs.java

@@ -17,6 +17,7 @@
 package com.google.errorprone.bugpatterns;
 
 import static com.google.common.collect.Iterables.getOnlyElement;
+import static com.google.common.collect.Streams.stream;
 import static com.google.errorprone.BugPattern.SeverityLevel.WARNING;
 import static com.google.errorprone.matchers.Description.NO_MATCH;
 import static com.google.errorprone.util.ASTHelpers.constValue;
@@ -64,6 +65,16 @@ private Description handle(
     if (args.isEmpty()) {
       return NO_MATCH;
     }
+    // Bail out if we're calling an overload of the same method: it's likely we'll introduce
+    // problems (delegating constructors are a common case).
+    if (stream(state.getPath().getParentPath())
+        .anyMatch(
+            t ->
+                getSymbol(t) instanceof MethodSymbol ms
+                    && ms.owner.equals(symbol.owner)
+                    && ms.name.contentEquals(symbol.name))) {
+      return NO_MATCH;
+    }
     // The last argument isn't substituting for varargs if it isn't in place of the varargs
     // parameter.
     if (args.size() != symbol.getParameters().size()) {

core/src/test/java/com/google/errorprone/bugpatterns/ExplicitArrayForVarargsTest.java

@@ -103,4 +103,21 @@ List<Object> nonempty() {
             """)
         .doTest();
   }
+
+  @Test
+  public void refactoringWouldCauseRecursion() {
+    helper
+        .addSourceLines(
+            "Test.java",
+            """
+            class Test {
+              Test() {
+                this(new String[0]);
+              }
+
+              protected Test(String... xs) {}
+            }
+            """)
+        .doTest();
+  }
 }