Skip to content

Commit 81961f6

Browse files
authored
github: [renderdiff] ensure right clang (#9816)
For renderdiff, we compile mesa using brew's llvm/clang, but we compile filament with the system clang (AppleClang). This is to prevent compiling filament with brew's clang (which can cause unexpected compilation error).
1 parent 9fbf438 commit 81961f6

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

.github/actions/renderdiff-generate/action.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,15 @@ runs:
88
- uses: ./.github/actions/get-mesa
99
- uses: ./.github/actions/get-vulkan-sdk
1010
- name: Prerequisites
11+
if: runner.os == 'macOS'
1112
run: |
1213
# Must have at least clang-16 for a webgpu/dawn build.
1314
sudo xcode-select -s /Applications/Xcode_16.2.app/Contents/Developer
15+
# this enforces the gltf_viewer build to use apple clang as oppose the brew clang used for get-mesa
16+
echo "CC=/usr/bin/clang" >> $GITHUB_ENV
17+
echo "CXX=/usr/bin/clang++" >> $GITHUB_ENV
18+
echo "/usr/local/bin" >> $GITHUB_PATH
19+
echo "/usr/bin" >> $GITHUB_PATH
1420
shell: bash
1521
- name: Generate images
1622
run: |

0 commit comments

Comments
 (0)