Skip to content

Commit 52a6206

Browse files
committed
fixes contributing typos
1 parent c05640e commit 52a6206

File tree

1 file changed

+12
-11
lines changed

1 file changed

+12
-11
lines changed

CONTRIBUTING.md

Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@ if you are contributing the first header files for a given plugin.
134134
> permissions on the MediaPipe bucket in Google Cloud Storage. Non-Googlers should
135135
> not encounter a need to run the command, but if you believe you have, file an issue.
136136
137-
Flutter collects MediaPipe artifacts and at build time and compiles them into your
137+
Flutter collects MediaPipe artifacts at build time and compiles them into your
138138
binary using the experimental new feature, named "Native Assets".
139139

140140
> Note: As described above, this feature is only available on the `master` channel
@@ -185,10 +185,10 @@ to the `<pkg_name>/lib/src/io/tasks/` directory and appropriate exports to the
185185
from Dart code, and so should know how to allocate itself into native memory and
186186
then later deallocate that memory. Most other classes originate within native
187187
memory itself and are returned to Dart by calling the task's methods. These classes
188-
should have `.native()` factory constructors which accept a pointer and hydrate
189-
private fields. They should also have direct constructors which accept pure Dart
190-
values and are only suitable for testing. Reference other task's implementations
191-
for inspiration on how to handle this memory management.
188+
should have `.native()` factory constructors which accept a pointer. They should
189+
also have direct constructors which accept pure Dart values, set private fields,
190+
and are only suitable for testing. Reference other tasks' implementations for
191+
inspiration on how to handle this memory management.
192192

193193
##### Adding the web implementation
194194

@@ -198,20 +198,21 @@ of this writing, no web implementations yet exist.
198198
##### Adding the sample
199199

200200
New task implementations should include a new screen in the example app. Add a
201-
new element to the `PageView`'s children, then add your sample within that widget.
202-
For reference on how to initialize the MediaPipe SDK for your task, consult existing
203-
examples. It is recommended that you use this example as the primary way of proving
204-
to yourself that your new task implementation works as intended.
201+
new element to the `PageView` widget's children, then add your sample within that
202+
new widget. For reference on how to initialize the MediaPipe SDK for your task,
203+
consult existing examples. It is recommended that you use this example as the
204+
primary way of proving to yourself that your new task implementation works as intended
205+
(along with tests, of course).
205206

206207
#### Improving an existing task
207208

208209
If you are improving an existing task, either by adding overlooked functionality
209-
or fixing a bug, your task should be much simpler than that of adding an entirely
210+
or fixing a bug, your job should be much simpler than that of adding an entirely
210211
new task. If you get stuck, open a PR with everything you have accomplished and
211212
request assistance from Craig Labenz.
212213

213214
#### Adding tests
214215

215216
All new PRs should include tests that demonstrate correctness. Integration tests
216-
are demonstrated by the `mediapipe_text` plugin, but as of this writing, are not
217+
exist in the `mediapipe_text` plugin, but as of this writing, are not yet
217218
implemented in the `mediapipe_genai` plugin.

0 commit comments

Comments
 (0)