-
Notifications
You must be signed in to change notification settings - Fork 629
Open
Description
While building crane on copr, it test fails with:
./descriptor_test.go:178:31: (*testing.common).Errorf format %q has arg desc.Size of wrong type int64
FAIL github.com/google/go-containerregistry/pkg/v1/remote [build failed]
logs can be found here.
spec file: https://github.com/secureblue/crane
This is because of a change in Go 1.26: golang/go#72850
https://cs.opensource.google/go/x/tools/+/5be823e8041a7591b59c4f200bf05de958704df7
Simply having this seems to fix
diff --git a/pkg/v1/remote/descriptor_test.go b/pkg/v1/remote/descriptor_test.go
index c0e6fa25..3d554e63 100644
--- a/pkg/v1/remote/descriptor_test.go
+++ b/pkg/v1/remote/descriptor_test.go
@@ -175,7 +175,7 @@ func TestHeadSchema1(t *testing.T) {
}
if desc.Size != int64(len(response)) {
- t.Errorf("Descriptor.Size = %q, expected %q", desc.Size, len(response))
+ t.Errorf("Descriptor.Size = %d, expected %d", desc.Size, len(response))
}
}Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels