Skip to content

Commit 0c6bd91

Browse files
authored
fix: Remove custom Accept in Apps.ListRepos and Apps.ListUserRepos (#3609)
1 parent 2e26546 commit 0c6bd91

File tree

2 files changed

+0
-30
lines changed

2 files changed

+0
-30
lines changed

github/apps_installation.go

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ package github
88
import (
99
"context"
1010
"fmt"
11-
"strings"
1211
)
1312

1413
// ListRepositories represents the response from the list repos endpoints.
@@ -33,14 +32,6 @@ func (s *AppsService) ListRepos(ctx context.Context, opts *ListOptions) (*ListRe
3332
return nil, nil, err
3433
}
3534

36-
// TODO: remove custom Accept headers when APIs fully launch.
37-
acceptHeaders := []string{
38-
mediaTypeTopicsPreview,
39-
mediaTypeRepositoryVisibilityPreview,
40-
mediaTypeRepositoryTemplatePreview,
41-
}
42-
req.Header.Set("Accept", strings.Join(acceptHeaders, ", "))
43-
4435
var r *ListRepositories
4536

4637
resp, err := s.client.Do(ctx, req, &r)
@@ -69,14 +60,6 @@ func (s *AppsService) ListUserRepos(ctx context.Context, id int64, opts *ListOpt
6960
return nil, nil, err
7061
}
7162

72-
// TODO: remove custom Accept headers when APIs fully launch.
73-
acceptHeaders := []string{
74-
mediaTypeTopicsPreview,
75-
mediaTypeRepositoryVisibilityPreview,
76-
mediaTypeRepositoryTemplatePreview,
77-
}
78-
req.Header.Set("Accept", strings.Join(acceptHeaders, ", "))
79-
8063
var r *ListRepositories
8164
resp, err := s.client.Do(ctx, req, &r)
8265
if err != nil {

github/apps_installation_test.go

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ import (
99
"context"
1010
"fmt"
1111
"net/http"
12-
"strings"
1312
"testing"
1413

1514
"github.com/google/go-cmp/cmp"
@@ -19,14 +18,8 @@ func TestAppsService_ListRepos(t *testing.T) {
1918
t.Parallel()
2019
client, mux, _ := setup(t)
2120

22-
wantAcceptHeaders := []string{
23-
mediaTypeTopicsPreview,
24-
mediaTypeRepositoryVisibilityPreview,
25-
mediaTypeRepositoryTemplatePreview,
26-
}
2721
mux.HandleFunc("/installation/repositories", func(w http.ResponseWriter, r *http.Request) {
2822
testMethod(t, r, "GET")
29-
testHeader(t, r, "Accept", strings.Join(wantAcceptHeaders, ", "))
3023
testFormValues(t, r, values{
3124
"page": "1",
3225
"per_page": "2",
@@ -60,14 +53,8 @@ func TestAppsService_ListUserRepos(t *testing.T) {
6053
t.Parallel()
6154
client, mux, _ := setup(t)
6255

63-
wantAcceptHeaders := []string{
64-
mediaTypeTopicsPreview,
65-
mediaTypeRepositoryVisibilityPreview,
66-
mediaTypeRepositoryTemplatePreview,
67-
}
6856
mux.HandleFunc("/user/installations/1/repositories", func(w http.ResponseWriter, r *http.Request) {
6957
testMethod(t, r, "GET")
70-
testHeader(t, r, "Accept", strings.Join(wantAcceptHeaders, ", "))
7158
testFormValues(t, r, values{
7259
"page": "1",
7360
"per_page": "2",

0 commit comments

Comments
 (0)