fixup! feat: Improve support for custom property defaults

Author: stevehipwell

github/enterprise_properties_test.go

@@ -55,7 +55,7 @@ func TestEnterpriseService_GetAllCustomProperties(t *testing.T) {
 			PropertyName:     Ptr("name"),
 			ValueType:        PropertyValueTypeSingleSelect,
 			Required:         Ptr(true),
-			DefaultValue:     Ptr("production"),
+			DefaultValue:     "production",
 			Description:      Ptr("Prod or dev environment"),
 			AllowedValues:    []string{"production", "development"},
 			ValuesEditableBy: Ptr("org_actors"),
@@ -178,7 +178,7 @@ func TestEnterpriseService_GetCustomProperty(t *testing.T) {
 		PropertyName:     Ptr("name"),
 		ValueType:        PropertyValueTypeSingleSelect,
 		Required:         Ptr(true),
-		DefaultValue:     Ptr("production"),
+		DefaultValue:     "production",
 		Description:      Ptr("Prod or dev environment"),
 		AllowedValues:    []string{"production", "development"},
 		ValuesEditableBy: Ptr("org_actors"),
@@ -222,7 +222,7 @@ func TestEnterpriseService_CreateOrUpdateCustomProperty(t *testing.T) {
 	property, _, err := client.Enterprise.CreateOrUpdateCustomProperty(ctx, "e", "name", &CustomProperty{
 		ValueType:        PropertyValueTypeSingleSelect,
 		Required:         Ptr(true),
-		DefaultValue:     Ptr("production"),
+		DefaultValue:     "production",
 		Description:      Ptr("Prod or dev environment"),
 		AllowedValues:    []string{"production", "development"},
 		ValuesEditableBy: Ptr("org_actors"),
@@ -235,7 +235,7 @@ func TestEnterpriseService_CreateOrUpdateCustomProperty(t *testing.T) {
 		PropertyName:     Ptr("name"),
 		ValueType:        PropertyValueTypeSingleSelect,
 		Required:         Ptr(true),
-		DefaultValue:     Ptr("production"),
+		DefaultValue:     "production",
 		Description:      Ptr("Prod or dev environment"),
 		AllowedValues:    []string{"production", "development"},
 		ValuesEditableBy: Ptr("org_actors"),

github/event_types_test.go

@@ -13732,7 +13732,7 @@ func TestCustomPropertyEvent_Marshal(t *testing.T) {
 			ValueType:        PropertyValueTypeSingleSelect,
 			SourceType:       Ptr("enterprise"),
 			Required:         Ptr(true),
-			DefaultValue:     Ptr("production"),
+			DefaultValue:     "production",
 			Description:      Ptr("Prod or dev environment"),
 			AllowedValues:    []string{"production", "development"},
 			ValuesEditableBy: Ptr("org_actors"),

github/orgs_properties_test.go

@@ -62,7 +62,7 @@ func TestOrganizationsService_GetAllCustomProperties(t *testing.T) {
 			PropertyName:     Ptr("name"),
 			ValueType:        PropertyValueTypeSingleSelect,
 			Required:         Ptr(true),
-			DefaultValue:     Ptr("production"),
+			DefaultValue:     "production",
 			Description:      Ptr("Prod or dev environment"),
 			AllowedValues:    []string{"production", "development"},
 			ValuesEditableBy: Ptr("org_actors"),
@@ -81,7 +81,7 @@ func TestOrganizationsService_GetAllCustomProperties(t *testing.T) {
 			ValueType:    PropertyValueTypeURL,
 			Required:     Ptr(true),
 			Description:  Ptr("Link to the documentation"),
-			DefaultValue: Ptr("https://example.com/docs"),
+			DefaultValue: "https://example.com/docs",
 		},
 	}
 	if !cmp.Equal(properties, want) {
@@ -192,7 +192,7 @@ func TestOrganizationsService_GetCustomProperty(t *testing.T) {
 		PropertyName:     Ptr("name"),
 		ValueType:        PropertyValueTypeSingleSelect,
 		Required:         Ptr(true),
-		DefaultValue:     Ptr("production"),
+		DefaultValue:     "production",
 		Description:      Ptr("Prod or dev environment"),
 		AllowedValues:    []string{"production", "development"},
 		ValuesEditableBy: Ptr("org_actors"),
@@ -236,7 +236,7 @@ func TestOrganizationsService_CreateOrUpdateCustomProperty(t *testing.T) {
 	property, _, err := client.Organizations.CreateOrUpdateCustomProperty(ctx, "o", "name", &CustomProperty{
 		ValueType:        PropertyValueTypeSingleSelect,
 		Required:         Ptr(true),
-		DefaultValue:     Ptr("production"),
+		DefaultValue:     "production",
 		Description:      Ptr("Prod or dev environment"),
 		AllowedValues:    []string{"production", "development"},
 		ValuesEditableBy: Ptr("org_actors"),
@@ -249,7 +249,7 @@ func TestOrganizationsService_CreateOrUpdateCustomProperty(t *testing.T) {
 		PropertyName:     Ptr("name"),
 		ValueType:        PropertyValueTypeSingleSelect,
 		Required:         Ptr(true),
-		DefaultValue:     Ptr("production"),
+		DefaultValue:     "production",
 		Description:      Ptr("Prod or dev environment"),
 		AllowedValues:    []string{"production", "development"},
 		ValuesEditableBy: Ptr("org_actors"),