File tree Expand file tree Collapse file tree 7 files changed +20
-13
lines changed
newreposecretwithlibsodium Expand file tree Collapse file tree 7 files changed +20
-13
lines changed Original file line number Diff line number Diff line change @@ -15,6 +15,19 @@ the library is tested against Go version 1.22 and greater. go-github tracks
1515older versions of Go if we don't have to, but due to tooling constraints, we
1616don't always test older versions.
1717
18+ Go version 1.22 introduced significant changes to the pattern syntax and matching
19+ behavior of ` http.ServerMux ` which causes a large number of legacy unit tests to break.
20+ (See https://pkg.go.dev/net/http#hdr-Compatibility-ServeMux for more information.)
21+ As a result, testing of this repo is currently performed by setting this env variable:
22+
23+ ``` bash
24+ export GODEBUG=httpmuxgo121=1
25+ ```
26+
27+ An issue has been created (#3409 ) requesting assistance in updating all breaking legacy unit
28+ tests when this ` GODEBUG ` environment variable is not set and Go 1.23.4 or later is
29+ used to perform unit tests.
30+
1831[ support-policy ] : https://golang.org/doc/devel/release.html#policy
1932
2033If you're interested in using the [ GraphQL API v4] [ ] , the recommended library is
Original file line number Diff line number Diff line change 11module github.com/google/go-github/v68/example
22
3- go 1.22.5
4-
5- toolchain go1.23.2
3+ go 1.22.10
64
75require (
86 github.com/ProtonMail/go-crypto v0.0.0-20230828082145-3c4c8a2d2371
Original file line number Diff line number Diff line change 11module newreposecretwithlibsodium
22
3- go 1.21
4-
5- toolchain go1.22.0
3+ go 1.22.10
64
75require (
86 github.com/GoKillers/libsodium-go v0.0.0-20171022220152-dd733721c3cb
Original file line number Diff line number Diff line change @@ -5,4 +5,4 @@ require (
55 github.com/google/go-querystring v1.1.0
66)
77
8- go 1.21
8+ go 1.22.10
Original file line number Diff line number Diff line change 11module github.com/google/go-github/scrape
22
3- go 1.23
4-
5- toolchain go1.23.4
3+ go 1.23.4
64
75require (
86 github.com/PuerkitoBio/goquery v1.10.1
Original file line number Diff line number Diff line change 77set -e
88
99CDPATH=" " cd -- " $( dirname -- " $0 " ) /.."
10+ # TODO(gmlewis): Remove this when #3409 is resolved.
11+ export GODEBUG=httpmuxgo121=1
1012
1113if [ " $# " = " 0" ]; then
1214 set -- -race -covermode atomic ./...
Original file line number Diff line number Diff line change 11module tools
22
3- go 1.21
4-
5- toolchain go1.22.0
3+ go 1.23.4
64
75require (
86 github.com/alecthomas/kong v1.6.0
You can’t perform that action at this time.
0 commit comments