Add support for organization Immutable Releases API #3774
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3774 +/- ##
==========================================
+ Coverage 91.41% 91.45% +0.04%
==========================================
Files 187 188 +1
Lines 16822 16904 +82
==========================================
+ Hits 15377 15459 +82
Misses 1257 1257
Partials 188 188 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Thank you, @Not-Dhananjay-Mishra!
Just a few issues to address, please, then we should be ready for a second LGTM+Approval from any other contributor to this repo.
github/orgs_immutable_releases.go
Outdated
| // This endpoint returns the immutable releases configuration that applies to repositories | ||
| // within the given organization. |
There was a problem hiding this comment.
In fact, all of these method descriptions should be collapsed into a single paragraph instead of having two for each.
There was a problem hiding this comment.
It seems not to be resolved yet. If you don't put the descriptions together, it will be displayed as two paragraphs in our package document.
There was a problem hiding this comment.
So I apologize because I didn't word my feedback very well. In most cases, I thought the provided information was redundant in your PR. Feel free to use as many sentences and/or paragraphs as you want to, but please just don't repeat yourself, as that is completely unnecessary since it all goes to the same location.
|
@gmlewis and @zyfy29 Thanks for the suggestions, I’ve made some changes: |
3 participants
Fixes: #3771.
This PR adds support for Organization Immutable Releases API
Implement
/orgs/{org}/settings/immutable-releases/orgs/{org}/settings/immutable-releases/orgs/{org}/settings/immutable-releases/repositories/orgs/{org}/settings/immutable-releases/repositories/orgs/{org}/settings/immutable-releases/repositories/{repository_id}/orgs/{org}/settings/immutable-releases/repositories/{repository_id}issue - #3771