Skip to content

Commit f1416e7

Browse files
thomasvlthomasvl
authored
Remove GTMTestTimer. (#432)
A google search seems to say it wasn't used by anyone, and it calls `mach_absolute_time()` this avoids having to include add an entry in an xcprivacy manifest for a testing only api.
1 parent eba1cd2 commit f1416e7

File tree

6 files changed

+3
-227
lines changed

6 files changed

+3
-227
lines changed

‎GTM.xcodeproj/project.pbxproj‎

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,6 @@
2424
8B29078711F8D1BF0064F50F /* GTMNSFileHandle+UniqueName.m in Sources */ = {isa = PBXBuildFile; fileRef = 8B29078511F8D1BF0064F50F /* GTMNSFileHandle+UniqueName.m */; };
2525
8B29080911F8E1630064F50F /* GTMNSFileHandle+UniqueName.m in Sources */ = {isa = PBXBuildFile; fileRef = 8B29078511F8D1BF0064F50F /* GTMNSFileHandle+UniqueName.m */; };
2626
8B29080A11F8E1670064F50F /* GTMNSFileHandle+UniqueName.h in Headers */ = {isa = PBXBuildFile; fileRef = 8B29078411F8D1BF0064F50F /* GTMNSFileHandle+UniqueName.h */; settings = {ATTRIBUTES = (Public, ); }; };
27-
8B3590160E8190FA0041E21C /* GTMTestTimer.h in Headers */ = {isa = PBXBuildFile; fileRef = 8B3590150E8190FA0041E21C /* GTMTestTimer.h */; settings = {ATTRIBUTES = (Public, ); }; };
28-
8B35901B0E8191750041E21C /* GTMTestTimerTest.m in Sources */ = {isa = PBXBuildFile; fileRef = 8B35901A0E8191750041E21C /* GTMTestTimerTest.m */; };
2927
8B3E2A3F0EEB564D000681D8 /* Carbon.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = F42E09AD0D19A62F00D5DDE0 /* Carbon.framework */; };
3028
8B40994B0F93C5CC00DF540E /* GTMUILocalizer.h in Headers */ = {isa = PBXBuildFile; fileRef = 8B4099490F93C5CC00DF540E /* GTMUILocalizer.h */; settings = {ATTRIBUTES = (Public, ); }; };
3129
8B40994C0F93C5CC00DF540E /* GTMUILocalizer.m in Sources */ = {isa = PBXBuildFile; fileRef = 8B40994A0F93C5CC00DF540E /* GTMUILocalizer.m */; };
@@ -194,8 +192,6 @@
194192
8B29078411F8D1BF0064F50F /* GTMNSFileHandle+UniqueName.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = "GTMNSFileHandle+UniqueName.h"; sourceTree = "<group>"; };
195193
8B29078511F8D1BF0064F50F /* GTMNSFileHandle+UniqueName.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = "GTMNSFileHandle+UniqueName.m"; sourceTree = "<group>"; };
196194
8B29078611F8D1BF0064F50F /* GTMNSFileHandle+UniqueNameTest.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = "GTMNSFileHandle+UniqueNameTest.m"; sourceTree = "<group>"; };
197-
8B3590150E8190FA0041E21C /* GTMTestTimer.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = GTMTestTimer.h; sourceTree = "<group>"; };
198-
8B35901A0E8191750041E21C /* GTMTestTimerTest.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = GTMTestTimerTest.m; sourceTree = "<group>"; };
199195
8B4099490F93C5CC00DF540E /* GTMUILocalizer.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = GTMUILocalizer.h; sourceTree = "<group>"; };
200196
8B40994A0F93C5CC00DF540E /* GTMUILocalizer.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = GTMUILocalizer.m; sourceTree = "<group>"; };
201197
8B409BC50F94405A00DF540E /* GTMUILocalizerTest.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = GTMUILocalizerTest.m; sourceTree = "<group>"; };
@@ -601,8 +597,6 @@
601597
F48FE29F0D198D36009257D2 /* GTMSenTestCase.h */,
602598
8B7DCE180DFF39850017E983 /* GTMSenTestCase.m */,
603599
F47466651296F19E0022C1FB /* GTMSenTestCaseTest.m */,
604-
8B3590150E8190FA0041E21C /* GTMTestTimer.h */,
605-
8B35901A0E8191750041E21C /* GTMTestTimerTest.m */,
606600
8BA983C21D9AE7E6009724B5 /* TestData */,
607601
8B45A2A20DA49C47001148C5 /* GTMUIUnitTestingHarness */,
608602
);
@@ -667,7 +661,6 @@
667661
F92B9FA80E2E64B900A2FE61 /* GTMLogger.h in Headers */,
668662
F92B9FA90E2E64BC00A2FE61 /* GTMLogger+ASL.h in Headers */,
669663
F95803FA0E2FB08F0049A088 /* GTMLoggerRingBufferWriter.h in Headers */,
670-
8B3590160E8190FA0041E21C /* GTMTestTimer.h in Headers */,
671664
8B6F4B630E8856CA00425D9F /* GTMDebugThreadValidation.h in Headers */,
672665
F41711350ECDFBD500B9B276 /* GTMLightweightProxy.h in Headers */,
673666
8B6C15930F356E6400E51E5D /* GTMNSObject+KeyValueObserving.h in Headers */,
@@ -906,7 +899,6 @@
906899
files = (
907900
8B45A21A0DA46E1D001148C5 /* GTMGeometryUtils.m in Sources */,
908901
8B7DCE1B0DFF39850017E983 /* GTMSenTestCase.m in Sources */,
909-
8B35901B0E8191750041E21C /* GTMTestTimerTest.m in Sources */,
910902
F47466661296F19E0022C1FB /* GTMSenTestCaseTest.m in Sources */,
911903
);
912904
runOnlyForDeploymentPostprocessing = 0;

‎GTMiPhone.xcodeproj/project.pbxproj‎

Lines changed: 3 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,10 @@
33
archiveVersion = 1;
44
classes = {
55
};
6-
objectVersion = 53;
6+
objectVersion = 46;
77
objects = {
88

99
/* Begin PBXBuildFile section */
10-
8B2C72EB1D9EBBA10027BD14 /* GTMTestTimerTest.m in Sources */ = {isa = PBXBuildFile; fileRef = 8B2C72EA1D9EBBA10027BD14 /* GTMTestTimerTest.m */; };
1110
8B5769B121CD7C8300D924D3 /* GTMTimeUtilsTest.m in Sources */ = {isa = PBXBuildFile; fileRef = 8B5769AD21CD7C7600D924D3 /* GTMTimeUtilsTest.m */; };
1211
8B5769B221CD7C8600D924D3 /* GTMTimeUtils.m in Sources */ = {isa = PBXBuildFile; fileRef = 8B5769AC21CD7C7600D924D3 /* GTMTimeUtils.m */; };
1312
8B7651D81D9C872F00DB2C59 /* GTMLogger+ASL.m in Sources */ = {isa = PBXBuildFile; fileRef = 8B7651D61D9C872C00DB2C59 /* GTMLogger+ASL.m */; };
@@ -99,8 +98,6 @@
9998
8B2908AF11F8E7070064F50F /* GTMNSFileHandle+UniqueName.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = "GTMNSFileHandle+UniqueName.h"; sourceTree = "<group>"; };
10099
8B2908B011F8E7070064F50F /* GTMNSFileHandle+UniqueName.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = "GTMNSFileHandle+UniqueName.m"; sourceTree = "<group>"; };
101100
8B2908B111F8E7070064F50F /* GTMNSFileHandle+UniqueNameTest.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = "GTMNSFileHandle+UniqueNameTest.m"; sourceTree = "<group>"; };
102-
8B2C72E91D9EBBA10027BD14 /* GTMTestTimer.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = GTMTestTimer.h; sourceTree = "<group>"; };
103-
8B2C72EA1D9EBBA10027BD14 /* GTMTestTimerTest.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = GTMTestTimerTest.m; sourceTree = "<group>"; };
104101
8B308BCD0DAD0B8400183556 /* QuartzCore.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = QuartzCore.framework; path = System/Library/Frameworks/QuartzCore.framework; sourceTree = SDKROOT; };
105102
8B3AA9330E0336AC007E31B5 /* CFNetwork.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = CFNetwork.framework; path = System/Library/Frameworks/CFNetwork.framework; sourceTree = SDKROOT; };
106103
8B5769AC21CD7C7600D924D3 /* GTMTimeUtils.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = GTMTimeUtils.m; sourceTree = "<group>"; };
@@ -358,8 +355,6 @@
358355
8BC047F60DAE928A00C2D1CA /* GTMSenTestCase.h */,
359356
8BC047F70DAE928A00C2D1CA /* GTMSenTestCase.m */,
360357
F4746720129703600022C1FB /* GTMSenTestCaseTest.m */,
361-
8B2C72E91D9EBBA10027BD14 /* GTMTestTimer.h */,
362-
8B2C72EA1D9EBBA10027BD14 /* GTMTestTimerTest.m */,
363358
F435E49F0DC8F5290069CDE8 /* TestData */,
364359
);
365360
path = UnitTesting;
@@ -551,7 +546,6 @@
551546
8B82CF3E1D9C2373007182AA /* GTMNSFileHandle+UniqueNameTest.m in Sources */,
552547
8B82CF501D9C2385007182AA /* GTMSenTestCaseTest.m in Sources */,
553548
8B82CF471D9C2373007182AA /* GTMStackTraceTest.m in Sources */,
554-
8B2C72EB1D9EBBA10027BD14 /* GTMTestTimerTest.m in Sources */,
555549
8B82CF401D9C2373007182AA /* GTMNSObject+KeyValueObservingTest.m in Sources */,
556550
8B82CF451D9C2373007182AA /* GTMNSThread+BlocksTest.m in Sources */,
557551
);
@@ -593,11 +587,7 @@
593587
DEAD_CODE_STRIPPING = YES;
594588
GTM_HOST_OTHER_LDFLAGS = "-ObjC -lz";
595589
INFOPLIST_FILE = "UnitTest-Info.plist";
596-
LD_RUNPATH_SEARCH_PATHS = (
597-
"$(inherited)",
598-
"@executable_path/Frameworks",
599-
"@loader_path/Frameworks",
600-
);
590+
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks";
601591
PRODUCT_NAME = "$(TARGET_NAME)";
602592
};
603593
name = Debug;
@@ -611,11 +601,7 @@
611601
DEAD_CODE_STRIPPING = YES;
612602
GTM_HOST_OTHER_LDFLAGS = "-ObjC -lz";
613603
INFOPLIST_FILE = "UnitTest-Info.plist";
614-
LD_RUNPATH_SEARCH_PATHS = (
615-
"$(inherited)",
616-
"@executable_path/Frameworks",
617-
"@loader_path/Frameworks",
618-
);
604+
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks";
619605
PRODUCT_NAME = "$(TARGET_NAME)";
620606
};
621607
name = Release;

‎GoogleToolboxForMac.podspec‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -160,8 +160,4 @@ Pod::Spec.new do |s|
160160
}
161161
end
162162

163-
s.subspec 'TestTimer' do |sp|
164-
sp.source_files = 'UnitTesting/GTMTestTimer.h'
165-
end
166-
167163
end

‎UnitTesting/BUILD‎

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,6 @@
11
load("@build_bazel_rules_apple//apple:ios.bzl", "ios_build_test")
22
load("@build_bazel_rules_apple//apple:macos.bzl", "macos_build_test")
33

4-
objc_library(
5-
name = "TestTimer",
6-
testonly = 1,
7-
hdrs = [
8-
"GTMTestTimer.h",
9-
],
10-
visibility = ["//visibility:public"],
11-
deps = [
12-
"//:Defines",
13-
],
14-
)
15-
164
objc_library(
175
name = "SenTestCase",
186
testonly = 1,
@@ -32,7 +20,6 @@ ios_build_test(
3220
name = "iOSBuildTest",
3321
minimum_os_version = "12.0",
3422
targets = [
35-
":TestTimer",
3623
":SenTestCase",
3724
],
3825
)
@@ -41,7 +28,6 @@ macos_build_test(
4128
name = "macOSBuildTest",
4229
minimum_os_version = "10.10",
4330
targets = [
44-
":TestTimer",
4531
":SenTestCase",
4632
],
4733
)

‎UnitTesting/GTMTestTimer.h‎

Lines changed: 0 additions & 128 deletions
This file was deleted.

‎UnitTesting/GTMTestTimerTest.m‎

Lines changed: 0 additions & 56 deletions
This file was deleted.

0 commit comments

Comments
 (0)