Skip to content
This repository was archived by the owner on Oct 20, 2022. It is now read-only.

Commit f147db7

Browse files
author
shubay
committed
Fix for issue 16.
1 parent e8f8371 commit f147db7

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

src/main/java/com/google/visualization/datasource/util/SqlDataSourceHelper.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -334,7 +334,7 @@ private static void buildWhereClauseForIsNullFilter(StrBuilder whereClause,
334334
QueryFilter queryFilter) {
335335
ColumnIsNullFilter filter = (ColumnIsNullFilter) queryFilter;
336336

337-
whereClause.append("(").append(filter.getColumn().getId()).append(" IS NULL)");
337+
whereClause.append("(").append(getColumnId(filter.getColumn())).append(" IS NULL)");
338338
}
339339

340340
/**
@@ -352,11 +352,11 @@ private static void buildWhereCluaseForComparisonFilter(
352352
// Build the left part and the right part of the clause according to the filter's type.
353353
if (queryFilter instanceof ColumnColumnFilter) {
354354
ColumnColumnFilter filter = (ColumnColumnFilter) queryFilter;
355-
first.append(filter.getFirstColumn().getId());
356-
second.append(filter.getSecondColumn().getId());
355+
first.append(getColumnId(filter.getFirstColumn()));
356+
second.append(getColumnId(filter.getSecondColumn()));
357357
} else { // The filter is a ColumnValueFilter
358358
ColumnValueFilter filter = (ColumnValueFilter) queryFilter;
359-
first.append(filter.getColumn().getId());
359+
first.append(getColumnId(filter.getColumn()));
360360
second.append(filter.getValue().toString());
361361
if ((filter.getValue().getType() == ValueType.TEXT)
362362
|| (filter.getValue().getType() == ValueType.DATE)

src/test/java/com/google/visualization/datasource/util/SqlDataSourceHelperTest.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -180,8 +180,8 @@ public void testBuildWhereClause() {
180180
StrBuilder queryStringBuilder = new StrBuilder();
181181
SqlDataSourceHelper.appendWhereClause(query, queryStringBuilder);
182182
assertEquals(queryStringBuilder.toString(),
183-
"WHERE (((ID=Salary) AND (ID>=1.0)) OR ((Fname LIKE \"Mi%\") "
184-
+ "AND (Lname LIKE \"%SH%\") AND (Lname LIKE \"%tz\"))) ",
183+
"WHERE (((`ID`=`Salary`) AND (`ID`>=1.0)) OR ((`Fname` LIKE \"Mi%\") "
184+
+ "AND (`Lname` LIKE \"%SH%\") AND (`Lname` LIKE \"%tz\"))) ",
185185
queryStringBuilder.toString());
186186

187187
// Check empty compound filters.
@@ -208,15 +208,15 @@ public void testBuildWhereClause() {
208208
query.setFilter(queryCompoundFilter6);
209209
queryStringBuilder = new StrBuilder();
210210
SqlDataSourceHelper.appendWhereClause(query, queryStringBuilder);
211-
assertEquals(queryStringBuilder.toString(), "WHERE ((ID=Salary)) ",
211+
assertEquals(queryStringBuilder.toString(), "WHERE ((`ID`=`Salary`)) ",
212212
queryStringBuilder.toString());
213213

214214
// Check "is null".
215215
ColumnIsNullFilter isNullFilter = new ColumnIsNullFilter(new SimpleColumn("ID"));
216216
query.setFilter(isNullFilter);
217217
queryStringBuilder = new StrBuilder();
218218
SqlDataSourceHelper.appendWhereClause(query, queryStringBuilder);
219-
assertEquals("WHERE (ID IS NULL) ", queryStringBuilder.toString());
219+
assertEquals("WHERE (`ID` IS NULL) ", queryStringBuilder.toString());
220220

221221
// Check negation.
222222
NegationFilter negationFilter =
@@ -225,7 +225,7 @@ public void testBuildWhereClause() {
225225
query.setFilter(negationFilter);
226226
queryStringBuilder = new StrBuilder();
227227
SqlDataSourceHelper.appendWhereClause(query, queryStringBuilder);
228-
assertEquals("WHERE (NOT (ID=Salary)) ", queryStringBuilder.toString());
228+
assertEquals("WHERE (NOT (`ID`=`Salary`)) ", queryStringBuilder.toString());
229229
}
230230

231231
/**

0 commit comments

Comments
 (0)