Skip to content

Commit 7a7231c

Browse files
Abseil Teamcopybara-github
authored andcommitted
Fix link in ReportUninterestingCall message
This CL changes the link in the ReportUninterestingCall message from .../gmock_cook_book.md#knowing-when-to-expect to .../gmock_cook_book.md#knowing-when-to-expect-useoncall. This is necessary following 31ff597. PiperOrigin-RevId: 510138974 Change-Id: Ic98c84b07751d27dfc95eddbe7874f76d68b456f
1 parent f063cd2 commit 7a7231c

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

googlemock/src/gmock-spec-builders.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -297,7 +297,7 @@ void ReportUninterestingCall(CallReaction reaction, const std::string& msg) {
297297
"See "
298298
"https://github.com/google/googletest/blob/main/docs/"
299299
"gmock_cook_book.md#"
300-
"knowing-when-to-expect for details.\n",
300+
"knowing-when-to-expect-useoncall for details.\n",
301301
stack_frames_to_skip);
302302
break;
303303
default: // FAIL

googlemock/test/gmock-spec-builders_test.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2050,7 +2050,7 @@ class GMockVerboseFlagTest : public VerboseFlagPreservingFixture {
20502050
"See "
20512051
"https://github.com/google/googletest/blob/main/docs/"
20522052
"gmock_cook_book.md#"
2053-
"knowing-when-to-expect for details.";
2053+
"knowing-when-to-expect-useoncall for details.";
20542054

20552055
// A void-returning function.
20562056
CaptureStdout();

googlemock/test/gmock_output_test_golden.txt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -75,14 +75,14 @@ GMOCK WARNING:
7575
Uninteresting mock function call - returning default value.
7676
Function call: Bar2(0, 1)
7777
Returns: false
78-
NOTE: You can safely ignore the above warning unless this call should not happen. Do not suppress it by blindly adding an EXPECT_CALL() if you don't mean to enforce the call. See https://github.com/google/googletest/blob/main/docs/gmock_cook_book.md#knowing-when-to-expect for details.
78+
NOTE: You can safely ignore the above warning unless this call should not happen. Do not suppress it by blindly adding an EXPECT_CALL() if you don't mean to enforce the call. See https://github.com/google/googletest/blob/main/docs/gmock_cook_book.md#knowing-when-to-expect-useoncall for details.
7979
[ OK ] GMockOutputTest.UninterestingCall
8080
[ RUN ] GMockOutputTest.UninterestingCallToVoidFunction
8181

8282
GMOCK WARNING:
8383
Uninteresting mock function call - returning directly.
8484
Function call: Bar3(0, 1)
85-
NOTE: You can safely ignore the above warning unless this call should not happen. Do not suppress it by blindly adding an EXPECT_CALL() if you don't mean to enforce the call. See https://github.com/google/googletest/blob/main/docs/gmock_cook_book.md#knowing-when-to-expect for details.
85+
NOTE: You can safely ignore the above warning unless this call should not happen. Do not suppress it by blindly adding an EXPECT_CALL() if you don't mean to enforce the call. See https://github.com/google/googletest/blob/main/docs/gmock_cook_book.md#knowing-when-to-expect-useoncall for details.
8686
[ OK ] GMockOutputTest.UninterestingCallToVoidFunction
8787
[ RUN ] GMockOutputTest.RetiredExpectation
8888
unknown file: Failure
@@ -266,14 +266,14 @@ Uninteresting mock function call - taking default action specified at:
266266
FILE:#:
267267
Function call: Bar2(2, 2)
268268
Returns: true
269-
NOTE: You can safely ignore the above warning unless this call should not happen. Do not suppress it by blindly adding an EXPECT_CALL() if you don't mean to enforce the call. See https://github.com/google/googletest/blob/main/docs/gmock_cook_book.md#knowing-when-to-expect for details.
269+
NOTE: You can safely ignore the above warning unless this call should not happen. Do not suppress it by blindly adding an EXPECT_CALL() if you don't mean to enforce the call. See https://github.com/google/googletest/blob/main/docs/gmock_cook_book.md#knowing-when-to-expect-useoncall for details.
270270

271271
GMOCK WARNING:
272272
Uninteresting mock function call - taking default action specified at:
273273
FILE:#:
274274
Function call: Bar2(1, 1)
275275
Returns: false
276-
NOTE: You can safely ignore the above warning unless this call should not happen. Do not suppress it by blindly adding an EXPECT_CALL() if you don't mean to enforce the call. See https://github.com/google/googletest/blob/main/docs/gmock_cook_book.md#knowing-when-to-expect for details.
276+
NOTE: You can safely ignore the above warning unless this call should not happen. Do not suppress it by blindly adding an EXPECT_CALL() if you don't mean to enforce the call. See https://github.com/google/googletest/blob/main/docs/gmock_cook_book.md#knowing-when-to-expect-useoncall for details.
277277
[ OK ] GMockOutputTest.UninterestingCallWithDefaultAction
278278
[ RUN ] GMockOutputTest.ExplicitActionsRunOutWithDefaultAction
279279

0 commit comments

Comments
 (0)