Skip to content

Commit 7e2c425

Browse files
Abseil Teamcopybara-github
authored andcommitted
Remove "blindly" from the gmock "uninteresting call" message.
PiperOrigin-RevId: 767766090 Change-Id: I9202c1c24a3af8d73806f68ca93025b26704178e
1 parent e9092b1 commit 7e2c425

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

googlemock/src/gmock-spec-builders.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -293,7 +293,7 @@ void ReportUninterestingCall(CallReaction reaction, const std::string& msg) {
293293
Log(kWarning,
294294
msg +
295295
"\nNOTE: You can safely ignore the above warning unless this "
296-
"call should not happen. Do not suppress it by blindly adding "
296+
"call should not happen. Do not suppress it by adding "
297297
"an EXPECT_CALL() if you don't mean to enforce the call. "
298298
"See "
299299
"https://github.com/google/googletest/blob/main/docs/"

googlemock/test/gmock-spec-builders_test.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2045,7 +2045,7 @@ class GMockVerboseFlagTest : public VerboseFlagPreservingFixture {
20452045
NaggyMock<MockA> a;
20462046
const std::string note =
20472047
"NOTE: You can safely ignore the above warning unless this "
2048-
"call should not happen. Do not suppress it by blindly adding "
2048+
"call should not happen. Do not suppress it by adding "
20492049
"an EXPECT_CALL() if you don't mean to enforce the call. "
20502050
"See "
20512051
"https://github.com/google/googletest/blob/main/docs/"

googlemock/test/gmock_output_test_golden.txt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -79,14 +79,14 @@ GMOCK WARNING:
7979
Uninteresting mock function call - returning default value.
8080
Function call: Bar2(0, 1)
8181
Returns: false
82-
NOTE: You can safely ignore the above warning unless this call should not happen. Do not suppress it by blindly adding an EXPECT_CALL() if you don't mean to enforce the call. See https://github.com/google/googletest/blob/main/docs/gmock_cook_book.md#knowing-when-to-expect-useoncall for details.
82+
NOTE: You can safely ignore the above warning unless this call should not happen. Do not suppress it by adding an EXPECT_CALL() if you don't mean to enforce the call. See https://github.com/google/googletest/blob/main/docs/gmock_cook_book.md#knowing-when-to-expect-useoncall for details.
8383
[ OK ] GMockOutputTest.UninterestingCall
8484
[ RUN ] GMockOutputTest.UninterestingCallToVoidFunction
8585

8686
GMOCK WARNING:
8787
Uninteresting mock function call - returning directly.
8888
Function call: Bar3(0, 1)
89-
NOTE: You can safely ignore the above warning unless this call should not happen. Do not suppress it by blindly adding an EXPECT_CALL() if you don't mean to enforce the call. See https://github.com/google/googletest/blob/main/docs/gmock_cook_book.md#knowing-when-to-expect-useoncall for details.
89+
NOTE: You can safely ignore the above warning unless this call should not happen. Do not suppress it by adding an EXPECT_CALL() if you don't mean to enforce the call. See https://github.com/google/googletest/blob/main/docs/gmock_cook_book.md#knowing-when-to-expect-useoncall for details.
9090
[ OK ] GMockOutputTest.UninterestingCallToVoidFunction
9191
[ RUN ] GMockOutputTest.RetiredExpectation
9292
unknown file: Failure
@@ -283,14 +283,14 @@ Uninteresting mock function call - taking default action specified at:
283283
FILE:#:
284284
Function call: Bar2(2, 2)
285285
Returns: true
286-
NOTE: You can safely ignore the above warning unless this call should not happen. Do not suppress it by blindly adding an EXPECT_CALL() if you don't mean to enforce the call. See https://github.com/google/googletest/blob/main/docs/gmock_cook_book.md#knowing-when-to-expect-useoncall for details.
286+
NOTE: You can safely ignore the above warning unless this call should not happen. Do not suppress it by adding an EXPECT_CALL() if you don't mean to enforce the call. See https://github.com/google/googletest/blob/main/docs/gmock_cook_book.md#knowing-when-to-expect-useoncall for details.
287287

288288
GMOCK WARNING:
289289
Uninteresting mock function call - taking default action specified at:
290290
FILE:#:
291291
Function call: Bar2(1, 1)
292292
Returns: false
293-
NOTE: You can safely ignore the above warning unless this call should not happen. Do not suppress it by blindly adding an EXPECT_CALL() if you don't mean to enforce the call. See https://github.com/google/googletest/blob/main/docs/gmock_cook_book.md#knowing-when-to-expect-useoncall for details.
293+
NOTE: You can safely ignore the above warning unless this call should not happen. Do not suppress it by adding an EXPECT_CALL() if you don't mean to enforce the call. See https://github.com/google/googletest/blob/main/docs/gmock_cook_book.md#knowing-when-to-expect-useoncall for details.
294294
[ OK ] GMockOutputTest.UninterestingCallWithDefaultAction
295295
[ RUN ] GMockOutputTest.ExplicitActionsRunOutWithDefaultAction
296296

0 commit comments

Comments
 (0)