Skip to content

Commit 9f79a95

Browse files
mkruskal-googlecopybara-github
authored andcommitted
Add [[nodiscard]] to GetParam() to prevent accidental misuse.
This helps avoid a situation where someone sets up a parameterized test but forgets to actually use the parameter. PiperOrigin-RevId: 758455362 Change-Id: Ie4db03e82b6a4e1787be96f154b3fbb25657ae64
1 parent 8b8ef3f commit 9f79a95

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

googletest/include/gtest/gtest.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1693,7 +1693,7 @@ class WithParamInterface {
16931693

16941694
// The current parameter value. Is also available in the test fixture's
16951695
// constructor.
1696-
static const ParamType& GetParam() {
1696+
[[nodiscard]] static const ParamType& GetParam() {
16971697
GTEST_CHECK_(parameter_ != nullptr)
16981698
<< "GetParam() can only be called inside a value-parameterized test "
16991699
<< "-- did you intend to write TEST_P instead of TEST_F?";

googletest/test/googletest-param-test-test.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1174,7 +1174,7 @@ TEST_P(ParameterizedDerivedTest, SeesSequence) {
11741174
class ParameterizedDeathTest : public ::testing::TestWithParam<int> {};
11751175

11761176
TEST_F(ParameterizedDeathTest, GetParamDiesFromTestF) {
1177-
EXPECT_DEATH_IF_SUPPORTED(GetParam(), ".* value-parameterized test .*");
1177+
EXPECT_DEATH_IF_SUPPORTED((void)GetParam(), ".* value-parameterized test .*");
11781178
}
11791179

11801180
INSTANTIATE_TEST_SUITE_P(RangeZeroToFive, ParameterizedDerivedTest,

0 commit comments

Comments
 (0)