Some googletest veteran should update outdated comments in sample code. #4176
Unanswered
chjfth
asked this question in
Community Help
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
I'm learning googletest these days, so having chance to read quite some sample code in it. I find quite some cases of outdated code comments, which no longer match current code behavior for quite many years.
For example, sample3_unittest.cc says:
googletest/googletest/samples/sample3_unittest.cc
Line 53 in 2d4f208
This paragraph has been there intact since 2008-07-04(the earliest date in the git repo), and the statement "you cannot use them
(EXPECT_TRUE, FAIL, etc) in a global function" is wrong according to my experiment today. Yes, no such limitation exists. They may existed once in a very ancient version.
I think these misleading comment words should be fixed early.
Beta Was this translation helpful? Give feedback.
All reactions