# [grain] Add checks for parameters passed to grain.experimental.index_shuffle that will throw an exception that can be caught by the Python interpreter#1144
Merged
copybara-service[bot] merged 1 commit intomainfrom Dec 1, 2025
Conversation
copybara-service
bot
force-pushed
the
test_838873254
branch
3 times, most recently
from
378f0db to
0165da3
Compare
copybara-service
bot
changed the title
grain.experimental.index_shuffle that will throw an exception that can by caught by the Python interpretergrain.experimental.index_shuffle that will throw an exception that can be caught by the Python interpreter
copybara-service
bot
force-pushed
the
test_838873254
branch
11 times, most recently
from
a2ce6be to
955e09c
Compare
…ex_shuffle` that will throw an exception that can be caught by the Python interpreter Currently when an invalid `rounds` parameter is passed, an assert fails which crashes the interpreter. If index > max_index, an infinite loop may result, but this depends on the seed. PiperOrigin-RevId: 838928653
copybara-service
bot
force-pushed
the
test_838873254
branch
from
955e09c to
3a5796b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[grain] Add checks for parameters passed to
grain.experimental.index_shufflethat will throw an exception that can be caught by the Python interpreterCurrently when an invalid
roundsparameter is passed, an assert fails which crashes the interpreter. If index > max_index, an infinite loop may result, but this depends on the seed.