Remove unused imports (#2397)

Co-authored-by: Roberto Fontanarosa <[email protected]>

Author: gino-m

eslint.base.config.mjs

@@ -16,6 +16,7 @@
 
 import gts from 'gts/build/eslint.config.js';
 import prettierPlugin from 'eslint-plugin-prettier';
+import unusedImports from 'eslint-plugin-unused-imports';
 
 export default [
   {
@@ -32,6 +33,7 @@ export default [
   {
     plugins: {
       prettier: prettierPlugin,
+      'unused-imports': unusedImports,
     },
     languageOptions: {
       globals: {
@@ -53,6 +55,7 @@ export default [
         clearTimeout: 'readonly',
         clearInterval: 'readonly',
         console: 'readonly',
+        // 'unused-imports': 'readonly' // Is this needed? No, it's a plugin.
       },
     },
     rules: {
@@ -71,6 +74,17 @@ export default [
       'n/no-extraneous-import': 'off',
       'n/no-missing-import': 'off',
       'prettier/prettier': 'warn',
+      'no-unused-vars': 'off',
+      'unused-imports/no-unused-imports': 'error',
+      'unused-imports/no-unused-vars': [
+        'warn',
+        {
+          vars: 'all',
+          varsIgnorePattern: '^_',
+          args: 'after-used',
+          argsIgnorePattern: '^_',
+        },
+      ],
     },
   },
 ];

package.json

@@ -89,6 +89,7 @@
     "eslint-plugin-import": "catalog:dev",
     "eslint-plugin-n": "catalog:dev",
     "eslint-plugin-prettier": "catalog:dev",
+    "eslint-plugin-unused-imports": "catalog:dev",
     "firebase-tools": "catalog:dev",
     "gts": "catalog:dev",
     "jasmine": "catalog:dev",

pnpm-lock.yaml

@@ -88,6 +88,7 @@ catalogs:
     eslint-plugin-import: ^2.29.0
     eslint-plugin-n: ^17.0.0
     eslint-plugin-prettier: ^5.5.4
+    eslint-plugin-unused-imports: ^4.3.0
     firebase-functions-test: ^3.3.0
     firebase-tools: ^14.0.0
     form-data-encoder: ^4.0.2

pnpm-workspace.yaml

@@ -19,7 +19,6 @@ import { ComponentFixture, TestBed } from '@angular/core/testing';
 import { MatDialogModule } from '@angular/material/dialog';
 
 import { Job } from 'app/models/job.model';
-
 import { DialogService } from 'app/services/dialog/dialog.service';
 
 import { TaskDetailsComponent } from './task-details.component';

web/src/app/components/create-survey/task-details/task-details.component.spec.ts

@@ -23,7 +23,6 @@ import { List, Map } from 'immutable';
 import { of } from 'rxjs';
 
 import { Coordinate } from 'app/models/geometry/coordinate';
-
 import { Point } from 'app/models/geometry/point';
 import { Job } from 'app/models/job.model';
 import { LocationOfInterest } from 'app/models/loi.model';

web/src/app/components/main-page-container/main-page/secondary-side-panel/loi-panel/loi-panel.component.spec.ts

@@ -27,7 +27,6 @@ import { User } from 'app/models/user.model';
 import { AuthService } from 'app/services/auth/auth.service';
 import { DataStoreService } from 'app/services/data-store/data-store.service';
 import { LocationOfInterestService } from 'app/services/loi/loi.service';
-
 import { SurveyService } from 'app/services/survey/survey.service';
 import { polygonShellCoordsToPolygon } from 'testing/helpers';
 

web/src/app/services/loi/loi.service.spec.ts

@@ -23,7 +23,6 @@ import { User } from 'app/models/user.model';
 import { AuthService } from 'app/services/auth/auth.service';
 import { DataStoreService } from 'app/services/data-store/data-store.service';
 import { SurveyService } from 'app/services/survey/survey.service';
-
 import { Role } from 'app/models/role.model';
 import { NavigationService } from 'app/services/navigation/navigation.service';