[Sign-in screen] Incorrect styling of sign on button

[gino-m]

When removing firebaseui we used a basic Material chip button for the sign-in button. We should replace this with a standard "Sign in with Google" button.

[sidd190]

Hello, I'm a new contributor here. I'd like to pick this up! Could you redirect me to a previous issue/fix related to this so I can understand what exactly was removed and what to be used instead?

Just a few other things -

• The contributing guidelines file is outdated (Should I raise a PR with the updated file? nvm versions, monorepo info and usage of nx and pnpm is missing overall)
• Is there a community channel like slack or a forum or something to be able to discuss these things?
• Do the older issues still accept fixes, like the issues that were opened quite a while ago?

[gino-m]

@sidd190

The contributing guidelines file is outdated (Should I raise a PR with the updated file? nvm versions, monorepo info and usage of nx and pnpm is missing overall)

That would be fantastic, thanks! Could just remove the sections describing env install and start, and instead refer to the README.md in the root dir?

Is there a community channel like slack or a forum or something to be able to discuss these things?

Not at the moment, but if you write on issues we'll reply ASAP.

Do the older issues still accept fixes, like the issues that were opened quite a while ago?

In most cases, yes. But please ask for clarification and if the issue is still valid before beginning just to be sure.

Thanks for your interest in contributing!

[sidd190]

@gino-m
Thanks for your interest in contributing!

Lovely! I've completed the setup locally and opened a PR for the contributing guidelines fix, thanks!

[sidd190]

@gino-m

When removing firebaseui we used a basic Material chip button for the sign-in button. We should replace this with a standard "Sign in with Google" button.

Only the styles are supposed to be changed here since the backend around this already works fine right? Though I'm not sure if using the JWT flow, the small description text in the button is supposed to be made to work? The UI changes look like this for now -

[gino-m]

Only the styles are supposed to be changed here since the backend around this already works fine right?

That's correct.

Though I'm not sure if using the JWT flow, the small description text in the button is supposed to be made to work? The UI changes look like this for now -

The proposed design looks great, please go ahead! Which description text, and what do you mean by "made to work"?

[sidd190]

The proposed design looks great, please go ahead! Which description text, and what do you mean by "made to work"?

Okayy! I was just going through google's guidelines on standard sign in buttons and one of them, this one, showed this description text with JWT response so I was just confirming whether to do this or not since it'd require some changes in the auth functions.

PS: Pay no mind to "made to work", I just fumbled, I wanted to ask like, -- is it supposed to be done?

[gino-m]

I see! So the description text would just be the user's name and email if they're already signed in.. for now can we just add the simple sign in button w/o the changes to auth functions? That can be done for extra credit in a separate PR if it's easy. :)

[sidd190]

I see! So the description text would just be the user's name and email if they're already signed in.. for now can we just add the simple sign in button w/o the changes to auth functions? That can be done for extra credit in a separate PR if it's easy. :)

Got it, I'll link the fix! 😸