Ensure there are no duplicate HttpHeader field names defined.

RELNOTES=n/a
PiperOrigin-RevId: 753681079

Author: kluever

android/guava-tests/test/com/google/common/net/HttpHeadersTest.java

@@ -16,10 +16,13 @@
 
 package com.google.common.net;
 
+import static com.google.common.truth.Truth.assertThat;
+
 import com.google.common.base.Ascii;
 import com.google.common.base.Joiner;
 import com.google.common.base.Splitter;
 import com.google.common.collect.ImmutableBiMap;
+import com.google.common.collect.ImmutableList;
 import com.google.common.collect.ImmutableSet;
 import com.google.common.collect.Lists;
 import java.lang.reflect.Field;
@@ -55,25 +58,25 @@ public void testConstantNameMatchesString() throws Exception {
         ImmutableSet.of(
             "CH", "ID", "DNT", "DNS", "DPR", "ECT", "GPC", "HTTP2", "IP", "MD5", "P3P", "RTT", "TE",
             "UA", "UID", "URL", "WWW", "XSS");
-    assertConstantNameMatchesString(HttpHeaders.class, specialCases, uppercaseAcronyms);
-  }
 
-  // Visible for other tests to use
-  static void assertConstantNameMatchesString(
-      Class<?> clazz,
-      ImmutableBiMap<String, String> specialCases,
-      ImmutableSet<String> uppercaseAcronyms)
-      throws IllegalAccessException {
-    for (Field field : relevantFields(clazz)) {
+    for (Field field : httpHeadersFields()) {
       assertEquals(
           upperToHttpHeaderName(field.getName(), specialCases, uppercaseAcronyms), field.get(null));
     }
   }
 
-  // Visible for other tests to use
-  static ImmutableSet<Field> relevantFields(Class<?> cls) {
+  // Tests that there are no duplicate HTTP header names
+  public void testNoDuplicateFields() throws Exception {
+    ImmutableList.Builder<String> httpHeaders = ImmutableList.builder();
+    for (Field field : httpHeadersFields()) {
+      httpHeaders.add((String) field.get(null));
+    }
+    assertThat(httpHeaders.build()).containsNoDuplicates();
+  }
+
+  private static ImmutableSet<Field> httpHeadersFields() {
     ImmutableSet.Builder<Field> builder = ImmutableSet.builder();
-    for (Field field : cls.getDeclaredFields()) {
+    for (Field field : HttpHeaders.class.getDeclaredFields()) {
       /*
        * Coverage mode generates synthetic fields.  If we ever add private
        * fields, they will cause similar problems, and we may want to switch
@@ -86,9 +89,6 @@ static ImmutableSet<Field> relevantFields(Class<?> cls) {
     return builder.build();
   }
 
-  private static final Splitter SPLITTER = Splitter.on('_');
-  private static final Joiner JOINER = Joiner.on('-');
-
   private static String upperToHttpHeaderName(
       String constantName,
       ImmutableBiMap<String, String> specialCases,
@@ -97,12 +97,12 @@ private static String upperToHttpHeaderName(
       return specialCases.get(constantName);
     }
     List<String> parts = Lists.newArrayList();
-    for (String part : SPLITTER.split(constantName)) {
+    for (String part : Splitter.on('_').split(constantName)) {
       if (!uppercaseAcronyms.contains(part)) {
         part = part.charAt(0) + Ascii.toLowerCase(part.substring(1));
       }
       parts.add(part);
     }
-    return JOINER.join(parts);
+    return Joiner.on('-').join(parts);
   }
 }

guava-tests/test/com/google/common/net/HttpHeadersTest.java

@@ -16,10 +16,13 @@
 
 package com.google.common.net;
 
+import static com.google.common.truth.Truth.assertThat;
+
 import com.google.common.base.Ascii;
 import com.google.common.base.Joiner;
 import com.google.common.base.Splitter;
 import com.google.common.collect.ImmutableBiMap;
+import com.google.common.collect.ImmutableList;
 import com.google.common.collect.ImmutableSet;
 import com.google.common.collect.Lists;
 import java.lang.reflect.Field;
@@ -55,25 +58,25 @@ public void testConstantNameMatchesString() throws Exception {
         ImmutableSet.of(
             "CH", "ID", "DNT", "DNS", "DPR", "ECT", "GPC", "HTTP2", "IP", "MD5", "P3P", "RTT", "TE",
             "UA", "UID", "URL", "WWW", "XSS");
-    assertConstantNameMatchesString(HttpHeaders.class, specialCases, uppercaseAcronyms);
-  }
 
-  // Visible for other tests to use
-  static void assertConstantNameMatchesString(
-      Class<?> clazz,
-      ImmutableBiMap<String, String> specialCases,
-      ImmutableSet<String> uppercaseAcronyms)
-      throws IllegalAccessException {
-    for (Field field : relevantFields(clazz)) {
+    for (Field field : httpHeadersFields()) {
       assertEquals(
           upperToHttpHeaderName(field.getName(), specialCases, uppercaseAcronyms), field.get(null));
     }
   }
 
-  // Visible for other tests to use
-  static ImmutableSet<Field> relevantFields(Class<?> cls) {
+  // Tests that there are no duplicate HTTP header names
+  public void testNoDuplicateFields() throws Exception {
+    ImmutableList.Builder<String> httpHeaders = ImmutableList.builder();
+    for (Field field : httpHeadersFields()) {
+      httpHeaders.add((String) field.get(null));
+    }
+    assertThat(httpHeaders.build()).containsNoDuplicates();
+  }
+
+  private static ImmutableSet<Field> httpHeadersFields() {
     ImmutableSet.Builder<Field> builder = ImmutableSet.builder();
-    for (Field field : cls.getDeclaredFields()) {
+    for (Field field : HttpHeaders.class.getDeclaredFields()) {
       /*
        * Coverage mode generates synthetic fields.  If we ever add private
        * fields, they will cause similar problems, and we may want to switch
@@ -86,9 +89,6 @@ static ImmutableSet<Field> relevantFields(Class<?> cls) {
     return builder.build();
   }
 
-  private static final Splitter SPLITTER = Splitter.on('_');
-  private static final Joiner JOINER = Joiner.on('-');
-
   private static String upperToHttpHeaderName(
       String constantName,
       ImmutableBiMap<String, String> specialCases,
@@ -97,12 +97,12 @@ private static String upperToHttpHeaderName(
       return specialCases.get(constantName);
     }
     List<String> parts = Lists.newArrayList();
-    for (String part : SPLITTER.split(constantName)) {
+    for (String part : Splitter.on('_').split(constantName)) {
       if (!uppercaseAcronyms.contains(part)) {
         part = part.charAt(0) + Ascii.toLowerCase(part.substring(1));
       }
       parts.add(part);
     }
-    return JOINER.join(parts);
+    return Joiner.on('-').join(parts);
   }
 }