Skip to content

Commit 7d6452c

Browse files
klueverGoogle Java Core Libraries
authored andcommitted
Migrate from Guava's Object APIs to the JDK replacements.
RELNOTES=n/a PiperOrigin-RevId: 780646928
1 parent 0d70b3b commit 7d6452c

File tree

94 files changed

+276
-276
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

94 files changed

+276
-276
lines changed

android/guava-testlib/src/com/google/common/collect/testing/Helpers.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@
4949
@GwtCompatible(emulated = true)
5050
@NullMarked
5151
public class Helpers {
52-
// Clone of Objects.equal
52+
// Clone of Objects.equals
5353
static boolean equal(@Nullable Object a, @Nullable Object b) {
5454
return a == b || (a != null && a.equals(b));
5555
}

android/guava-testlib/src/com/google/common/testing/NullPointerTester.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@
2525
import com.google.common.annotations.GwtIncompatible;
2626
import com.google.common.annotations.J2ktIncompatible;
2727
import com.google.common.base.Converter;
28-
import com.google.common.base.Objects;
2928
import com.google.common.collect.ClassToInstanceMap;
3029
import com.google.common.collect.ImmutableList;
3130
import com.google.common.collect.ImmutableSet;
@@ -48,6 +47,7 @@
4847
import java.util.ArrayList;
4948
import java.util.Arrays;
5049
import java.util.List;
50+
import java.util.Objects;
5151
import java.util.concurrent.ConcurrentMap;
5252
import junit.framework.Assert;
5353
import org.jspecify.annotations.NullMarked;
@@ -365,7 +365,7 @@ public boolean equals(@Nullable Object obj) {
365365

366366
@Override
367367
public int hashCode() {
368-
return Objects.hashCode(name, parameterTypes);
368+
return Objects.hash(name, parameterTypes);
369369
}
370370
}
371371

android/guava-tests/test/com/google/common/cache/CacheBuilderFactory.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616

1717
import com.google.common.base.Function;
1818
import com.google.common.base.MoreObjects;
19-
import com.google.common.base.Objects;
2019
import com.google.common.base.Optional;
2120
import com.google.common.base.Preconditions;
2221
import com.google.common.cache.LocalCache.Strength;
@@ -26,6 +25,7 @@
2625
import com.google.errorprone.annotations.CanIgnoreReturnValue;
2726
import java.util.LinkedHashSet;
2827
import java.util.List;
28+
import java.util.Objects;
2929
import java.util.Set;
3030
import java.util.concurrent.TimeUnit;
3131
import org.jspecify.annotations.NullUnmarked;
@@ -221,7 +221,7 @@ public static DurationSpec of(long duration, TimeUnit unit) {
221221

222222
@Override
223223
public int hashCode() {
224-
return Objects.hashCode(duration, unit);
224+
return Objects.hash(duration, unit);
225225
}
226226

227227
@Override

android/guava-tests/test/com/google/common/collect/AbstractTableReadTest.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,9 @@
2222
import com.google.common.annotations.GwtCompatible;
2323
import com.google.common.annotations.GwtIncompatible;
2424
import com.google.common.annotations.J2ktIncompatible;
25-
import com.google.common.base.Objects;
2625
import com.google.common.testing.EqualsTester;
2726
import com.google.common.testing.NullPointerTester;
27+
import java.util.Objects;
2828
import junit.framework.TestCase;
2929
import org.jspecify.annotations.NullMarked;
3030
import org.jspecify.annotations.Nullable;
@@ -142,9 +142,7 @@ public void testEquals() {
142142
public void testHashCode() {
143143
table = create("foo", 1, 'a', "bar", 1, 'b', "foo", 3, 'c');
144144
int expected =
145-
Objects.hashCode("foo", 1, 'a')
146-
+ Objects.hashCode("bar", 1, 'b')
147-
+ Objects.hashCode("foo", 3, 'c');
145+
Objects.hash("foo", 1, 'a') + Objects.hash("bar", 1, 'b') + Objects.hash("foo", 3, 'c');
148146
assertEquals(expected, table.hashCode());
149147
}
150148

android/guava-tests/test/com/google/common/collect/ArrayTableTest.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,14 +24,14 @@
2424
import com.google.common.annotations.GwtCompatible;
2525
import com.google.common.annotations.GwtIncompatible;
2626
import com.google.common.annotations.J2ktIncompatible;
27-
import com.google.common.base.Objects;
2827
import com.google.common.collect.Table.Cell;
2928
import com.google.common.testing.EqualsTester;
3029
import com.google.common.testing.NullPointerTester;
3130
import com.google.common.testing.SerializableTester;
3231
import java.util.Arrays;
3332
import java.util.HashMap;
3433
import java.util.Map;
34+
import java.util.Objects;
3535
import org.jspecify.annotations.NullMarked;
3636
import org.jspecify.annotations.Nullable;
3737

@@ -156,10 +156,10 @@ public void testHashCode() {
156156
table.put("bar", 1, 'b');
157157
table.put("foo", 3, 'c');
158158
int expected =
159-
Objects.hashCode("foo", 1, 'a')
160-
+ Objects.hashCode("bar", 1, 'b')
161-
+ Objects.hashCode("foo", 3, 'c')
162-
+ Objects.hashCode("bar", 3, 0);
159+
Objects.hash("foo", 1, 'a')
160+
+ Objects.hash("bar", 1, 'b')
161+
+ Objects.hash("foo", 3, 'c')
162+
+ Objects.hash("bar", 3, 0);
163163
assertEquals(expected, table.hashCode());
164164
}
165165

android/guava-tests/test/com/google/common/collect/FauxveridesTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,14 +25,14 @@
2525

2626
import com.google.common.base.Function;
2727
import com.google.common.base.Joiner;
28-
import com.google.common.base.Objects;
2928
import java.lang.reflect.Method;
3029
import java.lang.reflect.Type;
3130
import java.lang.reflect.TypeVariable;
3231
import java.util.HashSet;
3332
import java.util.List;
3433
import java.util.Locale;
3534
import java.util.Map;
35+
import java.util.Objects;
3636
import java.util.Set;
3737
import junit.framework.TestCase;
3838
import org.jspecify.annotations.NullUnmarked;
@@ -185,7 +185,7 @@ public boolean equals(@Nullable Object obj) {
185185

186186
@Override
187187
public int hashCode() {
188-
return Objects.hashCode(name, parameterTypes, typeSignature);
188+
return Objects.hash(name, parameterTypes, typeSignature);
189189
}
190190

191191
@Override

android/guava-tests/test/com/google/common/collect/GeneralRangeTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,10 @@
2222
import com.google.common.annotations.GwtCompatible;
2323
import com.google.common.annotations.GwtIncompatible;
2424
import com.google.common.annotations.J2ktIncompatible;
25-
import com.google.common.base.Objects;
2625
import com.google.common.testing.NullPointerTester;
2726
import java.util.Arrays;
2827
import java.util.List;
28+
import java.util.Objects;
2929
import junit.framework.TestCase;
3030
import org.jspecify.annotations.NullMarked;
3131
import org.jspecify.annotations.Nullable;
@@ -84,7 +84,7 @@ public void testCreateSingletonRangeSucceeds() {
8484
for (Integer i : IN_ORDER_VALUES) {
8585
GeneralRange<@Nullable Integer> range = GeneralRange.range(ORDERING, i, CLOSED, i, CLOSED);
8686
for (Integer j : IN_ORDER_VALUES) {
87-
assertEquals(Objects.equal(i, j), range.contains(j));
87+
assertEquals(Objects.equals(i, j), range.contains(j));
8888
}
8989
}
9090
}

android/guava-tests/test/com/google/common/collect/MinMaxPriorityQueueTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616

1717
package com.google.common.collect;
1818

19-
import static com.google.common.base.Objects.equal;
2019
import static com.google.common.collect.Platform.reduceExponentIfGwt;
2120
import static com.google.common.collect.Platform.reduceIterationsIfGwt;
2221
import static com.google.common.collect.ReflectionFreeAssertThrows.assertThrows;
@@ -46,6 +45,7 @@
4645
import java.util.List;
4746
import java.util.Map;
4847
import java.util.NoSuchElementException;
48+
import java.util.Objects;
4949
import java.util.PriorityQueue;
5050
import java.util.Queue;
5151
import java.util.Random;
@@ -945,15 +945,15 @@ private static void assertIntactUsingStartedWith(
945945

946946
private static void assertEqualsUsingSeed(
947947
long seed, @Nullable Object expected, @Nullable Object actual) {
948-
if (!equal(actual, expected)) {
948+
if (!Objects.equals(actual, expected)) {
949949
// fail(), but with the JUnit-supplied message.
950950
assertEquals("Using seed " + seed, expected, actual);
951951
}
952952
}
953953

954954
private static void assertEqualsUsingStartedWith(
955955
Collection<?> startedWith, @Nullable Object expected, @Nullable Object actual) {
956-
if (!equal(actual, expected)) {
956+
if (!Objects.equals(actual, expected)) {
957957
// fail(), but with the JUnit-supplied message.
958958
assertEquals("Started with " + startedWith, expected, actual);
959959
}

android/guava-tests/test/com/google/common/collect/MultisetsCollectionTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@
2626
import static java.util.Collections.sort;
2727

2828
import com.google.common.annotations.GwtIncompatible;
29-
import com.google.common.base.Objects;
3029
import com.google.common.base.Predicate;
3130
import com.google.common.base.Predicates;
3231
import com.google.common.collect.testing.features.CollectionFeature;
@@ -37,6 +36,7 @@
3736
import java.util.ArrayList;
3837
import java.util.Collections;
3938
import java.util.List;
39+
import java.util.Objects;
4040
import junit.framework.Test;
4141
import junit.framework.TestCase;
4242
import junit.framework.TestSuite;
@@ -199,7 +199,7 @@ protected Multiset<String> create(String[] elements) {
199199
* "add an extra item 0 to A and an extra item 1 to B" really means
200200
* "add an extra item 0 to A and B," which isn't what we want.
201201
*/
202-
if (!Objects.equal(elements[0], elements[1])) {
202+
if (!Objects.equals(elements[0], elements[1])) {
203203
multiset2.add(elements[1], 2);
204204
}
205205
}

android/guava-tests/test/com/google/common/collect/SimpleAbstractMultisetTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
import com.google.common.annotations.GwtCompatible;
2121
import com.google.common.annotations.GwtIncompatible;
2222
import com.google.common.annotations.J2ktIncompatible;
23-
import com.google.common.base.Objects;
2423
import com.google.common.collect.testing.features.CollectionFeature;
2524
import com.google.common.collect.testing.features.CollectionSize;
2625
import com.google.common.collect.testing.google.MultisetTestSuiteBuilder;
@@ -30,6 +29,7 @@
3029
import java.util.HashMap;
3130
import java.util.Iterator;
3231
import java.util.Map;
32+
import java.util.Objects;
3333
import java.util.concurrent.atomic.AtomicInteger;
3434
import junit.framework.Test;
3535
import junit.framework.TestCase;
@@ -113,7 +113,7 @@ public void clear() {
113113
@Override
114114
public int count(@Nullable Object element) {
115115
for (Entry<E> entry : entrySet()) {
116-
if (Objects.equal(entry.getElement(), element)) {
116+
if (Objects.equals(entry.getElement(), element)) {
117117
return entry.getCount();
118118
}
119119
}

0 commit comments

Comments
 (0)