Skip to content

Commit 9159c2f

Browse files
cpovirkGoogle Java Core Libraries
authored andcommitted
Specify a new plexus-io version for maven-jar-plugin, too.
We already do for `maven-source-plugin`. Timings for `mvn clean install -DskipTests`: - Before: Total time: 08:24 min - After: Total time: 02:29 min The slowness that this CL addresses only surfaces under certain configurations, perhaps those with large/remote definitions of Unix groups? I worked around it a while back for my main machine by using `chgrp`, but I was reminded of it today by unicode-org/icu#3459, and I was able to reproduce the slowness on a temporary machine that I'm using on account of some network trouble and an impending desk move. I don't expect for GitHub CI to be affected, but I do wonder if this could help with our local releases. I know that our releases are slow because they have to run a lot of tests, but maybe they have been further slowed by the problem I'm addressing here? After all, they build under `/tmp` by default, and my `chgrp` workaround wouldn't affect that. If only Maven's output weren't [so verbose that our release script has to hide most of it](https://www.club.cc.cmu.edu/~cmccabe/blog_the_bad_build_system_drinking_game.html#:~:text=Take%20three%20shots%20if%20it%20generates%20more%20than%20a%20megabyte%20of%20output)... RELNOTES=n/a PiperOrigin-RevId: 742856755
1 parent 63ecdf2 commit 9159c2f

File tree

2 files changed

+16
-0
lines changed

2 files changed

+16
-0
lines changed

android/pom.xml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -248,6 +248,14 @@
248248
</manifestEntries>
249249
</archive>
250250
</configuration>
251+
<dependencies>
252+
<dependency>
253+
<groupId>org.codehaus.plexus</groupId>
254+
<artifactId>plexus-io</artifactId>
255+
<!-- We need at least 3.5.1 to avoid https://github.com/codehaus-plexus/plexus-io/issues/109. Once we upgrade maven-jar-plugin itself to a version new enough to depend on 3.5.1 or higher, we can remove this override. -->
256+
<version>3.5.1</version>
257+
</dependency>
258+
</dependencies>
251259
</plugin>
252260
<plugin>
253261
<artifactId>maven-javadoc-plugin</artifactId>

pom.xml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -249,6 +249,14 @@
249249
</manifestEntries>
250250
</archive>
251251
</configuration>
252+
<dependencies>
253+
<dependency>
254+
<groupId>org.codehaus.plexus</groupId>
255+
<artifactId>plexus-io</artifactId>
256+
<!-- We need at least 3.5.1 to avoid https://github.com/codehaus-plexus/plexus-io/issues/109. Once we upgrade maven-jar-plugin itself to a version new enough to depend on 3.5.1 or higher, we can remove this override. -->
257+
<version>3.5.1</version>
258+
</dependency>
259+
</dependencies>
252260
</plugin>
253261
<plugin>
254262
<artifactId>maven-javadoc-plugin</artifactId>

0 commit comments

Comments
 (0)