Remove @GwtIncompatible from LongMath.checkedSubtract

java-team-github-bot · Google Java Core Libraries · commit 99d2ced9e9a0 · 2024-10-09T09:39:37.000-07:00
RELNOTES=Remove @GwtIncompatible from LongMath.checkedSubtract
PiperOrigin-RevId: 684068945
diff --git a/android/guava-tests/test/com/google/common/math/LongMathTest.java b/android/guava-tests/test/com/google/common/math/LongMathTest.java
@@ -587,7 +587,6 @@ public void testCheckedAdd() {
     }
   }
 
-  @GwtIncompatible // TODO
   @AndroidIncompatible // slow
   public void testCheckedSubtract() {
     for (long a : ALL_LONG_CANDIDATES) {
diff --git a/android/guava/src/com/google/common/math/LongMath.java b/android/guava/src/com/google/common/math/LongMath.java
@@ -547,7 +547,6 @@ public static long checkedAdd(long a, long b) {
    *
    * @throws ArithmeticException if {@code a - b} overflows in signed {@code long} arithmetic
    */
-  @GwtIncompatible // TODO
   // Whenever both tests are cheap and functional, it's faster to use &, | instead of &&, ||
   @SuppressWarnings("ShortCircuitBoolean")
   public static long checkedSubtract(long a, long b) {
diff --git a/guava-tests/test/com/google/common/math/LongMathTest.java b/guava-tests/test/com/google/common/math/LongMathTest.java
@@ -587,7 +587,6 @@ public void testCheckedAdd() {
     }
   }
 
-  @GwtIncompatible // TODO
   @AndroidIncompatible // slow
   public void testCheckedSubtract() {
     for (long a : ALL_LONG_CANDIDATES) {
diff --git a/guava/src/com/google/common/math/LongMath.java b/guava/src/com/google/common/math/LongMath.java
@@ -547,7 +547,6 @@ public static long checkedAdd(long a, long b) {
    *
    * @throws ArithmeticException if {@code a - b} overflows in signed {@code long} arithmetic
    */
-  @GwtIncompatible // TODO
   // Whenever both tests are cheap and functional, it's faster to use &, | instead of &&, ||
   @SuppressWarnings("ShortCircuitBoolean")
   public static long checkedSubtract(long a, long b) {

Original file line number	Diff line number	Diff line change
`@@ -587,7 +587,6 @@ public void testCheckedAdd() {`
`587`	`587`	`}`
`588`	`588`	`}`
`589`	`589`
`590`		`- @GwtIncompatible // TODO`
`591`	`590`	`@AndroidIncompatible // slow`
`592`	`591`	`public void testCheckedSubtract() {`
`593`	`592`	`for (long a : ALL_LONG_CANDIDATES) {`
Original file line number	Diff line number	Diff line change
`@@ -547,7 +547,6 @@ public static long checkedAdd(long a, long b) {`
`547`	`547`	`*`
`548`	`548`	`* @throws ArithmeticException if {@code a - b} overflows in signed {@code long} arithmetic`
`549`	`549`	`*/`
`550`		`- @GwtIncompatible // TODO`
`551`	`550`	`// Whenever both tests are cheap and functional, it's faster to use &, \| instead of &&, \|\|`
`552`	`551`	`@SuppressWarnings("ShortCircuitBoolean")`
`553`	`552`	`public static long checkedSubtract(long a, long b) {`