Fix some https://errorprone.info/bugpattern/UnnecessaryFinal warnings.

RELNOTES=n/a
PiperOrigin-RevId: 728791732

Author: cpovirk

android/guava-testlib/src/com/google/common/collect/testing/AbstractIteratorTester.java

@@ -368,7 +368,7 @@ private void compareResultsForThisListOfStimuli() {
   }
 
   private static List<Object> subListCopy(Object[] source, int size) {
-    final Object[] copy = new Object[size];
+    Object[] copy = new Object[size];
     arraycopy(source, 0, copy, 0, size);
     return asList(copy);
   }
@@ -479,7 +479,7 @@ private <T extends Iterator<E>> void internalExecuteAndCompare(
       };
 
   private final IteratorOperation newAddMethod() {
-    final Object toInsert = elementsToInsert.next();
+    Object toInsert = elementsToInsert.next();
     return new IteratorOperation() {
       @Override
       public @Nullable Object execute(Iterator<?> iterator) {
@@ -492,7 +492,7 @@ private final IteratorOperation newAddMethod() {
   }
 
   private final IteratorOperation newSetMethod() {
-    final E toInsert = elementsToInsert.next();
+    E toInsert = elementsToInsert.next();
     return new IteratorOperation() {
       @Override
       public @Nullable Object execute(Iterator<?> iterator) {

android/guava-testlib/src/com/google/common/collect/testing/TestsForListsInJavaUtil.java

@@ -275,7 +275,7 @@ public Test testsForAbstractList() {
     return ListTestSuiteBuilder.using(
             new TestStringListGenerator() {
               @Override
-              protected List<String> create(final String[] elements) {
+              protected List<String> create(String[] elements) {
                 return new AbstractList<String>() {
                   @Override
                   public int size() {
@@ -300,9 +300,9 @@ public Test testsForAbstractSequentialList() {
     return ListTestSuiteBuilder.using(
             new TestStringListGenerator() {
               @Override
-              protected List<String> create(final String[] elements) {
+              protected List<String> create(String[] elements) {
                 // For this test we trust ArrayList works
-                final List<String> list = new ArrayList<>();
+                List<String> list = new ArrayList<>();
                 Collections.addAll(list, elements);
                 return new AbstractSequentialList<String>() {
                   @Override

android/guava-testlib/src/com/google/common/collect/testing/TestsForSetsInJavaUtil.java

@@ -351,7 +351,7 @@ public Test testsForAbstractSet() {
             new TestStringSetGenerator() {
               @Override
               protected Set<String> create(String[] elements) {
-                final String[] deduped = dedupe(elements);
+                String[] deduped = dedupe(elements);
                 return new AbstractSet<String>() {
                   @Override
                   public int size() {

android/guava-testlib/src/com/google/common/testing/ArbitraryInstances.java

@@ -365,7 +365,7 @@ private static <T> void setImplementation(Class<T> type, Class<? extends T> impl
     if (Modifier.isAbstract(type.getModifiers()) || !Modifier.isPublic(type.getModifiers())) {
       return arbitraryConstantInstanceOrNull(type);
     }
-    final Constructor<T> constructor;
+    Constructor<T> constructor;
     try {
       constructor = type.getConstructor();
     } catch (NoSuchMethodException e) {

android/guava-testlib/src/com/google/common/testing/ClassSanityTester.java

@@ -570,7 +570,7 @@ public FactoryMethodReturnValueTester testEqualsAndSerializable() throws Excepti
     }
   }
 
-  private void testEqualsUsing(final Invokable<?, ?> factory)
+  private void testEqualsUsing(Invokable<?, ?> factory)
       throws ParameterNotInstantiableException,
           ParameterHasNoDistinctValueException,
           IllegalAccessException,
@@ -587,7 +587,7 @@ private void testEqualsUsing(final Invokable<?, ?> factory)
     Object instance = createInstance(factory, args);
     List<Object> equalArgs = generateEqualFactoryArguments(factory, params, args);
     // Each group is a List of items, each item has a list of factory args.
-    final List<List<List<Object>>> argGroups = Lists.newArrayList();
+    List<List<List<Object>>> argGroups = Lists.newArrayList();
     argGroups.add(ImmutableList.of(args, equalArgs));
     EqualsTester tester =
         new EqualsTester(

android/guava-testlib/src/com/google/common/testing/FreshValueGenerator.java

@@ -193,7 +193,7 @@ final <T> void addSampleInstances(Class<T> type, Iterable<? extends T> instances
     return Primitives.wrap(type).cast(generateFresh(TypeToken.of(type)));
   }
 
-  final <T> T newFreshProxy(final Class<T> interfaceType) {
+  final <T> T newFreshProxy(Class<T> interfaceType) {
     T proxy = newProxy(interfaceType);
     freshness.incrementAndGet();
     return proxy;
@@ -268,7 +268,7 @@ final <T> T newFreshProxy(final Class<T> interfaceType) {
     return ArbitraryInstances.get(rawType);
   }
 
-  private <T> T newProxy(final Class<T> interfaceType) {
+  private <T> T newProxy(Class<T> interfaceType) {
     return Reflection.newProxy(interfaceType, new FreshInvocationHandler(interfaceType));
   }
 

android/guava-testlib/src/com/google/common/testing/NullPointerTester.java

@@ -451,7 +451,7 @@ private void testParameter(
   }
 
   private <F, T> Converter<F, T> defaultConverter(
-      final TypeToken<F> convertFromType, final TypeToken<T> convertToType) {
+      TypeToken<F> convertFromType, TypeToken<T> convertToType) {
     return new Converter<F, T>() {
       @Override
       protected T doForward(F a) {
@@ -477,7 +477,7 @@ private static TypeToken<?> getFirstTypeParameter(Type type) {
     }
   }
 
-  private <T> T newDefaultReturningProxy(final TypeToken<T> type) {
+  private <T> T newDefaultReturningProxy(TypeToken<T> type) {
     return new DummyProxy() {
       @Override
       <R> @Nullable R dummyReturnValue(TypeToken<R> returnType) {

android/guava/src/com/google/common/base/CharMatcher.java

@@ -294,7 +294,7 @@ public static CharMatcher singleWidth() {
   // Static factories
 
   /** Returns a {@code char} matcher that matches only one specified BMP character. */
-  public static CharMatcher is(final char match) {
+  public static CharMatcher is(char match) {
     return new Is(match);
   }
 
@@ -303,15 +303,15 @@ public static CharMatcher is(final char match) {
    *
    * <p>To negate another {@code CharMatcher}, use {@link #negate()}.
    */
-  public static CharMatcher isNot(final char match) {
+  public static CharMatcher isNot(char match) {
     return new IsNot(match);
   }
 
   /**
    * Returns a {@code char} matcher that matches any BMP character present in the given character
    * sequence. Returns a bogus matcher if the sequence contains supplementary characters.
    */
-  public static CharMatcher anyOf(final CharSequence sequence) {
+  public static CharMatcher anyOf(CharSequence sequence) {
     switch (sequence.length()) {
       case 0:
         return none();
@@ -341,15 +341,15 @@ public static CharMatcher noneOf(CharSequence sequence) {
    *
    * @throws IllegalArgumentException if {@code endInclusive < startInclusive}
    */
-  public static CharMatcher inRange(final char startInclusive, final char endInclusive) {
+  public static CharMatcher inRange(char startInclusive, char endInclusive) {
     return new InRange(startInclusive, endInclusive);
   }
 
   /**
    * Returns a matcher with identical behavior to the given {@link Character}-based predicate, but
    * which operates on primitive {@code char} instances instead.
    */
-  public static CharMatcher forPredicate(final Predicate<? super Character> predicate) {
+  public static CharMatcher forPredicate(Predicate<? super Character> predicate) {
     return predicate instanceof CharMatcher ? (CharMatcher) predicate : new ForPredicate(predicate);
   }
 
@@ -416,7 +416,7 @@ public CharMatcher precomputed() {
    */
   @GwtIncompatible // SmallCharMatcher
   CharMatcher precomputedInternal() {
-    final BitSet table = new BitSet();
+    BitSet table = new BitSet();
     setBits(table);
     int totalCharacters = table.cardinality();
     if (totalCharacters * 2 <= DISTINCT_CHARS) {
@@ -426,7 +426,7 @@ CharMatcher precomputedInternal() {
       table.flip(Character.MIN_VALUE, Character.MAX_VALUE + 1);
       int negatedCharacters = DISTINCT_CHARS - totalCharacters;
       String suffix = ".negate()";
-      final String description = toString();
+      String description = toString();
       String negatedDescription =
           description.endsWith(suffix)
               ? description.substring(0, description.length() - suffix.length())

android/guava/src/com/google/common/base/Optional.java

@@ -351,7 +351,7 @@ public java.util.Optional<T> toJavaUtil() {
    * @since 11.0 (generics widened in 13.0)
    */
   public static <T> Iterable<T> presentInstances(
-      final Iterable<? extends Optional<? extends T>> optionals) {
+      Iterable<? extends Optional<? extends T>> optionals) {
     checkNotNull(optionals);
     return () ->
         new AbstractIterator<T>() {

android/guava/src/com/google/common/base/Splitter.java

@@ -137,7 +137,7 @@ public static Splitter on(char separator) {
    *     separator
    * @return a splitter, with default settings, that uses this matcher
    */
-  public static Splitter on(final CharMatcher separatorMatcher) {
+  public static Splitter on(CharMatcher separatorMatcher) {
     checkNotNull(separatorMatcher);
 
     return new Splitter(
@@ -163,7 +163,7 @@ int separatorEnd(int separatorPosition) {
    * @param separator the literal, nonempty string to recognize as a separator
    * @return a splitter, with default settings, that recognizes that separator
    */
-  public static Splitter on(final String separator) {
+  public static Splitter on(String separator) {
     checkArgument(separator.length() != 0, "The separator may not be the empty string.");
     if (separator.length() == 1) {
       return Splitter.on(separator.charAt(0));
@@ -210,15 +210,15 @@ public static Splitter on(Pattern separatorPattern) {
   }
 
   /** Internal utility; see {@link #on(Pattern)} instead. */
-  static Splitter onPatternInternal(final CommonPattern separatorPattern) {
+  static Splitter onPatternInternal(CommonPattern separatorPattern) {
     checkArgument(
         !separatorPattern.matcher("").matches(),
         "The pattern may not match the empty string: %s",
         separatorPattern);
 
     return new Splitter(
         (splitter, toSplit) -> {
-          final CommonMatcher matcher = separatorPattern.matcher(toSplit);
+          CommonMatcher matcher = separatorPattern.matcher(toSplit);
           return new SplittingIterator(splitter, toSplit) {
             @Override
             public int separatorStart(int start) {
@@ -268,7 +268,7 @@ public static Splitter onPattern(String separatorPattern) {
    * @return a splitter, with default settings, that can split into fixed sized pieces
    * @throws IllegalArgumentException if {@code length} is zero or negative
    */
-  public static Splitter fixedLength(final int length) {
+  public static Splitter fixedLength(int length) {
     checkArgument(length > 0, "The length may not be less than 1");
 
     return new Splitter(
@@ -365,7 +365,7 @@ public Splitter trimResults(CharMatcher trimmer) {
    * @param sequence the sequence of characters to split
    * @return an iteration over the segments split from the parameter
    */
-  public Iterable<String> split(final CharSequence sequence) {
+  public Iterable<String> split(CharSequence sequence) {
     checkNotNull(sequence);
 
     return new Iterable<String>() {