Skip to content

Commit ff7c071

Browse files
cpovirkGoogle Java Core Libraries
authored andcommitted
Use JDK 23 for generating Javadoc, too.
This brings us to the newest released version, which also means that it matches the version that we use for javac, so we require one less JDK. cl/711811272 fixed [the error we'd previously been seeing with JDK 23](#6790 (comment)). (Also, if someone has a JDK 23 already installed and skips our auto-downloading, use it even if it's not Temurin. I'd made this change for most toolchain usages in cl/711746683, but I missed the usage one for Javadoc.) RELNOTES=n/a PiperOrigin-RevId: 711839263
1 parent c9e6926 commit ff7c071

File tree

3 files changed

+4
-39
lines changed

3 files changed

+4
-39
lines changed

.github/workflows/ci.yml

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -40,14 +40,12 @@ jobs:
4040
# When we specify multiple JDKs, the final one becomes the default, which is used to execute Maven itself.
4141
# Our Maven configuration then specifies different JDKs to use for some of the steps:
4242
# - 11 (sometimes) to *download* to support anyone who runs JDiff or our Gradle integration tests (including our doc snapshots and our Java 11 CI test run) but not to use directly
43-
# - 21 for building Javadoc
44-
# - 23 for running javac (to help people who build Guava locally and might not use a recent JDK to run Maven)
43+
# - 23 for running Javadoc and javac (to help people who build Guava locally and might not use a recent JDK to run Maven)
4544
- name: 'Set up JDKs'
4645
uses: actions/setup-java@8df1039502a15bceb9433410b1a100fbe190c53b # v4.5.0
4746
with:
4847
java-version: |
4948
${{ matrix.java }}
50-
21
5149
23
5250
distribution: 'temurin'
5351
cache: 'maven'
@@ -80,9 +78,7 @@ jobs:
8078
with:
8179
# For discussion, see the first setup-java block.
8280
# The publish-snapshot workflow doesn't run tests, so we don't have to care which version Maven would select for that step.
83-
java-version: |
84-
21
85-
23
81+
java-version: 23
8682
distribution: 'temurin'
8783
cache: 'maven'
8884
- name: 'Publish'
@@ -109,7 +105,6 @@ jobs:
109105
# But we need Java 11 for JDiff.
110106
java-version: |
111107
11
112-
21
113108
23
114109
distribution: 'temurin'
115110
cache: 'maven'

android/pom.xml

Lines changed: 1 addition & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -199,20 +199,6 @@
199199
rm -rf ~/.m2/jdks/ ~/.m2/toolchains.xml
200200
(But don't run that if you have put something into ~/.m2/toolchains.xml yourself.)
201201
-->
202-
<execution>
203-
<id>download-21</id>
204-
<goals>
205-
<goal>toolchain</goal>
206-
</goals>
207-
<configuration>
208-
<toolchains>
209-
<jdk>
210-
<version>21</version>
211-
<vendor>temurin</vendor>
212-
</jdk>
213-
</toolchains>
214-
</configuration>
215-
</execution>
216202
<execution>
217203
<id>download-23-and-surefire-version</id>
218204
<goals>
@@ -329,8 +315,7 @@
329315
<version>3.11.2</version>
330316
<configuration>
331317
<jdkToolchain>
332-
<version>21</version>
333-
<vendor>temurin</vendor>
318+
<version>23</version>
334319
</jdkToolchain>
335320
<quiet>true</quiet>
336321
<notimestamp>true</notimestamp>

pom.xml

Lines changed: 1 addition & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -200,20 +200,6 @@
200200
rm -rf ~/.m2/jdks/ ~/.m2/toolchains.xml
201201
(But don't run that if you have put something into ~/.m2/toolchains.xml yourself.)
202202
-->
203-
<execution>
204-
<id>download-21</id>
205-
<goals>
206-
<goal>toolchain</goal>
207-
</goals>
208-
<configuration>
209-
<toolchains>
210-
<jdk>
211-
<version>21</version>
212-
<vendor>temurin</vendor>
213-
</jdk>
214-
</toolchains>
215-
</configuration>
216-
</execution>
217203
<execution>
218204
<id>download-23-and-surefire-version</id>
219205
<goals>
@@ -324,8 +310,7 @@
324310
<version>3.11.2</version>
325311
<configuration>
326312
<jdkToolchain>
327-
<version>21</version>
328-
<vendor>temurin</vendor>
313+
<version>23</version>
329314
</jdkToolchain>
330315
<quiet>true</quiet>
331316
<notimestamp>true</notimestamp>

0 commit comments

Comments
 (0)