From 2b1c39e9615be3bfd6750fc8e3bd4b664291b18b Mon Sep 17 00:00:00 2001
From: Tanush-Jain <tanushjain2004@hotmail.com>
Date: Sat, 8 Nov 2025 19:44:34 +0530
Subject: [PATCH] Add Javadoc documentation to Cache.compute method

---
 guava/src/com/google/common/cache/Cache.java  | 32 ++++++++++++++++---
 .../google/common/cache/ForwardingCache.java  | 22 +++++++++++++
 2 files changed, 49 insertions(+), 5 deletions(-)

diff --git a/guava/src/com/google/common/cache/Cache.java b/guava/src/com/google/common/cache/Cache.java
index cfa1641562fc..accf59e7db5d 100644
--- a/guava/src/com/google/common/cache/Cache.java
+++ b/guava/src/com/google/common/cache/Cache.java
@@ -14,6 +14,14 @@
 
 package com.google.common.cache;
 
+import java.util.Map;
+import java.util.concurrent.Callable;
+import java.util.concurrent.ConcurrentMap;
+import java.util.concurrent.ExecutionException;
+import java.util.function.BiFunction;
+
+import org.jspecify.annotations.Nullable;
+
 import com.google.common.annotations.GwtCompatible;
 import com.google.common.collect.ImmutableMap;
 import com.google.common.util.concurrent.ExecutionError;
@@ -21,11 +29,6 @@
 import com.google.errorprone.annotations.CanIgnoreReturnValue;
 import com.google.errorprone.annotations.CompatibleWith;
 import com.google.errorprone.annotations.DoNotMock;
-import java.util.Map;
-import java.util.concurrent.Callable;
-import java.util.concurrent.ConcurrentMap;
-import java.util.concurrent.ExecutionException;
-import org.jspecify.annotations.Nullable;
 
 /**
  * A semi-persistent mapping from keys to values. Cache entries are manually added using {@link
@@ -180,4 +183,23 @@ public interface Cache<K, V> {
    * performed -- if any -- is implementation-dependent.
    */
   void cleanUp();
+
+  /**
+   * Attempts to compute a mapping for the specified key and its current mapped value (or {@code
+   * null} if there is no current mapping). The entire method invocation is performed atomically.
+   * Some attempted update operations on this cache by other threads may be blocked while
+   * computation is in progress, so the computation should be short and simple, and must not
+   * attempt to update any other mappings of this cache.
+   *
+   * <p>The {@code remappingFunction} may throw an (unchecked) exception. The exception is
+   * rethrown, and the current mapping is left unchanged.
+   *
+   * @param key key with which the specified value is to be associated
+   * @param remappingFunction the function to compute a value
+   * @return the new value associated with the specified key, or {@code null} if the mapping was
+   *     removed
+   * @since 23.0
+   */
+  @CanIgnoreReturnValue
+  @Nullable V compute(K key, BiFunction<? super K, ? super @Nullable V, ? extends @Nullable V> remappingFunction);
 }
diff --git a/guava/src/com/google/common/cache/ForwardingCache.java b/guava/src/com/google/common/cache/ForwardingCache.java
index be7df89a3566..1b1199420cc8 100644
--- a/guava/src/com/google/common/cache/ForwardingCache.java
+++ b/guava/src/com/google/common/cache/ForwardingCache.java
@@ -22,6 +22,8 @@
 import java.util.concurrent.Callable;
 import java.util.concurrent.ConcurrentMap;
 import java.util.concurrent.ExecutionException;
+import java.util.function.BiFunction;
+import java.util.function.Function;
 import org.jspecify.annotations.Nullable;
 
 /**
@@ -124,6 +126,26 @@ public void cleanUp() {
     delegate().cleanUp();
   }
 
+  @Override
+  public @Nullable V compute(K key, BiFunction<? super K, ? super @Nullable V, ? extends @Nullable V> remappingFunction) {
+    return delegate().compute(key, remappingFunction);
+  }
+
+  @Override
+  public V computeIfAbsent(K key, Function<? super K, ? extends V> mappingFunction) {
+    return delegate().computeIfAbsent(key, mappingFunction);
+  }
+
+  @Override
+  public @Nullable V computeIfPresent(K key, BiFunction<? super K, ? super V, ? extends @Nullable V> remappingFunction) {
+    return delegate().computeIfPresent(key, remappingFunction);
+  }
+
+  @Override
+  public @Nullable V merge(K key, V value, BiFunction<? super V, ? super V, ? extends @Nullable V> remappingFunction) {
+    return delegate().merge(key, value, remappingFunction);
+  }
+
   /**
    * A simplified version of {@link ForwardingCache} where subclasses can pass in an already
    * constructed {@link Cache} as the delegate.