Skip to content

Commit f8854c4

Browse files
EtiennePerotgvisor-bot
authored andcommitted
Move PGO profile data to runsc/profiles/data.
The intermediate directory `runsc/profiles` is a convenient place to store things like aggregate BUILD rules for merging profiles together. Keep all the changing stuff in a subdirectory. PiperOrigin-RevId: 775895482
1 parent ca812bc commit f8854c4

File tree

5 files changed

+5
-5
lines changed

5 files changed

+5
-5
lines changed

.buildkite/scripts/pgo/commit-update.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ git stash
3030
git pull --rebase=true "$repo_url" master
3131
git checkout -b "$pgo_branch_name"
3232
git stash pop
33-
git add runsc/profiles
33+
git add runsc/profiles/data
3434
git status
3535

3636
# Commit and push PR branch.

.buildkite/scripts/pgo/maybe-skip.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ if [[ "$(gh pr --repo="$repo_url" list --label pgo-update --state open --json ti
5353
fi
5454

5555
if [[ "$tolerate_no_profile_changes" == false ]]; then
56-
if [[ "$(git status --porcelain runsc/profiles | wc -l)" == 0 ]]; then
56+
if [[ "$(git status --porcelain runsc/profiles/data | wc -l)" == 0 ]]; then
5757
echo "No changes to runsc profiles; skipping." >&2
5858
exit 0
5959
fi

Makefile

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -568,15 +568,15 @@ benchmark-refresh-pgo: load-benchmarks $(RUNTIME_BIN) ## Refresh profiles of all
568568
export PGO_LAST_PKG_COMMIT_HASH; \
569569
for PLATFORM in $(BENCHMARKS_PLATFORMS); do \
570570
export PLATFORM; \
571-
mkdir -p "$(REPO_DIR)/runsc/profiles/$${PGO_RUNTIME_KEY}_$${PLATFORM}"; \
571+
mkdir -p "$(REPO_DIR)/runsc/profiles/data/$${PGO_RUNTIME_KEY}_$${PLATFORM}"; \
572572
PLATFORM_TMPDIR="$$(mktemp --tmpdir=/tmp --directory "pgo_$${PGO_RUNTIME_KEY}_$${PLATFORM}.XXXXXXXX")"; \
573573
export PLATFORM_TMPDIR; \
574574
for PGO_BENCHMARK_TARGET in $$( $(call query,'attr(tags, gvisor_pgo_benchmark, //test/benchmarks/...)') | sed 's~^//~~'); do \
575575
PGO_BENCHMARK_BASENAME="$$(echo "$${PGO_BENCHMARK_TARGET}" | cut -d: -f2 | sed 's/_test$$//')"; \
576576
export PGO_BENCHMARK_BASENAME; \
577-
PGO_PROFILE_OLD_COMMIT_HASH="$(REPO_DIR)/runsc/profiles/$${PGO_RUNTIME_KEY}_$${PLATFORM}/$${PGO_BENCHMARK_BASENAME}.pgo.pkg_commithash"; \
577+
PGO_PROFILE_OLD_COMMIT_HASH="$(REPO_DIR)/runsc/profiles/data/$${PGO_RUNTIME_KEY}_$${PLATFORM}/$${PGO_BENCHMARK_BASENAME}.pgo.pkg_commithash"; \
578578
export PGO_PROFILE_OLD_COMMIT_HASH; \
579-
PGO_PROFILE_OLD="$(REPO_DIR)/runsc/profiles/$${PGO_RUNTIME_KEY}_$${PLATFORM}/$${PGO_BENCHMARK_BASENAME}.pgo.pprof.pb.gz"; \
579+
PGO_PROFILE_OLD="$(REPO_DIR)/runsc/profiles/data/$${PGO_RUNTIME_KEY}_$${PLATFORM}/$${PGO_BENCHMARK_BASENAME}.pgo.pprof.pb.gz"; \
580580
export PGO_PROFILE_OLD; \
581581
PGO_PROFILE_NEW="$${PLATFORM_TMPDIR}/$${PGO_BENCHMARK_BASENAME}.pgo.pprof.pb.gz"; \
582582
export PGO_PROFILE_NEW; \

runsc/profiles/go1.24.1-linux-amd64_systrap/ffmpeg.pgo.pkg_commithash renamed to runsc/profiles/data/go1.24.1-linux-amd64_systrap/ffmpeg.pgo.pkg_commithash

File renamed without changes.

runsc/profiles/go1.24.1-linux-amd64_systrap/ffmpeg.pgo.pprof.pb.gz renamed to runsc/profiles/data/go1.24.1-linux-amd64_systrap/ffmpeg.pgo.pprof.pb.gz

File renamed without changes.

0 commit comments

Comments
 (0)