Fix some settings item styles

Change-Id: I6ace3747325b99e73637742066e274b29766266b

Author: jdkoren

mobile/src/main/res/layout/fragment_settings.xml

@@ -158,11 +158,12 @@
 
                     <TextView
                         android:id="@+id/version_build_number"
-                        android:layout_width="wrap_content"
+                        android:layout_width="match_parent"
                         android:layout_height="wrap_content"
                         android:gravity="start|center_vertical"
-                        android:minHeight="48dp"
-                        android:padding="@dimen/margin_normal"
+                        android:minHeight="?listPreferredItemHeightSmall"
+                        android:paddingEnd="?listPreferredItemPaddingEnd"
+                        android:paddingStart="?listPreferredItemPaddingStart"
                         android:textAppearance="?textAppearanceBody2"
                         app:versionName="@{BuildConfig.VERSION_NAME}" />
 
@@ -172,12 +173,10 @@
                         android:layout_gravity="center"
                         android:layout_marginTop="@dimen/margin_normal"
                         android:drawablePadding="@dimen/margin_small"
-                        android:drawableStart="@drawable/ic_logo_components"
                         android:gravity="center"
-                        android:paddingEnd="@dimen/margin_normal"
-                        android:paddingStart="@dimen/margin_normal"
                         android:text="@string/built_with_material_components"
-                        android:textAppearance="?attr/textAppearanceBody1" />
+                        android:textAppearance="?attr/textAppearanceBody1"
+                        app:drawableStartCompat="@drawable/ic_logo_components" />
 
                 </LinearLayout>
 

mobile/src/main/res/layout/item_generic_section_header.xml

@@ -30,8 +30,8 @@
         android:layout_height="wrap_content"
         android:gravity="start|center_vertical"
         android:minHeight="?actionBarSize"
-        android:paddingLeft="@{ sectionHeader.useHorizontalPadding ? @dimen/margin_normal : 0 }"
-        android:paddingRight="@{ sectionHeader.useHorizontalPadding ? @dimen/margin_normal : 0 }"
+        android:paddingEnd="@{ sectionHeader.useHorizontalPadding ? @dimen/margin_normal : 0 }"
+        android:paddingStart="@{ sectionHeader.useHorizontalPadding ? @dimen/margin_normal : 0 }"
         android:textAlignment="viewStart"
         android:textAppearance="@style/TextAppearance.IOSched.Overline"
         android:text="@{sectionHeader.titleId}"

mobile/src/main/res/values/styles.xml

@@ -255,7 +255,7 @@
         <item name="android:gravity">center_vertical</item>
         <item name="android:minHeight">?listPreferredItemHeightSmall</item>
         <item name="android:paddingBottom">@dimen/spacing_normal</item>
-        <item name="android:paddingRight">?listPreferredItemPaddingEnd</item>
+        <item name="android:paddingEnd">?listPreferredItemPaddingEnd</item>
         <item name="android:paddingStart">?listPreferredItemPaddingStart</item>
         <item name="android:paddingTop">@dimen/spacing_normal</item>
         <item name="android:textColor">?android:textColorPrimary</item>
@@ -265,8 +265,7 @@
 
     <style name="Widget.IOSched.AccountDialog.ManageAccountButton" parent="Widget.MaterialComponents.Button.OutlinedButton">
         <item name="android:textColor">?android:textColorSecondary</item>
-        <item name="shapeAppearanceOverlay">@style/ShapeAppearanceOverlay.MaterialComponents.Chip
-        </item>
+        <item name="shapeAppearanceOverlay">@style/ShapeAppearanceOverlay.MaterialComponents.Chip</item>
     </style>
 
     <!-- Onboarding -->
@@ -329,7 +328,10 @@
         <item name="android:background">@null</item>
         <item name="android:foreground">?selectableItemBackground</item>
         <item name="android:minHeight">?android:attr/listPreferredItemHeightSmall</item>
-        <item name="android:padding">@dimen/margin_normal</item>
+        <item name="android:paddingBottom">@dimen/spacing_normal</item>
+        <item name="android:paddingEnd">?listPreferredItemPaddingEnd</item>
+        <item name="android:paddingStart">?listPreferredItemPaddingStart</item>
+        <item name="android:paddingTop">@dimen/spacing_normal</item>
         <item name="android:textAlignment">viewStart</item>
         <item name="switchPadding">@dimen/margin_small</item>
         <item name="switchTextAppearance">?attr/textAppearanceBody2</item>
@@ -340,7 +342,7 @@
         <item name="android:gravity">start|center_vertical</item>
         <item name="android:minHeight">?listPreferredItemHeightSmall</item>
         <item name="android:paddingBottom">@dimen/spacing_normal</item>
-        <item name="android:paddingRight">?listPreferredItemPaddingEnd</item>
+        <item name="android:paddingEnd">?listPreferredItemPaddingEnd</item>
         <item name="android:paddingStart">?listPreferredItemPaddingStart</item>
         <item name="android:paddingTop">@dimen/spacing_normal</item>
         <item name="android:textAlignment">viewStart</item>