More sharing of test logic

Author: kevmoo

example/test/example_test.dart

@@ -4,6 +4,7 @@
 
 import 'dart:convert';
 
+import 'package:_json_serial_shared_test/shared_test.dart';
 import 'package:example/example.dart';
 import 'package:test/test.dart';
 
@@ -12,7 +13,7 @@ void main() {
     final person = Person('Inigo', 'Montoya', DateTime(1560, 5, 5))
       ..orders = [Order(DateTime.now())..item = (Item()..count = 42)];
 
-    final personJson = _encode(person);
+    final personJson = loudEncode(person);
 
     final person2 =
         Person.fromJson(json.decode(personJson) as Map<String, dynamic>);
@@ -23,13 +24,10 @@ void main() {
     expect(person.orders.single.date, person2.orders.single.date);
     expect(person.orders.single.item!.count, 42);
 
-    expect(_encode(person2), equals(personJson));
+    expect(loudEncode(person2), equals(personJson));
   });
 
   test('JsonLiteral', () {
     expect(glossaryData, hasLength(1));
   });
 }
-
-String _encode(Object object) =>
-    const JsonEncoder.withIndent(' ').convert(object);

example/test/json_convert_example_test.dart

@@ -4,6 +4,7 @@
 
 import 'dart:convert';
 
+import 'package:_json_serial_shared_test/shared_test.dart';
 import 'package:example/json_converter_example.dart';
 import 'package:test/test.dart';
 
@@ -13,7 +14,7 @@ void main() {
 
     final epochDateTime = DateTime.fromMillisecondsSinceEpoch(value);
     final instance = DateTimeExample(epochDateTime);
-    final json = _encode(instance);
+    final json = loudEncode(instance);
     expect(json, '''{
  "when": $value
 }''');
@@ -27,13 +28,13 @@ void main() {
     final collection = GenericCollection<int>(
         page: 0, totalPages: 3, totalResults: 10, results: [1, 2, 3]);
 
-    final encoded = _encode(collection);
+    final encoded = loudEncode(collection);
     final collection2 = GenericCollection<int>.fromJson(
         jsonDecode(encoded) as Map<String, dynamic>);
 
     expect(collection2.results, [1, 2, 3]);
 
-    expect(_encode(collection2), encoded);
+    expect(loudEncode(collection2), encoded);
   });
 
   test('custom result', () {
@@ -43,13 +44,13 @@ void main() {
         totalResults: 10,
         results: [CustomResult('bob', 42)]);
 
-    final encoded = _encode(collection);
+    final encoded = loudEncode(collection);
     final collection2 = GenericCollection<CustomResult>.fromJson(
         jsonDecode(encoded) as Map<String, dynamic>);
 
     expect(collection2.results, [CustomResult('bob', 42)]);
 
-    expect(_encode(collection2), encoded);
+    expect(loudEncode(collection2), encoded);
   });
 
   test('mixed values in generic collection', () {
@@ -64,22 +65,22 @@ void main() {
       CustomResult('bob', 42)
     ]);
 
-    final encoded = _encode(collection);
+    final encoded = loudEncode(collection);
 
     expect(
       () => GenericCollection<CustomResult>.fromJson(
           jsonDecode(encoded) as Map<String, dynamic>),
-      _throwsTypeError,
+      throwsTypeError,
     );
     expect(
       () => GenericCollection<int>.fromJson(
           jsonDecode(encoded) as Map<String, dynamic>),
-      _throwsTypeError,
+      throwsTypeError,
     );
     expect(
       () => GenericCollection<String>.fromJson(
           jsonDecode(encoded) as Map<String, dynamic>),
-      _throwsTypeError,
+      throwsTypeError,
     );
 
     final collection2 =
@@ -95,11 +96,6 @@ void main() {
       CustomResult('bob', 42)
     ]);
 
-    expect(_encode(collection2), encoded);
+    expect(loudEncode(collection2), encoded);
   });
 }
-
-final _throwsTypeError = throwsA(isA<TypeError>());
-
-String _encode(Object object) =>
-    const JsonEncoder.withIndent(' ').convert(object);

example/test/tuple_example_test.dart

@@ -4,6 +4,7 @@
 
 import 'dart:convert';
 
+import 'package:_json_serial_shared_test/shared_test.dart';
 import 'package:example/tuple_example.dart';
 import 'package:test/test.dart';
 
@@ -14,7 +15,7 @@ void main() {
       Tuple(const Duration(seconds: 42), BigInt.two),
     );
 
-    final encoded = _encode(instance);
+    final encoded = loudEncode(instance);
 
     const expected = r'''
 {
@@ -32,10 +33,7 @@ void main() {
     final decoded = ConcreteClass.fromJson(
       jsonDecode(encoded) as Map<String, dynamic>,
     );
-    final encoded2 = _encode(decoded);
+    final encoded2 = loudEncode(decoded);
     expect(encoded2, encoded);
   });
 }
-
-String _encode(Object object) =>
-    const JsonEncoder.withIndent(' ').convert(object);

json_serializable/test/annotation_version_test.dart

@@ -4,7 +4,6 @@
 
 @TestOn('vm')
 @Tags(['presubmit-only'])
-import 'dart:convert';
 import 'dart:io';
 
 import 'package:json_serializable/src/check_dependencies.dart';
@@ -15,6 +14,8 @@ import 'package:test/test.dart';
 import 'package:test_descriptor/test_descriptor.dart' as d;
 import 'package:test_process/test_process.dart';
 
+import 'test_utils.dart';
+
 void main() {
   test('validate pubspec constraint', () {
     final annotationConstraint =
@@ -116,7 +117,7 @@ Future<void> _structurePackage({
   Map<String, dynamic> dependencies = const {},
   Map<String, dynamic> devDependencies = const {},
 }) async {
-  final pubspec = const JsonEncoder.withIndent(' ').convert(
+  final pubspec = loudEncode(
     {
       'name': '_test_pkg',
       'environment': {'sdk': '>=2.14.0 <3.0.0'},

json_serializable/test/test_utils.dart

@@ -3,13 +3,8 @@
 // BSD-style license that can be found in the LICENSE file.
 
 import 'package:collection/collection.dart';
-import 'package:test/test.dart';
 
 export 'package:_json_serial_shared_test/shared_test.dart';
 
-final throwsTypeError = throwsA(isTypeError);
-
-final isTypeError = isA<TypeError>();
-
 bool deepEquals(dynamic a, dynamic b) =>
     const DeepCollectionEquality().equals(a, b);

shared_test/lib/shared_test.dart

@@ -3,6 +3,10 @@ import 'dart:convert';
 import 'package:stack_trace/stack_trace.dart';
 import 'package:test/test.dart';
 
+final throwsTypeError = throwsA(isTypeError);
+
+final isTypeError = isA<TypeError>();
+
 /// Prints out nested causes before throwing `JsonUnsupportedObjectError`.
 String loudEncode(Object? object) {
   try {