Make casts to int safe in dart2wasm. (#1416)

Co-authored-by: Kevin Moore <[email protected]>

Author: eyebrowsoffire

_test_yaml/pubspec.yaml

@@ -11,7 +11,7 @@ dev_dependencies:
   build_verify: ^3.0.0
   checked_yaml: any
   dart_flutter_team_lints: ^2.0.0
-  json_annotation: ^4.7.0
+  json_annotation: ^4.8.1
   json_serializable: any
   path: ^1.8.2
   test: ^1.6.0

_test_yaml/test/src/build_config.g.dart

@@ -181,7 +181,7 @@ class JsonSerializable {
   ///   T Function(Object json) fromJsonT,
   /// ) {
   ///   return Response<T>()
-  ///     ..status = json['status'] as int
+  ///     ..status = (json['status'] as num).toInt()
   ///     ..value = fromJsonT(json['value']);
   /// }
   ///

example/lib/example.g.dart

@@ -1,8 +1,11 @@
 ## 6.8.0-wip
 
 - Add type arguments to `Map` literals used for `Record` serialization.
-- Added support for generating `ExampleJsonKeys`, exposing a secured way to access the json keys from the properties.
+- Added support for generating `ExampleJsonKeys`, exposing a secured way to 
+  access the json keys from the properties.
   ([#1164](https://github.com/google/json_serializable.dart/pull/1164))
+- Handle decoding an `int` value from a `double` literal. 
+  This now matches the behavior of `double` values being encoded as `int`.
 
 ## 6.7.1
 

example/lib/generic_response_class_example.g.dart

@@ -20,9 +20,8 @@ class LambdaResult {
   final String lambda;
   final DartType? asContent;
 
-  String get _asContent => asContent == null ? '' : _asStatement(asContent!);
-
-  String get _fullExpression => '$expression$_asContent';
+  String get _fullExpression =>
+      asContent != null ? _cast(expression, asContent!) : expression;
 
   LambdaResult(this.expression, this.lambda, {this.asContent});
 
@@ -35,29 +34,35 @@ class LambdaResult {
           : '($closureArg) => $subField';
 }
 
-String _asStatement(DartType type) {
-  if (type.isLikeDynamic) {
-    return '';
+String _cast(String expression, DartType targetType) {
+  if (targetType.isLikeDynamic) {
+    return expression;
   }
 
-  final nullableSuffix = type.isNullableType ? '?' : '';
+  final nullableSuffix = targetType.isNullableType ? '?' : '';
 
-  if (coreIterableTypeChecker.isAssignableFromType(type)) {
-    final itemType = coreIterableGenericType(type);
+  if (coreIterableTypeChecker.isAssignableFromType(targetType)) {
+    final itemType = coreIterableGenericType(targetType);
     if (itemType.isLikeDynamic) {
-      return ' as List$nullableSuffix';
+      return '$expression as List$nullableSuffix';
     }
   }
 
-  if (coreMapTypeChecker.isAssignableFromType(type)) {
-    final args = type.typeArgumentsOf(coreMapTypeChecker)!;
+  if (coreMapTypeChecker.isAssignableFromType(targetType)) {
+    final args = targetType.typeArgumentsOf(coreMapTypeChecker)!;
     assert(args.length == 2);
 
     if (args.every((e) => e.isLikeDynamic)) {
-      return ' as Map$nullableSuffix';
+      return '$expression as Map$nullableSuffix';
     }
   }
 
-  final typeCode = typeToCode(type);
-  return ' as $typeCode';
+  final defaultDecodeValue = defaultDecodeLogic(targetType, expression);
+
+  if (defaultDecodeValue != null) {
+    return defaultDecodeValue;
+  }
+
+  final typeCode = typeToCode(targetType);
+  return '$expression as $typeCode';
 }

example/lib/json_converter_example.g.dart

@@ -46,7 +46,7 @@ class DurationHelper extends TypeHelper {
 
     return DefaultContainer(
       expression,
-      'Duration(microseconds: $expression as int)',
+      'Duration(microseconds: ($expression as num).toInt())',
     );
   }
 }